DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
* issue with uninitialized value used in a comparison in gbcodec_mixer_dapm_ctl_put
@ 2020-07-30 16:02 Colin Ian King
  2020-07-31  5:08 ` Vaibhav Agarwal
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2020-07-30 16:02 UTC (permalink / raw)
  To: Johan Hovold, Alex Elder, Greg Kroah-Hartman <gregkh,
	Vaibhav Agarwal, Mark Greer, greybus-dev, devel
  Cc: linux-kernel

Hi,

Static analysis with Coverity has detected an uninitialized value being
used in a comparison.  The error was detected on a recent change to
drivers/staging/greybus/audio_topology.c however the issue actually
dates back to the original commit:

commit 6339d2322c47f4b8ebabf9daf0130328ed72648b
Author: Vaibhav Agarwal <vaibhav.agarwal@linaro.org>
Date:   Wed Jan 13 14:07:51 2016 -0700

    greybus: audio: Add topology parser for GB codec

The analysis is as follows:

425 static int gbcodec_mixer_dapm_ctl_put(struct snd_kcontrol *kcontrol,
426                                      struct snd_ctl_elem_value
*ucontrol)
427 {
428        int ret, wi, max, connect;
429        unsigned int mask, val;
430        struct gb_audio_ctl_elem_info *info;
431        struct gbaudio_ctl_pvt *data;

   1. var_decl: Declaring variable gbvalue without initializer.
432        struct gb_audio_ctl_elem_value gbvalue;
433        struct gbaudio_module_info *module;
434        struct snd_soc_dapm_widget_list *wlist =
snd_kcontrol_chip(kcontrol);
435        struct snd_soc_dapm_widget *widget = wlist->widgets[0];
436        struct device *codec_dev = widget->dapm->dev;
437        struct gbaudio_codec_info *gb = dev_get_drvdata(codec_dev);
438        struct gb_bundle *bundle;
439

   2. Condition 0 /* __builtin_types_compatible_p() */, taking false branch.
   3. Condition 1 /* __builtin_types_compatible_p() */, taking true branch.
   4. Falling through to end of if statement.
   5. Condition !!branch, taking false branch.
   6. Condition ({...; !!branch;}), taking false branch.

440        dev_dbg(codec_dev, "Entered %s:%s\n", __func__,
kcontrol->id.name);
441        module = find_gb_module(gb, kcontrol->id.name);

   7. Condition !module, taking false branch.
442        if (!module)
443                return -EINVAL;
444
445        data = (struct gbaudio_ctl_pvt *)kcontrol->private_value;
446        info = (struct gb_audio_ctl_elem_info *)data->info;

   8. Condition 0 /* !!(!__builtin_types_compatible_p() &&
!__builtin_types_compatible_p()) */, taking false branch.
447        bundle = to_gb_bundle(module->dev);
448

   9. Condition data->vcount == 2, taking true branch.
449        if (data->vcount == 2)
450                dev_warn(widget->dapm->dev,
451                         "GB: Control '%s' is stereo, which is not
supported\n",
452                         kcontrol->id.name);
453
454        max = le32_to_cpu(info->value.integer.max);
455        mask = (1 << fls(max)) - 1;
456        val = ucontrol->value.integer.value[0] & mask;

   10. Condition !!val, taking true branch.
457        connect = !!val;
458
459        /* update ucontrol */

Uninitialized scalar variable (UNINIT)
   11. uninit_use: Using uninitialized value gbvalue.value.integer_value[0].
460        if (gbvalue.value.integer_value[0] != val) {

The gbvalue.value.integer_value[0] read is bogus since gbvalue was
declared on the stack but was not initialized.  There seems to be no
where that sets this data. I'm assuming most of the time that the
comparison works because the garbage value is different from val and so
the code in the if stanza is executed.

Anyhow, I'm unsure what the original intent of the code was, so I've not
attempted to fix this.

Colin


_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: issue with uninitialized value used in a comparison in gbcodec_mixer_dapm_ctl_put
  2020-07-30 16:02 issue with uninitialized value used in a comparison in gbcodec_mixer_dapm_ctl_put Colin Ian King
@ 2020-07-31  5:08 ` Vaibhav Agarwal
  0 siblings, 0 replies; 2+ messages in thread
From: Vaibhav Agarwal @ 2020-07-31  5:08 UTC (permalink / raw)
  To: Colin Ian King
  Cc: devel, Alex Elder, Mark Greer, Johan Hovold, linux-kernel, greybus-dev

On Thu, Jul 30, 2020 at 05:02:22PM +0100, Colin Ian King wrote:
> Hi,
> 
> Static analysis with Coverity has detected an uninitialized value being
> used in a comparison.  The error was detected on a recent change to
> drivers/staging/greybus/audio_topology.c however the issue actually
> dates back to the original commit:

Thanks Colin for reporting the issue. I'll fix the same and share a 
patch soon.

--
Regards,
Vaibhav
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 16:02 issue with uninitialized value used in a comparison in gbcodec_mixer_dapm_ctl_put Colin Ian King
2020-07-31  5:08 ` Vaibhav Agarwal

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git