DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
* staging: most: Build error since commit "drivers: most: add USB adapter driver"
@ 2020-08-02  9:08 Michael Straube
  2020-08-02  9:18 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Straube @ 2020-08-02  9:08 UTC (permalink / raw)
  To: gregkh; +Cc: devel, christian.gromm, linux-kernel

Hi,

with commit 97a6f772f36b7f52bcfa56a581bbd2470cffe23d ("drivers: most: add USB adapter driver")
I get build errors.

$ LANG=C make clean drivers/staging/rtl8188eu/
scripts/Makefile.clean:15: drivers/staging/most/usb/Makefile: No such file or directory
make[5]: *** No rule to make target 'drivers/staging/most/usb/Makefile'.  Stop.
make[4]: *** [scripts/Makefile.clean:66: drivers/staging/most/usb] Error 2
make[3]: *** [scripts/Makefile.clean:66: drivers/staging/most] Error 2
make[2]: *** [scripts/Makefile.clean:66: drivers/staging] Error 2
make[1]: *** [Makefile:1763: _clean_drivers] Error 2
make: *** [Makefile:336: __build_one_by_one] Error 2

Did you forgot to remove the below line from drivers/staging/most/Makefile ?

obj-$(CONFIG_MOST_USB)	+= usb/


Regards,
Michael
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: staging: most: Build error since commit "drivers: most: add USB adapter driver"
  2020-08-02  9:08 staging: most: Build error since commit "drivers: most: add USB adapter driver" Michael Straube
@ 2020-08-02  9:18 ` Greg KH
  2020-08-02  9:21   ` [PATCH] staging: most: fix up movement of USB driver Greg Kroah-Hartman
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-08-02  9:18 UTC (permalink / raw)
  To: Michael Straube; +Cc: devel, christian.gromm, linux-kernel

On Sun, Aug 02, 2020 at 11:08:12AM +0200, Michael Straube wrote:
> Hi,
> 
> with commit 97a6f772f36b7f52bcfa56a581bbd2470cffe23d ("drivers: most: add USB adapter driver")
> I get build errors.
> 
> $ LANG=C make clean drivers/staging/rtl8188eu/
> scripts/Makefile.clean:15: drivers/staging/most/usb/Makefile: No such file or directory
> make[5]: *** No rule to make target 'drivers/staging/most/usb/Makefile'.  Stop.
> make[4]: *** [scripts/Makefile.clean:66: drivers/staging/most/usb] Error 2
> make[3]: *** [scripts/Makefile.clean:66: drivers/staging/most] Error 2
> make[2]: *** [scripts/Makefile.clean:66: drivers/staging] Error 2
> make[1]: *** [Makefile:1763: _clean_drivers] Error 2
> make: *** [Makefile:336: __build_one_by_one] Error 2
> 
> Did you forgot to remove the below line from drivers/staging/most/Makefile ?
> 
> obj-$(CONFIG_MOST_USB)	+= usb/

Ugh, yes, let me go fix that up right now, sorry...

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] staging: most: fix up movement of USB driver
  2020-08-02  9:18 ` Greg KH
@ 2020-08-02  9:21   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-08-02  9:21 UTC (permalink / raw)
  To: Michael Straube; +Cc: devel, christian.gromm, linux-kernel

When moving the most usb driver out of staging, we forgot to remove the
subdirectory out of the staging Makefile as well.

Fixes: 97a6f772f36b ("drivers: most: add USB adapter driver")
Cc: Christian Gromm <christian.gromm@microchip.com>
Reported-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/staging/most/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/most/Makefile b/drivers/staging/most/Makefile
index a803a98654a8..7c10b84ebac0 100644
--- a/drivers/staging/most/Makefile
+++ b/drivers/staging/most/Makefile
@@ -6,4 +6,3 @@ obj-$(CONFIG_MOST_SOUND)	+= sound/
 obj-$(CONFIG_MOST_VIDEO)	+= video/
 obj-$(CONFIG_MOST_DIM2)	+= dim2/
 obj-$(CONFIG_MOST_I2C)	+= i2c/
-obj-$(CONFIG_MOST_USB)	+= usb/
-- 
2.28.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02  9:08 staging: most: Build error since commit "drivers: most: add USB adapter driver" Michael Straube
2020-08-02  9:18 ` Greg KH
2020-08-02  9:21   ` [PATCH] staging: most: fix up movement of USB driver Greg Kroah-Hartman

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git