From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=BAYES_20,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD96C433E7 for ; Mon, 12 Oct 2020 11:38:55 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7FAD206FB for ; Mon, 12 Oct 2020 11:38:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eXjiSmyb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7FAD206FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 38A5C20770; Mon, 12 Oct 2020 11:38:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K9vrHNES6m-z; Mon, 12 Oct 2020 11:38:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id D3BFC204D6; Mon, 12 Oct 2020 11:38:49 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id E70B21BF3F7 for ; Mon, 12 Oct 2020 11:38:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E39FA849BE for ; Mon, 12 Oct 2020 11:38:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 95C-3Y7zscq8 for ; Mon, 12 Oct 2020 11:38:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 6466184974 for ; Mon, 12 Oct 2020 11:38:48 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id h2so8405546pll.11 for ; Mon, 12 Oct 2020 04:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uAr1u2AxKhyAhsPGz3HPtu7lWVnt+PlRnjUfOtRYD10=; b=eXjiSmybFzCfsLPApRdx4SqJd6Q3JXAdvU4MJPKZZ4ippGkNFfgFeYTZwyzfKdWC3N YY4Ee59ldzAAxxHe4aH1Td5dqVxdLDSGafdKsH+jgctwaG/tQBZccfYg2Xd7cpGdzQhy fkUUiKGWchxtaeuE8+U1v99g21gesrczOEHEht53nKBwa+fizLetc2lpleHUJ3jYOm1F QMF4HcPQ5uyXuV6Lge8N7UnvTP16iaUuhVuaaUhk4DU80tBdQTswwjokQViDioc3Pi/N 0n448WWUK9jaxfz/5wTa5GytQaRD4Yb4oY0mKvyOFaUUdJ0ABranwTEq/UXc10SqAA6R y3Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uAr1u2AxKhyAhsPGz3HPtu7lWVnt+PlRnjUfOtRYD10=; b=GXp+9j7UEE/1F2oUVkqA1pttbPRcJAX3UBCshLIDdDuuEl3VQYwL4roP75K8n3ygS0 cjooareZSnjc5sP3snGIfFySRAsDPTLgmZUE8LvlWxs+rHV72pzytZwGBD54k7LEXYoA AUlibqNlASh+DBAi/RogXdR7RSK4OAbEqkOmnu3GpPN1Vg05eN0XrMTqWTnx8n81BlXR TA0HDrHiiF8a/n1EmXyGpDC3Yj6iYAtx/6ibv6TOYIPhGy6nP0sCQ0MgCTFlBZpKybcW 6DjbXS+G9UBknmXTIya/0owVuKLpraTPfObWgFGZmfnmOrYhBF9PdMjDFoabeBPUCNzG 65PQ== X-Gm-Message-State: AOAM533Cope97H3tf01eU6JHIsMLjNPz80Ol3+PZXs+qkl4X9ApFahzp MkfMSacq9OUOzghPKIr0v7s= X-Google-Smtp-Source: ABdhPJxHiPbCY6AwdU1NepgLndb4Cc4E+OU455e+aeQtaXWusCq2n76TGY06FvHVFDAGFlriW9lX4w== X-Received: by 2002:a17:902:8698:b029:d3:b362:7342 with SMTP id g24-20020a1709028698b02900d3b3627342mr23245874plo.50.1602502728048; Mon, 12 Oct 2020 04:38:48 -0700 (PDT) Received: from localhost ([160.16.113.140]) by smtp.gmail.com with ESMTPSA id v20sm14861383pjh.5.2020.10.12.04.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 04:38:47 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Mon, 12 Oct 2020 19:29:14 +0800 To: Benjamin Poirier Subject: Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land Message-ID: <20201012112914.xrkwi53gqvg5l6lw@Rk> References: <20201008115808.91850-1-coiby.xu@gmail.com> <20201008115808.91850-6-coiby.xu@gmail.com> <20201010080126.GC14495@f3> <20201010100002.6v54yiojnscnuxqv@Rk> <20201010134055.GA18693@f3> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201010134055.GA18693@f3> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , Manish Chopra , Greg Kroah-Hartman , Shung-Hsi Yu , open list , "open list:QLOGIC QLGE 10Gb ETHERNET DRIVER" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sat, Oct 10, 2020 at 10:40:55PM +0900, Benjamin Poirier wrote: >On 2020-10-10 18:00 +0800, Coiby Xu wrote: >[...] >> > >> > Please also update drivers/staging/qlge/TODO accordingly. There is still >> > a lot of debugging code IMO (the netif_printk statements - kernel >> > tracing can be used instead of those) but this patch is a substantial >> > improvement. >> >> Thank you for the reminding! To move qlge out of staging tree would be >> interesting exercise for me:) > >If you would like to work more on the driver, I would highly suggest >getting one or two adapters to be able to test your changes. They can be >had for relatively cheap on ebay. Just search for "qle8142". Thank you for the info! Right now I don't have a desktop to install this kind of adapter. I'll get one after settling the plan for a desktop. -- Best regards, Coiby _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel