* Clean up query: greybus/audio_manager_module.c
@ 2020-10-22 3:37 Deepak R Varma
2020-10-22 5:29 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Deepak R Varma @ 2020-10-22 3:37 UTC (permalink / raw)
To: outreachy-kernel, vaibhav.sr, mgreer, devel
Hello,
I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
and have found that there are several gb_audio_module_*_show functions
that accept "struct gb_audio_manager_module_attribute * " as a function
parameter. However, this parameter is not used and should not be
necessary. Would you suggest cleaning up such functions.
Thank you.
Deepak.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] Clean up query: greybus/audio_manager_module.c
2020-10-22 3:37 Clean up query: greybus/audio_manager_module.c Deepak R Varma
@ 2020-10-22 5:29 ` Greg KH
2020-10-22 6:46 ` Deepak R Varma
2020-10-22 7:25 ` Deepak R Varma
0 siblings, 2 replies; 4+ messages in thread
From: Greg KH @ 2020-10-22 5:29 UTC (permalink / raw)
To: Deepak R Varma; +Cc: devel, outreachy-kernel, mgreer, vaibhav.sr
On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> Hello,
> I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> and have found that there are several gb_audio_module_*_show functions
> that accept "struct gb_audio_manager_module_attribute * " as a function
> parameter. However, this parameter is not used and should not be
> necessary. Would you suggest cleaning up such functions.
Try removing it and see why it is really needed to be there :)
good luck!
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] Clean up query: greybus/audio_manager_module.c
2020-10-22 5:29 ` [Outreachy kernel] " Greg KH
@ 2020-10-22 6:46 ` Deepak R Varma
2020-10-22 7:25 ` Deepak R Varma
1 sibling, 0 replies; 4+ messages in thread
From: Deepak R Varma @ 2020-10-22 6:46 UTC (permalink / raw)
To: Greg KH; +Cc: devel, outreachy-kernel, mgreer, vaibhav.sr
On Thu, Oct 22, 2020 at 07:29:31AM +0200, Greg KH wrote:
> On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> > Hello,
> > I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> > and have found that there are several gb_audio_module_*_show functions
> > that accept "struct gb_audio_manager_module_attribute * " as a function
> > parameter. However, this parameter is not used and should not be
> > necessary. Would you suggest cleaning up such functions.
>
> Try removing it and see why it is really needed to be there :)
Sounds exciting. I will definitely do that.
>
> good luck!
Thank you.
Deepak.
>
> greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] Clean up query: greybus/audio_manager_module.c
2020-10-22 5:29 ` [Outreachy kernel] " Greg KH
2020-10-22 6:46 ` Deepak R Varma
@ 2020-10-22 7:25 ` Deepak R Varma
1 sibling, 0 replies; 4+ messages in thread
From: Deepak R Varma @ 2020-10-22 7:25 UTC (permalink / raw)
To: Greg KH; +Cc: devel, outreachy-kernel, mgreer, vaibhav.sr
On Thu, Oct 22, 2020 at 07:29:31AM +0200, Greg KH wrote:
> On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> > Hello,
> > I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> > and have found that there are several gb_audio_module_*_show functions
> > that accept "struct gb_audio_manager_module_attribute * " as a function
> > parameter. However, this parameter is not used and should not be
> > necessary. Would you suggest cleaning up such functions.
>
> Try removing it and see why it is really needed to be there :)
Thank you Greg. I tried that and realised that the internal show
function signature definition will mismatch. It will not be a straight
forward change for the clean up sake.
I got my answer. Thanks again.
Deepak.
>
> good luck!
>
> greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-22 7:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-22 3:37 Clean up query: greybus/audio_manager_module.c Deepak R Varma
2020-10-22 5:29 ` [Outreachy kernel] " Greg KH
2020-10-22 6:46 ` Deepak R Varma
2020-10-22 7:25 ` Deepak R Varma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).