From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org Cc: devel@driverdev.osuosl.org, linux-pwm@vger.kernel.org, f.fainelli@gmail.com, devicetree@vger.kernel.org, sboyd@kernel.org, gregkh@linuxfoundation.org, linus.walleij@linaro.org, dmitry.torokhov@gmail.com, linux-gpio@vger.kernel.org, andy.shevchenko@gmail.com, bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net, p.zabel@pengutronix.de, linux-input@vger.kernel.org, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, bgolaszewski@baylibre.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: [PATCH v5 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind Date: Mon, 23 Nov 2020 19:38:27 +0100 Message-ID: <20201123183833.18750-7-nsaenzjulienne@suse.de> (raw) In-Reply-To: <20201123183833.18750-1-nsaenzjulienne@suse.de> Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c index 5d1aacdd84ef..068715d6e66d 100644 --- a/drivers/soc/bcm/raspberrypi-power.c +++ b/drivers/soc/bcm/raspberrypi-power.c @@ -177,7 +177,7 @@ static int rpi_power_probe(struct platform_device *pdev) return -ENODEV; } - rpi_domains->fw = rpi_firmware_get(fw_np); + rpi_domains->fw = devm_rpi_firmware_get(&pdev->dev, fw_np); of_node_put(fw_np); if (!rpi_domains->fw) return -EPROBE_DEFER; -- 2.29.2 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply index Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-23 18:38 [PATCH v5 00/11] Raspberry Pi PoE HAT fan support Nicolas Saenz Julienne 2020-11-23 18:38 ` [PATCH v5 01/11] firmware: raspberrypi: Keep count of all consumers Nicolas Saenz Julienne 2020-12-02 17:26 ` Florian Fainelli 2020-12-03 8:05 ` Bartosz Golaszewski 2020-12-03 8:53 ` Nicolas Saenz Julienne 2020-11-23 18:38 ` [PATCH v5 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() Nicolas Saenz Julienne 2020-12-02 17:27 ` Florian Fainelli 2020-11-23 18:38 ` [PATCH v5 03/11] clk: bcm: rpi: Release firmware handle on unbind Nicolas Saenz Julienne 2020-12-02 17:28 ` Florian Fainelli 2020-11-23 18:38 ` [PATCH v5 04/11] gpio: raspberrypi-exp: " Nicolas Saenz Julienne 2020-12-02 17:29 ` Florian Fainelli 2020-11-23 18:38 ` [PATCH v5 05/11] reset: raspberrypi: " Nicolas Saenz Julienne 2020-12-02 17:29 ` Florian Fainelli 2020-11-23 18:38 ` Nicolas Saenz Julienne [this message] 2020-12-02 17:55 ` [PATCH v5 06/11] soc: bcm: raspberrypi-power: " Florian Fainelli 2020-11-23 18:38 ` [PATCH v5 07/11] staging: vchiq: " Nicolas Saenz Julienne 2020-12-02 17:56 ` Florian Fainelli 2020-11-23 18:38 ` [PATCH v5 08/11] input: raspberrypi-ts: Release firmware handle when not needed Nicolas Saenz Julienne 2020-12-02 6:03 ` Dmitry Torokhov 2020-12-03 14:52 ` Nicolas Saenz Julienne 2020-11-23 18:38 ` [PATCH v5 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus Nicolas Saenz Julienne 2020-11-23 18:38 ` [PATCH v5 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support Nicolas Saenz Julienne 2020-11-23 18:38 ` [PATCH v5 11/11] pwm: Add Raspberry Pi Firmware based PWM bus Nicolas Saenz Julienne 2020-12-09 10:42 ` Nicolas Saenz Julienne
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201123183833.18750-7-nsaenzjulienne@suse.de \ --to=nsaenzjulienne@suse.de \ --cc=andy.shevchenko@gmail.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=bgolaszewski@baylibre.com \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=f.fainelli@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=p.zabel@pengutronix.de \ --cc=sboyd@kernel.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wahrenst@gmx.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DriverDev-Devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \ driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org public-inbox-index driverdev-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git