From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6246CC433E0 for ; Mon, 22 Mar 2021 18:22:57 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFC1961983 for ; Mon, 22 Mar 2021 18:22:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFC1961983 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 652FC832EB; Mon, 22 Mar 2021 18:22:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hTRjYjl80x83; Mon, 22 Mar 2021 18:22:55 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 4A955832FF; Mon, 22 Mar 2021 18:22:55 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 41D421BF300 for ; Mon, 22 Mar 2021 18:22:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3D693832FF for ; Mon, 22 Mar 2021 18:22:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id he1pDfx-RLfQ for ; Mon, 22 Mar 2021 18:22:52 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by smtp1.osuosl.org (Postfix) with ESMTPS id 68972832EB for ; Mon, 22 Mar 2021 18:22:52 +0000 (UTC) Received: by mail-ed1-x530.google.com with SMTP id h13so20542858eds.5 for ; Mon, 22 Mar 2021 11:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=asL2ZZdtkm66EuwKx1Rl/XrY+7M28qzFVlOOJDLrX1Q=; b=jKJvrSeRF6WQqvVAhseT8JuAeNVVKu5BVHgSK5zf55N/aCZZMavPrcVmTO6k2s4y6R M28a6saDUEFEzuei1dG/wxw71JTuTWaTklTZp8dxzQAS8EsLE2tbS6mBsOJe5MG8kEsG ptlcs01Z1gxqievx+csQxXG4RhSATpkzo0hTAK6wc3MZ/J4AfBzWc7t/GxbZjA6cMBbC Lu0za++wqkBLJf914TLR/vCydahGRWYz0lCPzorsE3JBOtFv1KKmtEiJ8JV4gXAfxecf gGkGuzipWzdTnARJWMxhniq2ER3gQEossUtqCZbfd3HZnb3OTXA6Q665eT7ndcbanrlX 6WDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=asL2ZZdtkm66EuwKx1Rl/XrY+7M28qzFVlOOJDLrX1Q=; b=Xs082cBNa/f9/yX3YIQ143puCU6i7pYegXot5kzuQa/vKcCxiN0QYGPafNoSbUEcfG wLVRMEzlplVVzJ/eUfFepXz1ncyduJPTE7MP0+DvEuTq/WYIfmk1qR59WtE/IooYFQls KEBiGqhu1LGNftusSSpOVAC/OA2wh0U3c6lo7f0IZUKVXcq9QJfpL+0uf2/6d3V7sxNG 2XStOcNte1X/zA9ueQNi6tqEW6c5mgImeJ5UV3g3Cad68kJrJjbzApXXCT9LHc98GWPo M7sZmW0w5Vn0WNFRovBCyJ/gMSI+QjfYrKQEQ7UOh/GyJTFoOs0RWY84yU4cipBXVF// KGeA== X-Gm-Message-State: AOAM532pmiIAzYvKwpCIB9hExnHEvZYxQqA4vV14gf+2RshZEZRAl7Xw lUPV7/tTHaFYLNQ346XzHTM= X-Google-Smtp-Source: ABdhPJzdlnMnhcI11rqCVdKyiJ4uKdceNJbkp7h+h/nHy3QamkCbfqong+uG+lmxdK0+gA5sf51O4Q== X-Received: by 2002:aa7:d4cb:: with SMTP id t11mr946836edr.202.1616437370465; Mon, 22 Mar 2021 11:22:50 -0700 (PDT) Received: from agape.jhs ([151.37.41.34]) by smtp.gmail.com with ESMTPSA id e26sm12663906edj.29.2021.03.22.11.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 11:22:50 -0700 (PDT) Date: Mon, 22 Mar 2021 19:22:46 +0100 From: Fabio Aiuto To: Greg KH Subject: Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c Message-ID: <20210322182245.GB1443@agape.jhs> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: joe@perches.com, apw@canonical.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, Mar 22, 2021 at 05:07:53PM +0100, Greg KH wrote: > On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch issues: > > > > WARNING: externs should be avoided in .c files > > 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: > > +bool > > > > moved two function prototypes in include/rtw_efuse.h > > > > Signed-off-by: Fabio Aiuto > > --- > > drivers/staging/rtl8723bs/core/rtw_efuse.c | 10 ---------- > > drivers/staging/rtl8723bs/include/rtw_efuse.h | 3 +++ > > 2 files changed, 3 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c > > index 32ca10f01413..0772397738d4 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c > > @@ -32,11 +32,6 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0}; > > #define REG_EFUSE_CTRL 0x0030 > > #define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse Control. */ > > > > -bool > > -Efuse_Read1ByteFromFakeContent( > > - struct adapter *padapter, > > - u16 Offset, > > - u8 *Value); > > bool > > Efuse_Read1ByteFromFakeContent( > > struct adapter *padapter, > > @@ -53,11 +48,6 @@ Efuse_Read1ByteFromFakeContent( > > return true; > > } > > > > -bool > > -Efuse_Write1ByteToFakeContent( > > - struct adapter *padapter, > > - u16 Offset, > > - u8 Value); > > bool > > Efuse_Write1ByteToFakeContent( > > struct adapter *padapter, > > diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h > > index 5bae46ecd9de..1f304df8c421 100644 > > --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h > > +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h > > @@ -103,6 +103,9 @@ extern u8 fakeBTEfuseInitMap[]; > > extern u8 fakeBTEfuseModifiedMap[]; > > /*------------------------Export global variable----------------------------*/ > > > > +bool Efuse_Read1ByteFromFakeContent(struct adapter *padapter, u16 Offset, u8 *Value); > > +bool Efuse_Write1ByteToFakeContent(struct adapter *padapter, u16 Offset, u8 Value); > > No, there's no need for this to be in a .h file, it is only called from > one .c file. > > Make the thing static and all should be fine, right? > > thanks, > > greg k-h ok, better static function when possibile. Thank you Greg, fabio _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel