From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8442C47404 for ; Fri, 11 Oct 2019 23:11:56 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 951282190F for ; Fri, 11 Oct 2019 23:11:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 951282190F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 6BA312046F; Fri, 11 Oct 2019 23:11:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zZpV98NKFTBZ; Fri, 11 Oct 2019 23:11:55 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 163CE204D1; Fri, 11 Oct 2019 23:11:55 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 527001BF2FA for ; Fri, 11 Oct 2019 23:11:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4EAF887D9E for ; Fri, 11 Oct 2019 23:11:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fSAut6sRAi3p for ; Fri, 11 Oct 2019 23:11:51 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from smtprelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by hemlock.osuosl.org (Postfix) with ESMTPS id 150F387C2C for ; Fri, 11 Oct 2019 23:11:50 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave05.hostedemail.com (Postfix) with ESMTP id 3783D18021445 for ; Fri, 11 Oct 2019 22:32:29 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id E131418016C6C; Fri, 11 Oct 2019 22:32:25 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: owl40_14d93818d4721 X-Filterd-Recvd-Size: 2752 Received: from XPS-9350.home (unknown [47.151.152.152]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Fri, 11 Oct 2019 22:32:23 +0000 (UTC) Message-ID: <28ed468bc58c0d0e92f459b45d8e43cd3d1458b2.camel@perches.com> Subject: Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warnings of lines should not end with open parenthesis From: Joe Perches To: Julia Lawall , Jules Irenge Date: Fri, 11 Oct 2019 15:32:22 -0700 In-Reply-To: References: <20191011211637.19311-1-jbi.octave@gmail.com> User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, f.fainelli@gmail.com, sbranden@broadcom.com, mchehab+samsung@kernel.org, outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, eric@anholt.net, daniela.mormocea@gmail.com, bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net, dave.stevenson@raspberrypi.org, rjui@broadcom.com, hverkuil-cisco@xs4all.nl, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, 2019-10-11 at 23:23 +0200, Julia Lawall wrote: > On Fri, 11 Oct 2019, Jules Irenge wrote: > > Fix warning of lines should not end with open parenthesis. > > Issue detected by checkpatch tool. [] > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c [] > > @@ -337,9 +337,8 @@ static void buffer_cb(struct vchiq_mmal_instance *instance, > > if (is_capturing(dev)) { > > v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, > > "Grab another frame"); > > - vchiq_mmal_port_parameter_set( > > - instance, > > - dev->capture.camera_port, > > + vchiq_mmal_port_parameter_set(instance, > > + dev->capture.camera_port, > > MMAL_PARAMETER_CAPTURE, > > &dev->capture.frame_count, > > sizeof(dev->capture.frame_count)); > > You can't reduce the indentation on the function call. It has to stay > clearly in the if branch. > > If you adjust the indentation of some of the arguments, you have to do so > to all of the arguments. > > Similar issues arise below. There may be no way to make some of the calls > look nice without a more severe reorganization of the code. My suggestion would be to shorten the vchiq_mmal_port_parameter_set function name (29 chars is just too long) and pass dev instead of dev->instance as the first argument to this function. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel