driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Deepak R Varma <mh12gx2825@gmail.com>,
	Julia Lawall <julia.lawall@inria.fr>
Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [Outreachy kernel] Re: [PATCH 2/2] staging: comedi: combine split lines for improved readability
Date: Mon, 19 Oct 2020 12:34:15 +0100	[thread overview]
Message-ID: <3bcf050c-97e4-666a-20fd-44585a913a8d@mev.co.uk> (raw)
In-Reply-To: <20201019105731.GB9681@ubuntu204>

On 19/10/2020 11:57, Deepak R Varma wrote:
> On Mon, Oct 19, 2020 at 12:41:14PM +0200, Julia Lawall wrote:
>>
>>
>> On Mon, 19 Oct 2020, Ian Abbott wrote:
>>
>>> On 18/10/2020 20:49, Deepak R Varma wrote:
>>>> Instructions split on multiple lines can be combined on a single line
>>>> for improved readability of the code.
>>>>
>>>> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
>>>> ---
>>>>    .../staging/comedi/drivers/tests/ni_routes_test.c    | 12 ++++--------
>>>>    1 file changed, 4 insertions(+), 8 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/comedi/drivers/tests/ni_routes_test.c
>>>> b/drivers/staging/comedi/drivers/tests/ni_routes_test.c
>>>> index 7db83cf5e4aa..a3b1be623861 100644
>>>> --- a/drivers/staging/comedi/drivers/tests/ni_routes_test.c
>>>> +++ b/drivers/staging/comedi/drivers/tests/ni_routes_test.c
>>>> @@ -499,14 +499,10 @@ void test_route_register_is_valid(void)
>>>>    	const struct ni_route_tables *T = &private.routing_tables;
>>>>      	init_pci_fake();
>>>> -	unittest(!route_register_is_valid(4, O(4), T),
>>>> -		 "check for bad source 4-->4\n");
>>>> -	unittest(!route_register_is_valid(0, O(1), T),
>>>> -		 "find first source\n");
>>>> -	unittest(!route_register_is_valid(4, O(6), T),
>>>> -		 "find middle source\n");
>>>> -	unittest(!route_register_is_valid(9, O(8), T),
>>>> -		 "find last source");
>>>> +	unittest(!route_register_is_valid(4, O(4), T), "check for bad source
>>>> 4-->4\n");
>>>> +	unittest(!route_register_is_valid(0, O(1), T), "find first source\n");
>>>> +	unittest(!route_register_is_valid(4, O(6), T), "find middle
>>>> source\n");
>>>> +	unittest(!route_register_is_valid(9, O(8), T), "find last source");
>>>>    }
>>>>      void test_ni_check_trigger_arg(void)
>>>>
>>>
>>> Is it worth breaking the 80-column limit for this?
>>
>> Deepak,
>>
>> It was much nicer before.
>>
>> It can be awkward to break eg a + operation at the 80 character limit.
>> But function argument stand by themselves.
>>
>> julia
>>
> 
> Hi Julia and Ian,
> I wanted to take advantage of the relaxation of 80 column limit to 100
> columns and hence proposed combining the lines. Are you saying this is
> allowed only in certain cases?
> 
> Please confirm and I will handle it accordingly.

Hi Deepak,

80 columns is still the preferred limit.  I think the relaxation is 
mostly to avoid the need to split sub-expressions across lines in really 
ugly ways to keep within the 80 columns at the expense of readability.

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2020-10-19 11:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-18 19:48 [PATCH 1/2] staging: comedi: Simplify conditional evaluation Deepak R Varma
2020-10-18 19:49 ` [PATCH 2/2] staging: comedi: combine split lines for improved readability Deepak R Varma
2020-10-19 10:22   ` Ian Abbott
2020-10-19 10:41     ` [Outreachy kernel] " Julia Lawall
2020-10-19 10:57       ` Deepak R Varma
2020-10-19 11:34         ` Ian Abbott [this message]
2020-10-19 11:49           ` Deepak R Varma
2020-10-19 12:46             ` Ian Abbott
2020-10-19 10:17 ` [PATCH 1/2] staging: comedi: Simplify conditional evaluation Ian Abbott
2020-10-19 10:51   ` Deepak R Varma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bcf050c-97e4-666a-20fd-44585a913a8d@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@inria.fr \
    --cc=mh12gx2825@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).