From: Andrzej Hajda <a.hajda@samsung.com>
To: Xin Ji <xji@analogixsemi.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Nicolas Boichat <drinkcat@chromium.org>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Sheng Pan <span@analogixsemi.com>,
Daniel Vetter <daniel@ffwll.ch>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding
Date: Fri, 11 Oct 2019 13:21:43 +0200 [thread overview]
Message-ID: <3c6067de-9f3c-b93c-f263-fa5dd09c3270@samsung.com> (raw)
In-Reply-To: <75bb8a47d2c3c1f979c6d62158c21988b846e79b.1570760115.git.xji@analogixsemi.com>
On 11.10.2019 04:21, Xin Ji wrote:
> The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed
> for portable device. It converts MIPI to DisplayPort 1.3 4K.
>
> You can add support to your board with binding.
>
> Example:
> anx7625_bridge: encoder@58 {
> compatible = "analogix,anx7625";
> reg = <0x58>;
> status = "okay";
> panel-flags = <1>;
> enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> #address-cells = <1>;
> #size-cells = <0>;
>
> port@0 {
> reg = <0>;
> anx_1_in: endpoint {
> remote-endpoint = <&mipi_dsi>;
> };
> };
>
> port@3 {
> reg = <3>;
> anx_1_out: endpoint {
> remote-endpoint = <&panel_in>;
> };
> };
> };
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> .../bindings/display/bridge/anx7625.yaml | 96 ++++++++++++++++++++++
> 1 file changed, 96 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/anx7625.yaml
> new file mode 100644
> index 0000000..fc84683
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/anx7625.yaml
> @@ -0,0 +1,96 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2019 Analogix Semiconductor, Inc.
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter)
> +
> +maintainers:
> + - Xin Ji <xji@analogixsemi.com>
> +
> +description: |
> + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
> + designed for portable devices.
> +
> +properties:
> + "#address-cells": true
> + "#size-cells": true
> +
> + compatible:
> + items:
> + - const: analogix,anx7625
> +
> + reg:
> + maxItems: 1
> +
> + panel-flags:
> + description: indicate the panel is internal or external
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + enable-gpios:
> + description: used for power on chip control, POWER_EN pin D2.
> + maxItems: 1
> +
> + reset-gpios:
> + description: used for reset chip control, RESET_N pin B7.
> + maxItems: 1
> +
> + port@0:
> + type: object
> + description:
> + A port node pointing to MIPI DSI host port node.
> +
> + port@1:
> + type: object
> + description:
> + A port node pointing to MIPI DPI host port node.
> +
> + port@2:
> + type: object
> + description:
> + A port node pointing to external connector port node.
> +
> + port@3:
> + type: object
> + description:
> + A port node pointing to eDP port node.
Decrypting available product brief[1], there are following physical lines:
Input:
- MIPI DSI/DPI - video data, are DSI and DPI lines shared?
- I2S - audio data,
- I2C - control line,
- ALERT/INTP - interrupt,
- USB 3.1 SSRc/Tx - for USB forwarding,
Output:
- SS1, SS2,
- SBU/AUX,
- CC1/2.
Having this information I try to understand ports defined by you:
- port@2 you have defined as pointing to external port, but here the
port should be rather subnode of ANX7625 - the chip has CC lines, see
beginning of [2].
- port@3 describes SS1, SS2 and SBU/AUX lines together, am I right? In
USB-C binding SBU and SS lines are represented by different ports,
different approach, but maybe better in this case.
Maybe it would be good to add 2nd example with USB-C port.
[1]:
https://www.analogix.com/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf
[2]: Documentation/devicetree/bindings/connector/usb-connector.txt
Regards
Andrzej
> +
> +required:
> + - "#address-cells"
> + - "#size-cells"
> + - compatible
> + - reg
> + - port@0
> + - port@3
> +
> +example:
> + - |
> + anx7625_bridge: encoder@58 {
> + compatible = "analogix,anx7625";
> + reg = <0x58>;
> + status = "okay";
> + panel-flags = <1>;
> + enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + anx_1_in: endpoint {
> + remote-endpoint = <&mipi_dsi>;
> + };
> + };
> +
> + port@3 {
> + reg = <3>;
> + anx_1_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> + };
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-10-11 11:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191011022055epcas5p37790ed31cbe63d0be0f6b5786ce1392a@epcas5p3.samsung.com>
2019-10-11 2:20 ` [PATCH v2 0/2] Add initial support for slimport anx7625 Xin Ji
2019-10-11 2:21 ` [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding Xin Ji
2019-10-11 11:21 ` Andrzej Hajda [this message]
2019-10-11 12:54 ` Laurent Pinchart
2019-10-14 3:02 ` Xin Ji
2019-10-14 22:16 ` Laurent Pinchart
2019-10-15 3:02 ` Xin Ji
2019-10-14 2:53 ` Xin Ji
2019-10-11 2:23 ` [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver Xin Ji
2019-10-14 8:20 ` kbuild test robot
2019-10-14 8:20 ` [RFC PATCH] drm/bridge: anx7625: ANX_OUI[] can be static kbuild test robot
2019-10-15 9:19 ` [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver Dan Carpenter
2019-10-11 6:12 ` [PATCH v2 0/2] Add initial support for slimport anx7625 Andrzej Hajda
2019-10-11 7:52 ` Xin Ji
2019-10-11 10:27 ` Dan Carpenter
2019-10-10 9:31 Xin Ji
2019-10-10 9:32 ` [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding Xin Ji
-- strict thread matches above, loose matches on Subject: below --
2019-10-09 9:26 [PATCH v2 0/2] Add initial support for slimport anx7625 Xin Ji
2019-10-09 9:27 ` [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding Xin Ji
2019-10-09 12:10 ` Laurent Pinchart
2019-10-10 3:38 ` Xin Ji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c6067de-9f3c-b93c-f263-fa5dd09c3270@samsung.com \
--to=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=span@analogixsemi.com \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).