From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27EE1C432C3 for ; Sat, 16 Nov 2019 06:45:59 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EADEA206B6 for ; Sat, 16 Nov 2019 06:45:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EADEA206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B3F9A87482; Sat, 16 Nov 2019 06:45:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EzUf0UKI8cym; Sat, 16 Nov 2019 06:45:58 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 06ECD87698; Sat, 16 Nov 2019 06:45:58 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 3EA6F1BF852 for ; Sat, 16 Nov 2019 06:45:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 35BF187E27 for ; Sat, 16 Nov 2019 06:45:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rlCJ+vDxiDAA for ; Sat, 16 Nov 2019 06:45:55 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from smtprelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by hemlock.osuosl.org (Postfix) with ESMTPS id 40C3C87E09 for ; Sat, 16 Nov 2019 06:45:55 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave04.hostedemail.com (Postfix) with ESMTP id 9BE6C18022F4F for ; Sat, 16 Nov 2019 06:45:52 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 9DED6181D3417; Sat, 16 Nov 2019 06:45:49 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wall56_6cf4312ecd835 X-Filterd-Recvd-Size: 2631 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA; Sat, 16 Nov 2019 06:45:48 +0000 (UTC) Message-ID: <3fd995ebb9ec87b202942fa1f000755c2d3cc4cb.camel@perches.com> Subject: Re: [PATCH] staging: rtl8192u: fix indentation issue From: Joe Perches To: Colin King , Greg Kroah-Hartman , devel@driverdev.osuosl.org Date: Fri, 15 Nov 2019 22:45:29 -0800 In-Reply-To: <20191114095430.132120-1-colin.king@canonical.com> References: <20191114095430.132120-1-colin.king@canonical.com> User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, 2019-11-14 at 09:54 +0000, Colin King wrote: > From: Colin Ian King > > There is a block of statements that are indented > too deeply, remove the extraneous tabs. [] > diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c [] > @@ -169,19 +169,20 @@ static void cmdpkt_beacontimerinterrupt_819xusb(struct net_device *dev) > { > struct r8192_priv *priv = ieee80211_priv(dev); > u16 tx_rate; > - /* 87B have to S/W beacon for DTM encryption_cmn. */ > - if (priv->ieee80211->current_network.mode == IEEE_A || > - priv->ieee80211->current_network.mode == IEEE_N_5G || > - (priv->ieee80211->current_network.mode == IEEE_N_24G && > - (!priv->ieee80211->pHTInfo->bCurSuppCCK))) { > - tx_rate = 60; > - DMESG("send beacon frame tx rate is 6Mbpm\n"); > - } else { > - tx_rate = 10; > - DMESG("send beacon frame tx rate is 1Mbpm\n"); > - } > > - rtl819xusb_beacon_tx(dev, tx_rate); /* HW Beacon */ > + /* 87B have to S/W beacon for DTM encryption_cmn. */ > + if (priv->ieee80211->current_network.mode == IEEE_A || > + priv->ieee80211->current_network.mode == IEEE_N_5G || > + (priv->ieee80211->current_network.mode == IEEE_N_24G && > + (!priv->ieee80211->pHTInfo->bCurSuppCCK))) { > + tx_rate = 60; > + DMESG("send beacon frame tx rate is 6Mbpm\n"); > + } else { > + tx_rate = 10; > + DMESG("send beacon frame tx rate is 1Mbpm\n"); > + } > + > + rtl819xusb_beacon_tx(dev, tx_rate); /* HW Beacon */ This function might as well be deleted instead as rtl819xusb_beacon_tx is a noop function in drivers/staging/rtl8192u/r8192U_core.c void rtl819xusb_beacon_tx(struct net_device *dev, u16 tx_rate) { } _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel