From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A457C432C3 for ; Thu, 14 Nov 2019 10:33:40 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50A7620675 for ; Thu, 14 Nov 2019 10:33:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bfs.de header.i=@bfs.de header.b="H6bk6suL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50A7620675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bfs.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DBA6589720; Thu, 14 Nov 2019 10:33:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vJ-QZG4vwMxE; Thu, 14 Nov 2019 10:33:38 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 5C40389718; Thu, 14 Nov 2019 10:33:38 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id D66DC1BF3A3 for ; Thu, 14 Nov 2019 10:33:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id CF3AA89EEF for ; Thu, 14 Nov 2019 10:33:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DckzhO+9B4TH for ; Thu, 14 Nov 2019 10:33:34 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mx01-fr.bfs.de (mx01-fr.bfs.de [193.174.231.67]) by hemlock.osuosl.org (Postfix) with ESMTPS id 0208689EE1 for ; Thu, 14 Nov 2019 10:33:33 +0000 (UTC) Received: from mail-fr.bfs.de (mail-fr.bfs.de [10.177.18.200]) by mx01-fr.bfs.de (Postfix) with ESMTPS id 6AF3920346; Thu, 14 Nov 2019 11:33:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bfs.de; s=dkim201901; t=1573727601; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cKhNKGzpQjIXpZ4KphvaUafb/xdZMCyUdnUQ1YJ5Vic=; b=H6bk6suLnD4e9AdKorHz8a6XT0fRGyL1Y3ljTQKsJXuK/tiaTNrLxQkDWn6S8KmFHGy24a x3MvTHlAWkcZXl7+UQTbSsmE52w9BLHviTfp0rATgm620k90hPmXq5+pEyR/r7fmgrSDLY u8+nxRtEJCsriRIBoDBLSyG03lcLNjS8DlFjjR0+2wRYi3nIK0XYnGPCQNcXvnHxoS//mI 0fMsUO1axJyl1hPp+hmdjyFzKaXAGZ0JJRAgJZmMLAxQB4DYJD4jVCHG2W97dlhpGdonc/ DWlhGQpXM/YGhawoKNyTqn5BCjCOFHfatns+BiD3mH1p5PDNbsL9DgNJMNtZ2A== Received: from [134.92.181.33] (unknown [134.92.181.33]) by mail-fr.bfs.de (Postfix) with ESMTPS id F3BD6BEEBD; Thu, 14 Nov 2019 11:33:10 +0100 (CET) Message-ID: <5DCD2D66.2050206@bfs.de> Date: Thu, 14 Nov 2019 11:33:10 +0100 From: walter harms User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192u: fix indentation issue References: <20191114095430.132120-1-colin.king@canonical.com> In-Reply-To: <20191114095430.132120-1-colin.king@canonical.com> Authentication-Results: mx01-fr.bfs.de X-Spamd-Result: default: False [-3.10 / 7.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[wharms@bfs.de]; BAYES_HAM(-3.00)[100.00%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; DKIM_SIGNED(0.00)[]; NEURAL_HAM(-0.00)[-0.999,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wharms@bfs.de Cc: devel@driverdev.osuosl.org, Colin King , kernel-janitors@vger.kernel.org, Greg Kroah-Hartman Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Am 14.11.2019 10:54, schrieb Colin King: > From: Colin Ian King > > There is a block of statements that are indented > too deeply, remove the extraneous tabs. > > Signed-off-by: Colin Ian King > --- > drivers/staging/rtl8192u/r819xU_cmdpkt.c | 25 ++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c > index e064f43fd8b6..bc98cdaf61ec 100644 > --- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c > +++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c > @@ -169,19 +169,20 @@ static void cmdpkt_beacontimerinterrupt_819xusb(struct net_device *dev) > { > struct r8192_priv *priv = ieee80211_priv(dev); > u16 tx_rate; > - /* 87B have to S/W beacon for DTM encryption_cmn. */ > - if (priv->ieee80211->current_network.mode == IEEE_A || > - priv->ieee80211->current_network.mode == IEEE_N_5G || > - (priv->ieee80211->current_network.mode == IEEE_N_24G && > - (!priv->ieee80211->pHTInfo->bCurSuppCCK))) { > - tx_rate = 60; > - DMESG("send beacon frame tx rate is 6Mbpm\n"); > - } else { > - tx_rate = 10; > - DMESG("send beacon frame tx rate is 1Mbpm\n"); > - } > > - rtl819xusb_beacon_tx(dev, tx_rate); /* HW Beacon */ > + /* 87B have to S/W beacon for DTM encryption_cmn. */ > + if (priv->ieee80211->current_network.mode == IEEE_A || > + priv->ieee80211->current_network.mode == IEEE_N_5G || > + (priv->ieee80211->current_network.mode == IEEE_N_24G && > + (!priv->ieee80211->pHTInfo->bCurSuppCCK))) { > + tx_rate = 60; > + DMESG("send beacon frame tx rate is 6Mbpm\n"); > + } else { > + tx_rate = 10; > + DMESG("send beacon frame tx rate is 1Mbpm\n"); > + } > + > + rtl819xusb_beacon_tx(dev, tx_rate); /* HW Beacon */ > } > > /*----------------------------------------------------------------------------- this is hard to read in the first place. Maybe using switch() here is better to read (untested example below). switch(priv->ieee80211->current_network.mode) { case IEEE_A: case IEEE_N_5G: tx_rate = 60; break; IEEE_N_24G: if ( !priv->ieee80211->pHTInfo->bCurSuppCCK ) tx_rate = 60; // fall truh default: tx_rate = 10; } if (txrate == 60 ) DMESG("send beacon frame tx rate is 6Mbpm\n"); else if (txrate == 10 ) DMESG("send beacon frame tx rate is 1Mbpm\n"); JM2C re, wh _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel