DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
To: Marc Dietrich <marvin24@posteo.de>
Cc: linux-tegra@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, p.zabel@pengutronix.de
Subject: Re: [PATCH v3] staging: nvec: change usage of slave to secondary
Date: Sat, 25 Jul 2020 12:20:41 +0530
Message-ID: <6db6189a-3bc9-72c4-7c7c-98ab5e03a0c0@gmail.com> (raw)
In-Reply-To: <alpine.OSX.2.23.453.2007242238230.12486@macbook-pro.fritz.box>

On 25/07/20 2:12 am, Marc Dietrich wrote:
> 
> Hi Rohit,
> 
> On Fri, 24 Jul 2020, Rohit K Bharadwaj wrote:
> 
>> On 24/07/20 10:06 pm, Marc Dietrich wrote:
>>>
>>>
>>> On Fri, 24 Jul 2020, Marc Dietrich wrote:
>>>
>>>> Hi Rohit,
>>>>
>>>> On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:
>>>>
>>>>> On 24/07/20 1:58 pm, Greg KH wrote:
>>>>>> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
>>>>>>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
>>>>>>>> changed usage of slave (deprecated) to secondary
>>>>>>>>
>>>>>>>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
>>>>>>>> ---
>>>>>>>> v3: change patch subject, add version history
>>>>>>>> v2: add changelog text in body of mail
>>>>>>>> v1: fix style issues by changing usage of slave to secondary
>>>>>>>>
>>>>>>>>  drivers/staging/nvec/nvec.c | 12 ++++++------
>>>>>>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>>>>>>>> index 360ec0407740..5d7b66719a39 100644
>>>>>>>> --- a/drivers/staging/nvec/nvec.c
>>>>>>>> +++ b/drivers/staging/nvec/nvec.c
>>>>>>>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>>>>>>>>      return IRQ_HANDLED;
>>>>>>>>  }
>>>>>>>>
>>>>>>>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>>>>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>>>>>>>>  {
>>>>>>>>      u32 val;
>>>>>>>>
>>>>>>>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>>>>>  }
>>>>>>>>
>>>>>>>>  #ifdef CONFIG_PM_SLEEP
>>>>>>>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
>>>>>>>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>>>>>>>>  {
>>>>>>>>      disable_irq(nvec->irq);
>>>>>>>>      writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
>>>>>>>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>>>>>>>      platform_set_drvdata(pdev, nvec);
>>>>>>>>      nvec->dev = dev;
>>>>>>>>
>>>>>>>> -    if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
>>>>>>>> +    if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
>>>>>>>>          dev_err(dev, "no i2c address specified");
>>>>>>>>          return -ENODEV;
>>>>>>>>      }
>>>>
>>>> as Christoph said, please don't change this line.
>>>
>>> arr, I meant Dan of course ;-)
>> Dear all, thank you so much for your inputs, I will try to make some other patch which will not break the driver (hopefully :p), or if you give me permission to submit this patch itself by just keeping this one line
>>
>>> if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr))
>>
>> unchanged, and provided it does not break the driver by doing so, I would gladly make the changes and submit v4 of the patch.
> 
> please resend the patch with the line above unchanged as v4. Don't forget to to update the changelog to the commit message. I tested your patch (without the dt property change) and it does not change behavoir - as expected,
> so you will recevice my Ack.
> 
> Marc

Thank you so much for the suggestions and the Ack sir, I have made the necessary changes and I have sent the v4 of the patch.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply index

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 15:15 [PATCH] change slave occurence to secondary everywhere Rohit K Bharadwaj
2020-07-23 17:06 ` Greg KH
2020-07-24  4:55   ` Rohit Bharadwaj
2020-07-24  4:36 ` [PATCH v3] staging: nvec: change usage of slave to secondary Rohit K Bharadwaj
2020-07-24  8:14   ` Rohit Bharadwaj
2020-07-24  8:28     ` Greg KH
2020-07-24  8:35       ` Rohit Bharadwaj
2020-07-24 16:33         ` Marc Dietrich
2020-07-24 16:36           ` Marc Dietrich
2020-07-24 16:57             ` Rohit K Bharadwaj
2020-07-24 20:42               ` Marc Dietrich
2020-07-25  6:50                 ` Rohit K Bharadwaj [this message]
2020-07-24 14:09   ` Dan Carpenter
2020-07-24 15:51     ` Rohit K Bharadwaj
2020-07-24 16:23       ` Greg KH
2020-07-25  6:29   ` [PATCH v4] " Rohit K Bharadwaj
2020-07-25 12:01     ` Michał Mirosław
2020-07-25 12:31       ` Rohit K Bharadwaj
2020-07-25 12:50         ` Michał Mirosław
2020-07-25 13:02           ` Rohit K Bharadwaj
2020-08-02  8:07           ` Marc Dietrich
2020-08-02  8:13     ` Marc Dietrich
2020-08-02  9:09       ` Rohit K Bharadwaj
2020-07-24 14:07 ` [PATCH] change slave occurence to secondary everywhere Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6db6189a-3bc9-72c4-7c7c-98ab5e03a0c0@gmail.com \
    --to=bharadwaj.rohit8@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=marvin24@posteo.de \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git