From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B86A5ECE58D for ; Thu, 17 Oct 2019 17:06:41 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F27A2089C for ; Thu, 17 Oct 2019 17:06:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="JNx3WGJq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F27A2089C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2F55B87368; Thu, 17 Oct 2019 17:06:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UQrIVc3tiMpV; Thu, 17 Oct 2019 17:06:40 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id ED35E86E2C; Thu, 17 Oct 2019 17:06:39 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id E7FA91BF338 for ; Thu, 17 Oct 2019 17:06:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E4AED86C4B for ; Thu, 17 Oct 2019 17:06:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VWH2c-rcu-mZ for ; Thu, 17 Oct 2019 17:06:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from esa2.microchip.iphmx.com (esa2.microchip.iphmx.com [68.232.149.84]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 7D36F85F9C for ; Thu, 17 Oct 2019 17:06:37 +0000 (UTC) Received-SPF: Pass (esa2.microchip.iphmx.com: domain of Adham.Abozaeid@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa2.microchip.iphmx.com; envelope-from="Adham.Abozaeid@microchip.com"; x-sender="Adham.Abozaeid@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa2.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa2.microchip.iphmx.com; envelope-from="Adham.Abozaeid@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa2.microchip.iphmx.com; spf=Pass smtp.mailfrom=Adham.Abozaeid@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: bWT1oZVSuJDreiuEYvMXWANIHPkPQYdFhwZRGPJg/3NwSF1h1EcrTa9Exl2KurzHy8Hk2TGjbT 8ZsYGO3YMEhjnwuhE1Ckq6ygDF4tEZfELnQkDJGXuQR4vdxs1JQWV11fxdh9kUW54K54G7cj0E UljDOtsFmImLZXZY4QTaegVs3wkz7p0HtM9pBoGWZEvx+ezBDgxzO3J/n3CkhDq5vws6Mxz8db cMmkjAUeAeEL2Dvue8/n+DMnVuUhkG3DPxLIZjn4IlZsAq9tUT2+k7ycX/iwxSG/VgCPybN8r0 tPo= X-IronPort-AV: E=Sophos;i="5.67,308,1566889200"; d="scan'208";a="53112050" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Oct 2019 10:06:36 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Oct 2019 10:06:36 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 17 Oct 2019 10:06:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H8r3NHRGSeE7QeWdmuar33q+mm31SfOHEGTGqPBRErYpCB0D75N4qq4m0FbrRNEgUu3Sg12Nc+TFMFCWC67ClfWNdNGNQVEaceQHi4UDVTl/i7bt6/AI+QkHZNtXcoC9Gp85bTF7jjeSp9078icPPMkEkWjm1qOBvvGYREsE3U49bdv6yKOoMyDPTj4VJW2UFwNMTkbjYw8f1uHjoXDFmbIetlYPKrcLULFuCzpNCH20dmVqFYq51KXm2XGiwUEl/hg7qx+5D+nGI4dgwmjiVlneHRMrK9n4AwiKiugGqExG2DNtk4zA9yLGFtUkslPXwfLFDIQy9U0LKDT71eHlIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fDwYBtKxH1XG+Vjf4A4tAo4GymfAfBlFaGIqBWuV+Mc=; b=GAsvysTVVQhn1OEN2vIDvcExFkqhSGxRf4zAmDTwAYSL74jwvmOmp16dupFDQsn3zhcPFSIl+4KfY0yuqFdOD1CQhHJ4vex57iZsQijENKkR3GrvScUG9Kj3lxtknAo4IRj5eT1Ldqa2RP2ZpZKhRA6P/J1VBTp2/M6vRtcdNOzTkLApAlfi7v5VHYyGm2f77h+wrsUNuXcLmkcNEF38E8jVAYccG0ofcevRmhiP4co3aWtz1LE/oyJdGl+fm6J+fMUbacuuyPVQsey1hU3h8QQgfTtqAWHmMt2EflWWO/H7z3XEMpr1eRxNyJf6P/Frfr3uMf6bYqimAkaOoxqWfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fDwYBtKxH1XG+Vjf4A4tAo4GymfAfBlFaGIqBWuV+Mc=; b=JNx3WGJqXFYqlw0sPpeXIQ9b0mdY2l6O8V57wENVeAhtIFaIi5sETe6jpMMjygAk/V9S0sWr5NzdwoCkzTJ1daB4cDW1KXcJL+44/6/vTe+HAPgAWk9iKX4NanYbKI/vxzWbHzwN/0p0JFK2mUk/ZWLbZDqZkH7ytGDhuWVItcI= Received: from MWHPR11MB1373.namprd11.prod.outlook.com (10.169.234.141) by MWHPR11MB1453.namprd11.prod.outlook.com (10.172.54.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.18; Thu, 17 Oct 2019 17:06:32 +0000 Received: from MWHPR11MB1373.namprd11.prod.outlook.com ([fe80::c518:fad3:68fe:ce20]) by MWHPR11MB1373.namprd11.prod.outlook.com ([fe80::c518:fad3:68fe:ce20%12]) with mapi id 15.20.2347.024; Thu, 17 Oct 2019 17:06:32 +0000 From: To: Subject: Re: [PATCH] staging: wilc1000: potential corruption in wilc_parse_join_bss_param() Thread-Topic: [PATCH] staging: wilc1000: potential corruption in wilc_parse_join_bss_param() Thread-Index: AQHVhMwS9hB5KMK9e0muJstOe8jjSadfEMIA Date: Thu, 17 Oct 2019 17:06:32 +0000 Message-ID: <79ba46e7-9349-04fa-40f7-5367672b8189@microchip.com> References: <20191017091832.GB31278@mwanda> In-Reply-To: <20191017091832.GB31278@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [198.175.253.81] user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 x-clientproxiedby: BY5PR03CA0011.namprd03.prod.outlook.com (2603:10b6:a03:1e0::21) To MWHPR11MB1373.namprd11.prod.outlook.com (2603:10b6:300:25::13) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bbe955bb-bcb3-47d0-84f7-08d753245bcb x-ms-traffictypediagnostic: MWHPR11MB1453: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3383; x-forefront-prvs: 01930B2BA8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(346002)(396003)(136003)(366004)(189003)(199004)(66556008)(66446008)(86362001)(11346002)(8676002)(6916009)(36756003)(64756008)(66476007)(66946007)(31696002)(316002)(81166006)(81156014)(58126008)(8936002)(476003)(2616005)(446003)(5660300002)(4744005)(66066001)(65956001)(65806001)(7736002)(2906002)(305945005)(76176011)(53546011)(386003)(31686004)(6436002)(6506007)(99286004)(3846002)(54906003)(6512007)(256004)(25786009)(478600001)(6246003)(4326008)(14454004)(26005)(186003)(71200400001)(71190400001)(102836004)(486006)(229853002)(6486002)(6116002)(52116002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR11MB1453; H:MWHPR11MB1373.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sxbiiX/rQXccK3+HrXMvsA8Mpi7eG369wrN+X82I0mxCiGXz0NKTLz7Pqty78dMhtmGpQzyxFT99rWauKNqqVQYWBy61kKUys/BpyVnedniNDThZFzu/+gIh8hEOkReB96zP3vMKBkkcIaV1nVOpBDkhQKfk9z/b0nRtvr1Sr2TX4E0gkFHrwosWTLfWklrGR5IPDpvXXLY38Tvrr0EckA3GDJfapoR9nNbikww4oU1t8A6TGOaSVFCMHoNaAaJKwpoT1+7hKR7l4YMKnMqajBLgMID3LyFQ084G2u4VyJIWsP0H336ud4Zj09uGZcvERV156HqtwLuooKZGLTL00BX1S8foqLvYkemIoqbdzLCXFpC8TG7f+NsShKPJLZgiuI2MeCIfDD8v7n/5rAXCzD7FZC8VYWJNZdS71x/GlA4= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bbe955bb-bcb3-47d0-84f7-08d753245bcb X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2019 17:06:32.2635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lo0pfXn7/Ofpv3LhCVernmotsuq9pyaORLcScEP2m7id4jUhDO1kaFlVAXv8uXe61/UMoE4yDDb/hpqNsHb3UeFe9FiRgVHA8B3Z1Wfoock= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1453 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, Ajay.Kathat@microchip.com, kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On 10/17/19 2:18 AM, Dan Carpenter wrote: > The "rates_len" value needs to be capped so that the memcpy() doesn't > copy beyond the end of the array. > > Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") > Signed-off-by: Dan Carpenter > --- > drivers/staging/wilc1000/wilc_hif.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Adham Abozaeid Thanks Dan for the patch. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel