From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C518DC433DB for ; Tue, 16 Feb 2021 15:49:38 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 770D464DE0 for ; Tue, 16 Feb 2021 15:49:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 770D464DE0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ieee.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5802A84499; Tue, 16 Feb 2021 15:49:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mZJ884d0HhKW; Tue, 16 Feb 2021 15:49:37 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id B6A1584488; Tue, 16 Feb 2021 15:49:37 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id DAC791BF59E for ; Tue, 16 Feb 2021 15:49:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D4D698664C for ; Tue, 16 Feb 2021 15:49:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QtncYj307WyG for ; Tue, 16 Feb 2021 15:49:36 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by whitealder.osuosl.org (Postfix) with ESMTPS id 21EB786786 for ; Tue, 16 Feb 2021 15:49:36 +0000 (UTC) Received: by mail-io1-f50.google.com with SMTP id i8so6307950iog.7 for ; Tue, 16 Feb 2021 07:49:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=y7FAAueIFMAXFTE9aqqwaVuxVLzWJ41n1RibstBf/uw=; b=SHCf+Lr8Fai0+JIKF6loXEw9yJRu+EiA1D8AdZuiQpbpVYhDAoGb5wb0MZdfDrE+I8 wqw5SVPw5Haw+RsZQ25HkOw81kkwDgzLKgQWVChvG9y2l/EYO5gmn0d3nglSTU5XWHoA xosoQ8MpYSKhzMu6bczvWbOudi2SHjqAjmSZ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y7FAAueIFMAXFTE9aqqwaVuxVLzWJ41n1RibstBf/uw=; b=PHF5BtHcZuO7AjVG1yPXmxCbYp8J7gWSu7arUnayj9AZIdKHikrrPWWMuZmu5VDTcO n8D5FK6pyxKaly5iKNJYaEreiIWX0o+PVRRucOoyvyqZwi6mRIlpUECpBy8DJMyrfXI4 eO8TPsHMeHLSwah6ZpYCY8q+dbm5C1lTcatOTH4yiKXeql3oqFrWW2okGIjPcEi/EAYG grB2UZlLBTo1okP3Fwd2OjMHAZFGzXYsDH7IBxI5Qd9Hqnret0AAuTS9kmJceZoINqyr Amnxsh45bT6C2O4yWhiOUVpe2ZnaOTTgOWYS1rAKRP2jBZQR3kXkA0/KG1qtGG2djzUJ QIxA== X-Gm-Message-State: AOAM53361VYm3aJJF8rjUEmGC7zEp7ZDzphvSSpjNp9MQdSbASi2XaOG OaJ5/Qi1vLkBfOWgsji5sdKt9Q== X-Google-Smtp-Source: ABdhPJwUZNvwU49wt0M7ae6klwO05ufg/idd6YcypAKodnZIVmawBJoecT36s9t00oRUiMz2HIYfrw== X-Received: by 2002:a5e:a911:: with SMTP id c17mr17526518iod.20.1613490575345; Tue, 16 Feb 2021 07:49:35 -0800 (PST) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id i20sm10877449ila.82.2021.02.16.07.49.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Feb 2021 07:49:34 -0800 (PST) Subject: Re: [PATCH 02/13] staging: greybus: Switch from strlcpy to strscpy To: Kumar Kartikeya Dwivedi References: <20210131172838.146706-1-memxor@gmail.com> <20210131172838.146706-3-memxor@gmail.com> <20210216154800.jg24ahfj52t6qgbd@apollo> From: Alex Elder Message-ID: <8b51d270-5d25-919d-2034-8452513e3eaf@ieee.org> Date: Tue, 16 Feb 2021 09:49:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210216154800.jg24ahfj52t6qgbd@apollo> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jon Nettleton , Mark Greer , Marc Dietrich , Ioana Ciornei , Thomas Gleixner , ac100@lists.launchpad.net, devel@driverdev.osuosl.org, Stephen Rothwell , Florian Fainelli , Daniel Drake , Jens Frederich , Viresh Kumar , Robert Richter , Vaibhav Agarwal , Johan Hovold , Ian Abbott , Al Viro , linux-tegra@vger.kernel.org, William Cohen , Florian Schilhabel , Alex Elder , Teddy Wang , greybus-dev@lists.linaro.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Andrew Morton , Sudip Mukherjee , Mike Rapoport , Larry Finger Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On 2/16/21 9:48 AM, Kumar Kartikeya Dwivedi wrote: > On Tue, Feb 16, 2021 at 08:24:59PM IST, Alex Elder wrote: >> This is a good change. But while you're at it, I would >> appreciate if you would convert a few spots to use >> sizeof(dest) rather than a fixed constant. I will >> point them out below. >> >> If this is the *only* request for a change on your >> series, please tell me that and I can sign off on > > So far, this has been the only request. > >> this without you implementing my suggestion. But >> if you post a version 2, please do what I describe. >> > > I will incorporate these if I end up sending a v2. > > Alternatively, would a separate patch with your suggestions applied on top of > this be acceptable, if I don't? Yes. Assuming you do that, for this patch (as-is): Reviewed-by: Alex Elder _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel