From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FA35C3A5A8 for ; Wed, 4 Sep 2019 16:51:50 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 743E920882 for ; Wed, 4 Sep 2019 16:51:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="N8PIZnJH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 743E920882 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 466A18575E; Wed, 4 Sep 2019 16:51:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 11VHAO8-kmsy; Wed, 4 Sep 2019 16:51:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id BB76C86142; Wed, 4 Sep 2019 16:51:49 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 86AA51BF841 for ; Wed, 4 Sep 2019 16:51:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 824138575E for ; Wed, 4 Sep 2019 16:51:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DJsMQR2U7Yxf for ; Wed, 4 Sep 2019 16:51:47 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 2C38586142 for ; Wed, 4 Sep 2019 16:51:47 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id 97so18454505otr.4 for ; Wed, 04 Sep 2019 09:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MlIv6DeXLkg4uR1/sPKQNkLhMSuShpHchXiSAIDmZ0E=; b=N8PIZnJHFOI8JoHe9sxqWDMgOn4GZ6iQqYjA020wCxu3o7sOm/6bIQk9/8EoQ+OeZa AKLFKYYU9+YgR34WalofuXjHVk6yw6IoIL/Fa+YtH3YhWpsdBH7FzVe7fsFuvrCQEccM mHW9Zd3+Rsd8IZLmjvjy1WCd/QoQ/gIbtTdIArWVI8DqvE6tfdZaK9Rb/8sy6Ko7Q2l7 O0vbYxXouuJ3S45WM6Wj2vdWqPqDplGZJCnyPjhwGI2HRdgKWyAouB0OFCvt3NiuPEqQ WxMXHJU7nUBKYXRaaM02KRIQoeMN+HtidM91MfhREDtcBhB71gvzzc8Nx78tAhdmlFfu Pvww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MlIv6DeXLkg4uR1/sPKQNkLhMSuShpHchXiSAIDmZ0E=; b=FfJB7bE6Zv6JR2FwXnATMmvqFeIJbz7NMqSoQUxU5EbZkg866DZ7ZVl89dSbLhdc1S te/Hhx4ArgZ8xxTXb7LaOwOoWyei1JNkQEa4Zy/htt6TvR+2PVeathlKMuqs5BN9GYYO 5coYj0hUIhwSmmdxSPA2/aO332CScDkQnHGexr9pyYlDXcpT8mjft+U28PGbB3i3fnqd c1H+At3MReXWT12CrTzjwH5oOa2esGLiAxgCM7/6X1+R/nFJ7/zOKky1AfYH71W6uzzu kLkKw3csaPg65g3f2Ddp6hNJfAmfOHkk5tpNYYGXCMvv8Pw88ScGwvagSnepdkvgkPQu Q12g== X-Gm-Message-State: APjAAAVv3GZJMiODYkw2hY9eFFdSmEtW/b6EeVseIDIy8Jo57aFoo7bZ AIw/1SijE2R7PTx112nI3hVsyevDixV+KAGGk4vQqQ== X-Google-Smtp-Source: APXvYqydoIKXu3gB6t4ZJpZ6BjNALeXpBGBsWdQ9ycCVnj7lK23s91IiGy8iCWh0qHMq+IHITd+wqHt/tVATfORbQoA= X-Received: by 2002:a05:6830:1bc3:: with SMTP id v3mr14369770ota.97.1567615906001; Wed, 04 Sep 2019 09:51:46 -0700 (PDT) MIME-Version: 1.0 References: <20190903161655.107408-1-hridya@google.com> <20190904111934.ya37tlzqjqvt7h6a@wittgenstein> <20190904144903.GA30432@kroah.com> <20190904151212.wolcug25ozytp4bw@wittgenstein> In-Reply-To: <20190904151212.wolcug25ozytp4bw@wittgenstein> From: Hridya Valsaraju Date: Wed, 4 Sep 2019 09:51:09 -0700 Message-ID: Subject: Re: [PATCH v3 0/4] Add binder state and statistics to binderfs To: Christian Brauner X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:ANDROID DRIVERS" , Todd Kjos , Greg Kroah-Hartman , LKML , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Martijn Coenen , Joel Fernandes , kernel-team Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, Sep 4, 2019 at 8:12 AM Christian Brauner wrote: > > On Wed, Sep 04, 2019 at 04:49:03PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 04, 2019 at 10:20:32AM -0400, Joel Fernandes wrote: > > > On September 4, 2019 7:19:35 AM EDT, Christian Brauner > > > wrote: > > > >On Tue, Sep 03, 2019 at 09:16:51AM -0700, Hridya Valsaraju wrote: > > > >> Currently, the only way to access binder state and > > > >> statistics is through debugfs. We need a way to > > > >> access the same even when debugfs is not mounted. > > > >> These patches add a mount option to make this > > > >> information available in binderfs without affecting > > > >> its presence in debugfs. The following debugfs nodes > > > >> will be made available in a binderfs instance when > > > >> mounted with the mount option 'stats=global' or 'stats=local'. > > > >> > > > >> /sys/kernel/debug/binder/failed_transaction_log > > > >> /sys/kernel/debug/binder/proc > > > >> /sys/kernel/debug/binder/state > > > >> /sys/kernel/debug/binder/stats > > > >> /sys/kernel/debug/binder/transaction_log > > > >> /sys/kernel/debug/binder/transactions > > > > > > > >Acked-by: Christian Brauner > > > > > > > >Btw, I think your counting is off-by-one. :) We usually count the > > > >initial send of a series as 0 and the first rework of that series as > > > >v1. > > > >I think you counted your initial send as v1 and the first rework as v2. > > > > > > Which is fine. I have done it both ways. Is this a rule written somewhere? > > > > No where, I can count both ways, it's not a big deal :) > > It isn't documented (as many things we still do are) and it's not a big > deal. But most people seem to be counting revisions starting from 0 it > seems. I went looking for previous version to link to in the patch cover > letter and was confused because I was missing a v1. :) > > Anyway, I'm happy that Hridya landed this! It was fun helping her the > last couple of weeks on- and off-list. Thanks for getting this done! I > hope we'll see even more patches in the future. :) Thank you so much Christian and Todd for the guidance and thorough reviews on the many patches I sent your way both on and off-list :) I really appreciate it! > > Christian _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel