From: hridya@google.com (Hridya Valsaraju)
Subject: [PATCH v3 1/2] binder: Add default binder devices through binderfs when configured
Date: Fri, 9 Aug 2019 13:08:01 -0700 [thread overview]
Message-ID: <CA+wgaPNjfvcVvcDB9ZBWupLegHchZ3AxYibBV8BPFE9SrPymtg@mail.gmail.com> (raw)
In-Reply-To: <20190809182216.5xzx6tss6fh42mso@wittgenstein>
On Fri, Aug 9, 2019 at 11:22 AM Christian Brauner
<christian.brauner@ubuntu.com> wrote:
>
> On Fri, Aug 09, 2019@04:50:16PM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Aug 08, 2019@03:27:25PM -0700, Hridya Valsaraju wrote:
> > > Currently, since each binderfs instance needs its own
> > > private binder devices, every time a binderfs instance is
> > > mounted, all the default binder devices need to be created
> > > via the BINDER_CTL_ADD IOCTL.
> >
> > Wasn't that a design goal of binderfs?
>
> Sure, but if you solely rely binderfs to be used to provide binder
> devices having them pre-created on each mount makes quite some sense,
> imho.
>
> >
> > > This patch aims to
> > > add a solution to automatically create the default binder
> > > devices for each binderfs instance that gets mounted.
> > > To achieve this goal, when CONFIG_ANDROID_BINDERFS is set,
> > > the default binder devices specified by CONFIG_ANDROID_BINDER_DEVICES
> > > are created in each binderfs instance instead of global devices
> > > being created by the binder driver.
> >
> > This is going to change how things work today, what is going to break
> > because of this change?
> >
> > I don't object to this, except for the worry of changing the default
> > behavior.
>
> This is something that Hridya and Todd can speak better to given that
> they suggested this change. :)
> From my perspective, binderfs binder devices and the regular binder
> driver are mostly used mutually exclusive in practice atm so that this
> change has little chance of breaking anyone.
As Christian says, we do not anticipate the change to break any
existing use cases since binderfs binder devices and regular binder
devices are generally not used simultaneously. Hopefully, there are
not a lot of unusual use cases since binderfs itself is relatively new
as well :)
>
> Now I really need to go back to vacation time - which I suck at
> apparently. :)
>
> Christian
next prev parent reply other threads:[~2019-08-09 20:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 22:27 [PATCH v3 0/2] Add default binderfs devices Hridya Valsaraju
2019-08-08 22:27 ` [PATCH v3 1/2] binder: Add default binder devices through binderfs when configured Hridya Valsaraju
2019-08-09 14:50 ` Greg Kroah-Hartman
2019-08-09 18:22 ` Christian Brauner
2019-08-09 20:08 ` Hridya Valsaraju [this message]
2019-08-15 16:28 ` Joel Fernandes
2019-08-15 16:30 ` Joel Fernandes
2019-08-08 22:27 ` [PATCH v3 2/2] binder: Validate the default binderfs device names Hridya Valsaraju
2019-08-09 14:51 ` Greg Kroah-Hartman
2019-08-09 14:55 ` Greg Kroah-Hartman
2019-08-09 18:14 ` Christian Brauner
2019-08-09 18:41 ` Hridya Valsaraju
2019-09-04 7:19 ` Greg Kroah-Hartman
2019-09-04 10:44 ` Christian Brauner
2019-09-04 10:49 ` Greg Kroah-Hartman
2019-09-04 11:07 ` Christian Brauner
2019-08-15 16:31 ` Joel Fernandes
2019-08-15 16:00 ` [PATCH v3 0/2] Add default binderfs devices Greg Kroah-Hartman
2019-09-04 11:07 ` [RESEND PATCH " Christian Brauner
2019-09-04 11:07 ` [RESEND PATCH v3 1/2] binder: Add default binder devices through binderfs when configured Christian Brauner
2019-09-04 11:07 ` [RESEND PATCH v3 2/2] binder: Validate the default binderfs device names Christian Brauner
2019-09-04 11:18 ` [RESEND PATCH v3 0/2] Add default binderfs devices Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+wgaPNjfvcVvcDB9ZBWupLegHchZ3AxYibBV8BPFE9SrPymtg@mail.gmail.com \
--to=hridya@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).