From: Ju Hyung Park <qkrwngud825@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Namjae Jeon <namjae.jeon@samsung.com>,
sj1557.seo@samsung.com
Cc: devel@driverdev.osuosl.org, linkinjeon@gmail.com,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-kernel@vger.kernel.org, alexander.levin@microsoft.com,
sergey.senozhatsky@gmail.com, linux-fsdevel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0
Date: Thu, 19 Sep 2019 05:22:03 +0900 [thread overview]
Message-ID: <CAD14+f0YeAPxmLbxB5gpJbNyjE1YiDyicBXeodwKN4Wvm_qJwA@mail.gmail.com> (raw)
In-Reply-To: <20190918201318.GB2025570@kroah.com>
Hi Greg,
On Thu, Sep 19, 2019 at 5:12 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> That's a lot of rewriting :(
>
> How about at least keeping the file names the same to make it easier to
> see what happened here?
>
> Then send a follow-on patch that just does the rename?
That's still not quite useful tbh, lemme bring the diff stat I wrote
in previous email just in case you missed it:
<Full diff stat>
Kconfig | 79 +-
Makefile | 46 +-
api.c | 423 ----
api.h | 310 ---
blkdev.c | 409 +---
cache.c | 1142 ++++-----
config.h | 49 -
core.c | 5583 ++++++++++++++++++++++++--------------------
core.h | 196 --
core_exfat.c | 1553 ------------
exfat.h | 1309 +++++++----
exfat_fs.h | 417 ----
extent.c | 351 ---
fatent.c | 182 --
misc.c | 401 ----
nls.c | 490 ++--
super.c | 5103 +++++++++++++++++++++-------------------
upcase.c | 740 ++++++
upcase.h | 407 ----
version.h | 29 -
xattr.c | 136 --
21 files changed, 8186 insertions(+), 11169 deletions(-)
<diff-filter=M>
Kconfig | 79 +-
Makefile | 46 +-
blkdev.c | 409 +---
cache.c | 1142 +++++-----
core.c | 5583 ++++++++++++++++++++++++++----------------------
exfat.h | 1309 ++++++++----
nls.c | 490 ++---
super.c | 5103 ++++++++++++++++++++++---------------------
8 files changed, 7446 insertions(+), 6715 deletions(-)
These diff stats were taken by removing "exfat_" prefix from the
current staging drivers.
But if that's still what you want, I'll do it.
btw, removing "exfat_" prefix from the current one makes more sense imo.
If we add "exfat_" prefix to the new one, we get weird file names like
"exfat_core_exfat.c".
> And by taking something like this, are you agreeing that Samsung will
> help out with the development of this code to clean it up and get it
> into "real" mergable shape?
Well, I think you got me confused with Namjae.
(Yeah Korean names are confusing I know :) )
Namjae (or anyone else from Samsung) should answer that, not me.
I just prepared a patch as we were getting nowhere like you mentioned :)
> Also, I can't take this patch for this simple reason alone:
> Don't delete SPDX lines :)
Sorry.
I'll add that back for v2.
On Thu, Sep 19, 2019 at 5:13 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Sep 19, 2019 at 04:59:20AM +0900, Park Ju Hyung wrote:
> > --- a/drivers/staging/exfat/exfat.h
> > +++ b/drivers/staging/exfat/exfat.h
> > @@ -1,4 +1,4 @@
> > -/* SPDX-License-Identifier: GPL-2.0 */
> > +// SPDX-License-Identifier: GPL-2.0-or-later
>
> You just changed the license of this file. Are you SURE about that?
The sdFAT code release explicitly states "either version 2 of the
License, or (at your option) any later version", so I thought that
makes sense:
https://github.com/arter97/exfat-linux/commit/d5393c4cbe0e5b50231aacd33d9b5b0ddf46a005
Please correct me if I'm wrong.
Thanks.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-09-18 20:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190828160817.6250-1-gregkh@linuxfoundation.org>
[not found] ` <20190829205631.uhz6jdboneej3j3c@pali>
2019-08-30 15:40 ` [PATCH] staging: exfat: add exfat filesystem code to staging Christoph Hellwig
2019-08-30 15:43 ` Pali Rohár
[not found] ` <184209.1567120696@turing-police>
[not found] ` <20190829233506.GT5281@sasha-vm>
[not found] ` <20190830075647.wvhrx4asnkrfkkwk@pali>
2019-10-16 14:03 ` Pali Rohár
2019-10-16 14:31 ` Sasha Levin
2019-10-16 16:03 ` Pali Rohár
2019-10-16 16:20 ` Sasha Levin
2019-10-16 16:22 ` Greg Kroah-Hartman
2019-10-16 16:32 ` Pali Rohár
2019-10-16 16:50 ` Greg Kroah-Hartman
2019-10-16 20:33 ` Sasha Levin
2019-10-16 21:53 ` Valdis Klētnieks
2019-10-17 7:53 ` Pali Rohár
2019-10-17 7:50 ` Pali Rohár
2020-02-13 0:06 ` Pali Rohár
2020-02-13 21:18 ` Sasha Levin
2020-02-14 22:16 ` Valdis Klētnieks
2020-02-14 22:43 ` Pali Rohár
2020-02-14 23:25 ` Valdis Klētnieks
2020-04-21 21:30 ` exfat upcase table for code points above U+FFFF (Was: Re: [PATCH] staging: exfat: add exfat filesystem code to staging) Pali Rohár
2020-04-27 15:49 ` Sasha Levin
2020-04-28 7:46 ` Pali Rohár
2019-10-16 16:05 ` [PATCH] staging: exfat: add exfat filesystem code to staging Valdis Klētnieks
[not found] ` <20190828170022.GA7873@kroah.com>
[not found] ` <20190829062340.GB3047@infradead.org>
[not found] ` <20190829063955.GA30193@kroah.com>
[not found] ` <20190829094136.GA28643@infradead.org>
[not found] ` <20190829095019.GA13557@kroah.com>
[not found] ` <20190829103749.GA13661@infradead.org>
[not found] ` <20190829111810.GA23393@kroah.com>
2019-08-30 15:36 ` Christoph Hellwig
2019-08-30 21:54 ` Dave Chinner
2019-08-31 10:31 ` Valdis Klētnieks
2019-09-01 0:04 ` Dave Chinner
[not found] ` <20190829151144.GJ23584@kadam>
[not found] ` <20190829152757.GA125003@architecture4>
[not found] ` <20190829154346.GK23584@kadam>
[not found] ` <cd38b645-2930-3e02-6c6a-5972ea02b537@huawei.com>
[not found] ` <20190830115142.GM2752@twin.jikos.cz>
2019-08-31 3:50 ` Chao Yu
2019-09-14 13:39 ` [PATCH] staging: exfat: add exfat filesystem code to Park Ju Hyung
2019-09-15 13:54 ` Greg KH
2019-09-15 16:11 ` Ju Hyung Park
[not found] ` <20190918195920.25210-1-qkrwngud825@gmail.com>
2019-09-18 20:12 ` [PATCH] staging: exfat: rebase to sdFAT v2.2.0 Greg KH
2019-09-18 20:13 ` Greg KH
2019-09-18 20:22 ` Ju Hyung Park [this message]
2019-09-18 20:26 ` Greg KH
2019-09-18 20:31 ` Ju Hyung Park
2019-09-18 20:46 ` Valdis Klētnieks
2019-09-18 21:31 ` kbuild test robot
2019-09-18 21:31 ` kbuild test robot
2019-09-18 22:17 ` Ju Hyung Park
2019-10-24 9:39 ` [PATCH] staging: exfat: add exfat filesystem code to staging Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD14+f0YeAPxmLbxB5gpJbNyjE1YiDyicBXeodwKN4Wvm_qJwA@mail.gmail.com \
--to=qkrwngud825@gmail.com \
--cc=alexander.levin@microsoft.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sj1557.seo@samsung.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).