From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E28C43331 for ; Thu, 26 Mar 2020 11:48:20 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BA9B20409 for ; Thu, 26 Mar 2020 11:48:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyGVE5SO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BA9B20409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 27BB388995; Thu, 26 Mar 2020 11:48:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sYQGywUqFZ4G; Thu, 26 Mar 2020 11:48:19 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 1BDC188B38; Thu, 26 Mar 2020 11:48:19 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id AEBF51BF4D8 for ; Thu, 26 Mar 2020 11:48:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id A8BE926045 for ; Thu, 26 Mar 2020 11:48:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iswaENgLPHrJ for ; Thu, 26 Mar 2020 11:48:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ua1-f65.google.com (mail-ua1-f65.google.com [209.85.222.65]) by silver.osuosl.org (Postfix) with ESMTPS id 42BC2227FF for ; Thu, 26 Mar 2020 11:48:16 +0000 (UTC) Received: by mail-ua1-f65.google.com with SMTP id r47so1970873uad.11 for ; Thu, 26 Mar 2020 04:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CAFgtb/VAGC6zoqooeJ31o/q4Qs3+JwUo6JGkTCwzXg=; b=TyGVE5SOiS5nNd0DmEfjjZmH71PdcCXMQ6Kkq+90FxhXBGqKKF8jNdq2kToU6KLq+A z1eUCc5iuHbreqRcdhWnmoajPHhD4xO8oHH1LR6JJepxfvfBOTNg6awLMfJ4mHdPxnb4 aERUKySDpqIZqLg491j9f+XDigPZi7fY0ZYnDCAvZKrV5+akm3MMOwdKqNRG/GcBkb/V pU+/8aS7GEoS5XcToH2fl9Lqin1LKfv4Be7rPi+huQHEYPLjKbGBfc6MTHMXcBONW2q8 sK34Bw69PTODRtlhESS/2letLoLBopL3HK2FjmIpfdowkLSdgpLfo7zjNNJD2xMsPi6T Pefg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CAFgtb/VAGC6zoqooeJ31o/q4Qs3+JwUo6JGkTCwzXg=; b=Ng8+kgweKEh49QaKcJa0hFyVcjJvILzIy2yWJAiaSr4v3AGcIqUH0EJPFSr7D0MJom b8ywpaUGAfrEtYTXEX/X6xSVP5Coi82w4C6sWeiTuy9W+u8IOebm3PC0E8yMzyu6zuOQ AmYbM0+e0JrKiVVLu2Xlyq4y6Eo0JBFueMfRlG8caklgyR/13FLt4Hc+nGeVYri01HN8 3A2mJ9kYMZWkQuDjIqKevfF9hsn+UM0n5cWP/LMeLqROthJKlTt8uJIQ5gkdjxH3YYjr ce62VtEzuC+PatTcPrdGwoQtZ6V6BkAzrbCAKOyaO/RzblSVbCm2nnf0p8sZ9zX4X74G ZyWQ== X-Gm-Message-State: ANhLgQ1ivsobQ7RYBbla8KoFPiNXZNIoKnb2R1kuE41Dn9JFHvZCULOA fKp0rxYA0RzUhz1x1Zw5ERIHTG/zlpKSbnmB/WI= X-Google-Smtp-Source: ADFU+vsfsEU0Bc5w4BGxPLNwkj51GY7uF1RKzv+17Qwbli8xFfr1ETwOUHwZYqRvpqdliCtJnxPdK9NPdtnFZCLbLmY= X-Received: by 2002:ab0:7406:: with SMTP id r6mr5644632uap.22.1585223295076; Thu, 26 Mar 2020 04:48:15 -0700 (PDT) MIME-Version: 1.0 References: <0000000000006678a105a184ecb7@google.com> In-Reply-To: From: Qiujun Huang Date: Thu, 26 Mar 2020 19:48:03 +0800 Message-ID: Subject: Re: KASAN: use-after-free Read in hfa384x_usbin_callback To: Andrey Konovalov X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg KH , USB list , syzkaller-bugs , LKML , nishkadg.linux@gmail.com, osdevtc@gmail.com, syzbot Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Yes, they have the same root cause. On Thu, Mar 26, 2020 at 6:45 PM Andrey Konovalov wrote: > > On Thu, Mar 26, 2020 at 3:52 AM Qiujun Huang wrote: > > > > #syz test: https://github.com/google/kasan.git e17994d1 > > Hi Qiujun, > > I've already duped this bug to "KASAN: slab-out-of-bounds Read in > hfa384x_usbin_callback" since I had assumed they have the same root > cause. Are those bugs different? We can undup if needed. > > Thanks! > > > > > On Mon, Mar 23, 2020 at 8:39 PM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit: e17994d1 usb: core: kcov: collect coverage from usb comple.. > > > git tree: https://github.com/google/kasan.git usb-fuzzer > > > console output: https://syzkaller.appspot.com/x/log.txt?x=15217373e00000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=5d64370c438bc60 > > > dashboard link: https://syzkaller.appspot.com/bug?extid=a57b24d359dc5577634a > > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14a720ade00000 > > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1467b755e00000 > > > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > > Reported-by: syzbot+a57b24d359dc5577634a@syzkaller.appspotmail.com > > > > > > ================================================================== > > > BUG: KASAN: use-after-free in memcpy include/linux/string.h:381 [inline] > > > BUG: KASAN: use-after-free in skb_put_data include/linux/skbuff.h:2284 [inline] > > > BUG: KASAN: use-after-free in hfa384x_int_rxmonitor drivers/staging/wlan-ng/hfa384x_usb.c:3412 [inline] > > > BUG: KASAN: use-after-free in hfa384x_usbin_rx drivers/staging/wlan-ng/hfa384x_usb.c:3312 [inline] > > > BUG: KASAN: use-after-free in hfa384x_usbin_callback+0x1993/0x2360 drivers/staging/wlan-ng/hfa384x_usb.c:3026 > > > Read of size 34945 at addr ffff8881cda9f33c by task swapper/0/0 > > > > > > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.6.0-rc5-syzkaller #0 > > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > > > Call Trace: > > > > > > __dump_stack lib/dump_stack.c:77 [inline] > > > dump_stack+0xef/0x16e lib/dump_stack.c:118 > > > print_address_description.constprop.0.cold+0xd3/0x314 mm/kasan/report.c:374 > > > __kasan_report.cold+0x37/0x77 mm/kasan/report.c:506 > > > kasan_report+0xe/0x20 mm/kasan/common.c:641 > > > check_memory_region_inline mm/kasan/generic.c:185 [inline] > > > check_memory_region+0x152/0x1c0 mm/kasan/generic.c:192 > > > memcpy+0x20/0x50 mm/kasan/common.c:127 > > > memcpy include/linux/string.h:381 [inline] > > > skb_put_data include/linux/skbuff.h:2284 [inline] > > > hfa384x_int_rxmonitor drivers/staging/wlan-ng/hfa384x_usb.c:3412 [inline] > > > hfa384x_usbin_rx drivers/staging/wlan-ng/hfa384x_usb.c:3312 [inline] > > > hfa384x_usbin_callback+0x1993/0x2360 drivers/staging/wlan-ng/hfa384x_usb.c:3026 > > > __usb_hcd_giveback_urb+0x29a/0x550 drivers/usb/core/hcd.c:1650 > > > usb_hcd_giveback_urb+0x368/0x420 drivers/usb/core/hcd.c:1716 > > > dummy_timer+0x1258/0x32ae drivers/usb/gadget/udc/dummy_hcd.c:1966 > > > call_timer_fn+0x195/0x6f0 kernel/time/timer.c:1404 > > > expire_timers kernel/time/timer.c:1449 [inline] > > > __run_timers kernel/time/timer.c:1773 [inline] > > > __run_timers kernel/time/timer.c:1740 [inline] > > > run_timer_softirq+0x5f9/0x1500 kernel/time/timer.c:1786 > > > __do_softirq+0x21e/0x950 kernel/softirq.c:292 > > > invoke_softirq kernel/softirq.c:373 [inline] > > > irq_exit+0x178/0x1a0 kernel/softirq.c:413 > > > exiting_irq arch/x86/include/asm/apic.h:546 [inline] > > > smp_apic_timer_interrupt+0x141/0x540 arch/x86/kernel/apic/apic.c:1146 > > > apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:829 > > > > > > RIP: 0010:default_idle+0x28/0x300 arch/x86/kernel/process.c:696 > > > Code: cc cc 41 56 41 55 65 44 8b 2d 44 77 72 7a 41 54 55 53 0f 1f 44 00 00 e8 b6 62 b5 fb e9 07 00 00 00 0f 00 2d ea 0c 53 00 fb f4 <65> 44 8b 2d 20 77 72 7a 0f 1f 44 00 00 5b 5d 41 5c 41 5d 41 5e c3 > > > RSP: 0018:ffffffff87007d80 EFLAGS: 00000246 ORIG_RAX: ffffffffffffff13 > > > RAX: 0000000000000007 RBX: ffffffff8702cc40 RCX: 0000000000000000 > > > RDX: 0000000000000000 RSI: 0000000000000006 RDI: ffffffff8702d48c > > > RBP: fffffbfff0e05988 R08: ffffffff8702cc40 R09: 0000000000000000 > > > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 > > > R13: 0000000000000000 R14: ffffffff87e607c0 R15: 0000000000000000 > > > cpuidle_idle_call kernel/sched/idle.c:154 [inline] > > > do_idle+0x3e0/0x500 kernel/sched/idle.c:269 > > > cpu_startup_entry+0x14/0x20 kernel/sched/idle.c:361 > > > start_kernel+0xe16/0xe5a init/main.c:998 > > > secondary_startup_64+0xb6/0xc0 arch/x86/kernel/head_64.S:242 > > > > > > The buggy address belongs to the page: > > > page:ffffea000736a600 refcount:32769 mapcount:0 mapping:0000000000000000 index:0x0 compound_mapcount: 0 > > > flags: 0x200000000010000(head) > > > raw: 0200000000010000 dead000000000100 dead000000000122 0000000000000000 > > > raw: 0000000000000000 0000000000000000 00008001ffffffff 0000000000000000 > > > page dumped because: kasan: bad access detected > > > > > > Memory state around the buggy address: > > > ffff8881cda9ff00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > > ffff8881cda9ff80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > > >ffff8881cdaa0000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > > ^ > > > ffff8881cdaa0080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > > ffff8881cdaa0100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > > ================================================================== > > > > > > > > > --- > > > This bug is generated by a bot. It may contain errors. > > > See https://goo.gl/tpsmEJ for more information about syzbot. > > > syzbot engineers can be reached at syzkaller@googlegroups.com. > > > > > > syzbot will keep track of this bug report. See: > > > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > > > syzbot can test patches for this bug, for details see: > > > https://goo.gl/tpsmEJ#testing-patches _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel