From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0CEC433E0 for ; Fri, 22 May 2020 08:57:08 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41D26206DD for ; Fri, 22 May 2020 08:57:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qr0aiPW8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41D26206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 330C387AAF; Fri, 22 May 2020 08:57:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lrWQOLVw6ve2; Fri, 22 May 2020 08:57:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 73BFB87A80; Fri, 22 May 2020 08:57:03 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 9F3C81BF5DD for ; Fri, 22 May 2020 08:56:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 986FB8360B for ; Fri, 22 May 2020 08:56:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xyv-jvXkVyxk for ; Fri, 22 May 2020 08:56:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 9058A874AA for ; Fri, 22 May 2020 08:56:57 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id q16so4152433plr.2 for ; Fri, 22 May 2020 01:56:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HqSbS1DmOxb6NnvLUkPt9gWJFICRLVchToB7BWy3wkM=; b=Qr0aiPW8ez2hrgndNNW2aOj6iqlB62Q8Csen7rUnDQ4NRSQgabRdbt4Bar3FrgoeRU YXe/TP39TtOUlyEh1cLBPdZCk/3YLTXEI8exjjKaqMuHdbLDb/LDti2axS0fZoZdjv6X 0rk/fuJGk8gCNdmHKmpZH1mOAOuASHs+GvXFrs0vC465xuXuDc20FQ9MDZktvpkvvcM+ wP1+Dj3op/rsVKhvvxL00J+CujdvevgPnITzD52gyqucL8HCn+9kocVSp/x8eCG/ChO+ d53iF9MzUCWVAhIo2r3a8H2gA92P6tU2Yaymg7kj07BQto/HSxVIzbiWLzcUStYCPO+c Rxyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HqSbS1DmOxb6NnvLUkPt9gWJFICRLVchToB7BWy3wkM=; b=D0T63M3YBdI7RfPKzbwc8m3uMMe/HXxdUU4FnoE9Fen0hLUnNF6MZO8sjOIxVOJ+M8 YbMocXWIpnWm4UvKwa+TiO/fGatRnMfAwxuIPDZaUKonkrOn+NuZ7bFIuPFT+9CfZcGr L+yKTsYaE+GUlb2w++RqPWcEu86/GH+g92un+oZ9gPW8w5bNFVgNjLbxFFKDua4XWqJ5 boaWT4XvDS1diw0nab8W945CT/z1O4SkLf5CSKv3XadJScCclxo+/iyAoVH/7ixZMdAn pRfUu9b4kw6RUnzfp4KxfQWJgWC9Pv1j2JMhYxCMXb278H9nrGjp+q+EZv6jpUkSIOdG 3p2Q== X-Gm-Message-State: AOAM530jKqzZ7pkcrA4c3NJpDurmHwE21DNDKaFhGxP0gJ782T/1eM+o 8N+/GJaJ3JaeKXBAiy4ukQw+PL2ZleF30puqQkc= X-Google-Smtp-Source: ABdhPJwsYnXnt44yegP0XDUJYXKvunyOh6UzNzQcRgehUIEvMayZ6aBV9NpqOVREx8Il9izBbtLfXR3AicsFux8O3e4= X-Received: by 2002:a17:902:ea8a:: with SMTP id x10mr13795881plb.255.1590137817033; Fri, 22 May 2020 01:56:57 -0700 (PDT) MIME-Version: 1.0 References: <20200522082208.383631-1-alexandru.ardelean@analog.com> In-Reply-To: <20200522082208.383631-1-alexandru.ardelean@analog.com> From: Andy Shevchenko Date: Fri, 22 May 2020 11:56:40 +0300 Message-ID: Subject: Re: [PATCH 1/5] iio: core: pass parent device as parameter during allocation To: Alexandru Ardelean X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: milo.kim@ti.com, tomislav.denis@avl.com, Dan Robertson , =?UTF-8?Q?Heiko_St=C3=BCbner?= , linux-aspeed@lists.ozlabs.org, linux-iio , Linus Walleij , Eddie James , Platform Driver , Paul Cercueil , Lorenzo Bianconi , Song Qiang , Srinivas Pandruvada , linux-stm32@st-md-mailman.stormreply.com, "open list:STAGING SUBSYSTEM" , linux-samsung-soc@vger.kernel.org, Kevin Hilman , tduszyns@gmail.com, Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, Chen-Yu Tsai , Kukjin Kim , bcm-kernel-feedback-list , agross@kernel.org, linux-input , orsonzhai@gmail.com, Alexandre TORGUE , Linux PM , linux-arm-msm@vger.kernel.org, Sascha Hauer , Jiri Kosina , William Breathitt Gray , Maxime Ripard , Vladimir Zapolskiy , Hans de Goede , "moderated list:ARM/Mediatek SoC support" , Andreas Klinger , Matthias Brugger , linux-amlogic@lists.infradead.org, Fabrice GASNIER , linux-arm Mailing List , Scott Branden , Shawn Guo , Dmitry Torokhov , Azael Avalos , Linux Kernel Mailing List , Ray Jui , Sylvain Lemieux , Bjorn Andersson , Maxime Coquelin , zhang.lyra@gmail.com, baolin.wang7@gmail.com, Kevin Tsai , Syed Nayyar Waris , Peter Rosin , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, May 22, 2020 at 11:36 AM Alexandru Ardelean wrote: > > The change passes the parent device to the iio_device_alloc() call. This > also updates the devm_iio_device_alloc() call to consider the device object > as the parent device by default. > > Having it passed like this, should ensure that any IIO device object > already has a device object as parent, allowing for neater control, like > passing the 'indio_dev' object for other stuff [like buffers/triggers/etc], > and potentially creating iiom_xxx(indio_dev) functions. > > With this patch, only the 'drivers/platform/x86/toshiba_acpi.c' needs an > update to pass the parent object as a parameter. Acked-by: Andy Shevchenko > > In the next patch all devm_iio_device_alloc() calls will be handled. > > Signed-off-by: Alexandru Ardelean > --- > drivers/iio/dummy/iio_simple_dummy.c | 14 ++++++++------ > drivers/iio/industrialio-core.c | 11 ++++++----- > drivers/platform/x86/toshiba_acpi.c | 3 +-- > drivers/staging/iio/Documentation/device.txt | 4 +--- > include/linux/iio/iio.h | 4 ++-- > 5 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/drivers/iio/dummy/iio_simple_dummy.c b/drivers/iio/dummy/iio_simple_dummy.c > index 6cb02299a215..b35ae7c039f7 100644 > --- a/drivers/iio/dummy/iio_simple_dummy.c > +++ b/drivers/iio/dummy/iio_simple_dummy.c > @@ -566,6 +566,13 @@ static struct iio_sw_device *iio_dummy_probe(const char *name) > struct iio_dev *indio_dev; > struct iio_dummy_state *st; > struct iio_sw_device *swd; > + struct device *parent = NULL; > + > + /* > + * With hardware: Set the parent device. > + * parent = &spi->dev; > + * parent = &client->dev; > + */ > > swd = kzalloc(sizeof(*swd), GFP_KERNEL); > if (!swd) { > @@ -580,7 +587,7 @@ static struct iio_sw_device *iio_dummy_probe(const char *name) > * It also has a region (accessed by iio_priv() > * for chip specific state information. > */ > - indio_dev = iio_device_alloc(sizeof(*st)); > + indio_dev = iio_device_alloc(parent, sizeof(*st)); > if (!indio_dev) { > ret = -ENOMEM; > goto error_ret; > @@ -590,11 +597,6 @@ static struct iio_sw_device *iio_dummy_probe(const char *name) > mutex_init(&st->lock); > > iio_dummy_init_device(indio_dev); > - /* > - * With hardware: Set the parent device. > - * indio_dev->dev.parent = &spi->dev; > - * indio_dev->dev.parent = &client->dev; > - */ > > /* > * Make the iio_dev struct available to remove function. > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c > index 1527f01a44f1..75661661aaba 100644 > --- a/drivers/iio/industrialio-core.c > +++ b/drivers/iio/industrialio-core.c > @@ -1493,7 +1493,7 @@ struct device_type iio_device_type = { > * iio_device_alloc() - allocate an iio_dev from a driver > * @sizeof_priv: Space to allocate for private structure. > **/ > -struct iio_dev *iio_device_alloc(int sizeof_priv) > +struct iio_dev *iio_device_alloc(struct device *parent, int sizeof_priv) > { > struct iio_dev *dev; > size_t alloc_size; > @@ -1510,6 +1510,7 @@ struct iio_dev *iio_device_alloc(int sizeof_priv) > if (!dev) > return NULL; > > + dev->dev.parent = parent; > dev->dev.groups = dev->groups; > dev->dev.type = &iio_device_type; > dev->dev.bus = &iio_bus_type; > @@ -1551,7 +1552,7 @@ static void devm_iio_device_release(struct device *dev, void *res) > > /** > * devm_iio_device_alloc - Resource-managed iio_device_alloc() > - * @dev: Device to allocate iio_dev for > + * @parent: Device to allocate iio_dev for, and parent for this IIO device > * @sizeof_priv: Space to allocate for private structure. > * > * Managed iio_device_alloc. iio_dev allocated with this function is > @@ -1560,7 +1561,7 @@ static void devm_iio_device_release(struct device *dev, void *res) > * RETURNS: > * Pointer to allocated iio_dev on success, NULL on failure. > */ > -struct iio_dev *devm_iio_device_alloc(struct device *dev, int sizeof_priv) > +struct iio_dev *devm_iio_device_alloc(struct device *parent, int sizeof_priv) > { > struct iio_dev **ptr, *iio_dev; > > @@ -1569,10 +1570,10 @@ struct iio_dev *devm_iio_device_alloc(struct device *dev, int sizeof_priv) > if (!ptr) > return NULL; > > - iio_dev = iio_device_alloc(sizeof_priv); > + iio_dev = iio_device_alloc(parent, sizeof_priv); > if (iio_dev) { > *ptr = iio_dev; > - devres_add(dev, ptr); > + devres_add(parent, ptr); > } else { > devres_free(ptr); > } > diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c > index 808944546739..4a4d09c352dd 100644 > --- a/drivers/platform/x86/toshiba_acpi.c > +++ b/drivers/platform/x86/toshiba_acpi.c > @@ -3128,7 +3128,7 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev) > > toshiba_accelerometer_available(dev); > if (dev->accelerometer_supported) { > - dev->indio_dev = iio_device_alloc(sizeof(*dev)); > + dev->indio_dev = iio_device_alloc(&acpi_dev->dev, sizeof(*dev)); > if (!dev->indio_dev) { > pr_err("Unable to allocate iio device\n"); > goto iio_error; > @@ -3138,7 +3138,6 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev) > > dev->indio_dev->info = &toshiba_iio_accel_info; > dev->indio_dev->name = "Toshiba accelerometer"; > - dev->indio_dev->dev.parent = &acpi_dev->dev; > dev->indio_dev->modes = INDIO_DIRECT_MODE; > dev->indio_dev->channels = toshiba_iio_accel_channels; > dev->indio_dev->num_channels = > diff --git a/drivers/staging/iio/Documentation/device.txt b/drivers/staging/iio/Documentation/device.txt > index ec42544a46aa..0d1275b1eb3f 100644 > --- a/drivers/staging/iio/Documentation/device.txt > +++ b/drivers/staging/iio/Documentation/device.txt > @@ -8,7 +8,7 @@ The crucial structure for device drivers in iio is iio_dev. > > First allocate one using: > > -struct iio_dev *indio_dev = iio_device_alloc(sizeof(struct chip_state)); > +struct iio_dev *indio_dev = iio_device_alloc(parent, sizeof(struct chip_state)); > where chip_state is a structure of local state data for this instance of > the chip. > > @@ -16,8 +16,6 @@ That data can be accessed using iio_priv(struct iio_dev *). > > Then fill in the following: > > -- indio_dev->dev.parent > - Struct device associated with the underlying hardware. > - indio_dev->name > Name of the device being driven - made available as the name > attribute in sysfs. > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h > index a1be82e74c93..91a69f4751aa 100644 > --- a/include/linux/iio/iio.h > +++ b/include/linux/iio/iio.h > @@ -676,7 +676,7 @@ static inline void *iio_device_get_drvdata(struct iio_dev *indio_dev) > > /* Can we make this smaller? */ > #define IIO_ALIGN L1_CACHE_BYTES > -struct iio_dev *iio_device_alloc(int sizeof_priv); > +struct iio_dev *iio_device_alloc(struct device *parent, int sizeof_priv); > > static inline void *iio_priv(const struct iio_dev *indio_dev) > { > @@ -690,7 +690,7 @@ static inline struct iio_dev *iio_priv_to_dev(void *priv) > } > > void iio_device_free(struct iio_dev *indio_dev); > -struct iio_dev *devm_iio_device_alloc(struct device *dev, int sizeof_priv); > +struct iio_dev *devm_iio_device_alloc(struct device *parent, int sizeof_priv); > struct iio_trigger *devm_iio_trigger_alloc(struct device *dev, > const char *fmt, ...); > /** > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel