From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75276C433E0 for ; Tue, 28 Jul 2020 20:03:18 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 488832065C for ; Tue, 28 Jul 2020 20:03:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K7KB80y7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 488832065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0A30E859D2; Tue, 28 Jul 2020 20:03:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5ytwr5cvtvUE; Tue, 28 Jul 2020 20:03:17 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id EDCEE859CF; Tue, 28 Jul 2020 20:03:16 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 49BDC1BF57F for ; Tue, 28 Jul 2020 20:03:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 453D7878F1 for ; Tue, 28 Jul 2020 20:03:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rt5cRDJuUvAj for ; Tue, 28 Jul 2020 20:03:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by whitealder.osuosl.org (Postfix) with ESMTPS id 4468D816FA for ; Tue, 28 Jul 2020 20:03:14 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id r2so14377105wrs.8 for ; Tue, 28 Jul 2020 13:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ohmu0vMfdHex2xZPcqloEiP8YaJLK572pyUwrwcZ6J4=; b=K7KB80y7j7VxdM3l4Ffe2vwCHW7hkhWHpMpHYP8eEB3sm/QGVjG4PlAgSU+RkMzCRR a18FB+5kqWpmo8cUQuDq8FBBInqiTBszV57NxvPeNkiKP6Sn5RImHi8+f96EgBFNj0T5 AdSMifwLG37EskhoPeXKbm57FR6M+6ixA3LY//InU8beSCmXAxbq2vHAvlQ1gDcyyAaS E7bL7mYA0DMpE3y1JHn9LPsnOaH4jghUaNZaWPh3S5URbA1GJT85pglkFYicv0EYxdae 8vcGxjemYAu2Tl7QwfaJKi+aiWou4Lzdx7YL3kOBmRnuUpRc+dI/ZDPAos+bunasKGxK xRsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ohmu0vMfdHex2xZPcqloEiP8YaJLK572pyUwrwcZ6J4=; b=Pk0LYuEOnJiYAnytnCtpvKKMR/6MwmDQ3SSWCGC8hKxNlQidtj8x1pE4vsGEzOdm6i WxTdOXnxoIZiGoC1jb4uMy01FMyPL5VhbOKzQr9z4FQK2VeaccXDt54L+M0mG+Sq8z8q XhDIhbpuJbzjcsJvjEyPRmGRkXYliBeE8CbDgJ5KYHzB8kyGeuWatW1mfgPUnZ4peoQD f+QGkLUASwHKtK5AiiM3sCaD2MpTyE0jRlVLnSrBzUZcUMzdRL0LVRRZvUW3x8O6po5C RzDKMV8xRAvcUw9hgfYmUkDByjJjFc0CyRi/WfsMbWRmx/cS73k53L4uFuSA5jM0wO6N HyVA== X-Gm-Message-State: AOAM531sbdQuIDjm184n+GInb5XPT4yIEfgWnIjz3QV/v+WaTayHNiqQ SomXSzez/+hk4wvG3CIHzBx6rtOBjUvwotyVRGonwnBG X-Google-Smtp-Source: ABdhPJy52DXVGn4HR6bSg2SgU93VxhjyIOqA2rpkG0SEKuDIQOBIQowUnerJP2o1ESdA/mdZ50ZiOfVas6U7logwU80= X-Received: by 2002:adf:dfcf:: with SMTP id q15mr15043913wrn.345.1595966592536; Tue, 28 Jul 2020 13:03:12 -0700 (PDT) MIME-Version: 1.0 References: <20200726141831.2662-1-aditya.jainadityajain.jain@gmail.com> <20200726142013.2891-1-aditya.jainadityajain.jain@gmail.com> <20200726142013.2891-3-aditya.jainadityajain.jain@gmail.com> <20200726150244.GD452766@kroah.com> <1177f80aa848a294f65e305729304b76d1e5ee98.camel@perches.com> In-Reply-To: From: Aditya Jain Date: Wed, 29 Jul 2020 01:33:01 +0530 Message-ID: Subject: Re: [PATCH v3 3/4] staging: rtl8723bs: include: Further clean up function declarations To: Joe Perches X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg KH , Larry Finger , linux-kernel@vger.kernel.org, hdegoede@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, Jul 26, 2020 at 11:45 PM Aditya Jain wrote: > > On Sun, Jul 26, 2020 at 10:45 PM Joe Perches wrote: > > > > On Sun, 2020-07-26 at 17:02 +0200, Greg KH wrote: > > > On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote: > > > > Cleaning up messy multiline function declarations in hal_phy_cfg.h > > [] > > > > diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h > > [] > Ok, I'll merge this patch with the previous one. Had separated the two > to make the diffs smaller thinking they'll > be easier to review. But yeah, I get the point. > > > > -void > > > > -PHY_SetSwChnlBWMode8723B( > > > > -struct adapter *Adapter, > > > > -u8 channel, > > > > -enum CHANNEL_WIDTH Bandwidth, > > > > -u8 Offset40, > > > > -u8 Offset80 > > > > +void PHY_SetBWMode8723B(struct adapter *Adapter, > > > > + enum CHANNEL_WIDTH Bandwidth, /* 20M or 40M */ > > > > + unsigned char Offset /* Upper, Lower, or Don't care */ > > > > > > Those comments should go at the top of the function declaration, in > > > kernel doc format. > > > > Not every external function needs kernel-doc. > > > > This is a realtek staging driver that likely it will never be > > moved out of staging. > > > > > Should I just remove the comments then? Sorry, but I'm a newbie, and > not really sure what the function is or supposed to do. > I can try looking it up if kernel-doc is required here. Hi all, Any directions on how I should continue? > > Regards, > Aditya Jain Thanks and Regards, Aditya Jain _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel