* [PATCH] staging: vc04_service: remove unused header include path
@ 2020-01-04 16:28 Masahiro Yamada
2020-01-10 12:19 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2020-01-04 16:28 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Masahiro Yamada, linux-kernel, bcm-kernel-feedback-list,
linux-arm-kernel, linux-rpi-kernel
I can build drivers/staging/vc04_services without this.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
drivers/staging/vc04_services/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/Makefile b/drivers/staging/vc04_services/Makefile
index afe43fa5a6d7..54d9e2f31916 100644
--- a/drivers/staging/vc04_services/Makefile
+++ b/drivers/staging/vc04_services/Makefile
@@ -13,5 +13,5 @@ vchiq-objs := \
obj-$(CONFIG_SND_BCM2835) += bcm2835-audio/
obj-$(CONFIG_VIDEO_BCM2835) += bcm2835-camera/
-ccflags-y += -Idrivers/staging/vc04_services -D__VCCOREVER__=0x04000000
+ccflags-y += -D__VCCOREVER__=0x04000000
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vc04_service: remove unused header include path
2020-01-04 16:28 [PATCH] staging: vc04_service: remove unused header include path Masahiro Yamada
@ 2020-01-10 12:19 ` Greg Kroah-Hartman
2020-01-10 13:47 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-01-10 12:19 UTC (permalink / raw)
To: Masahiro Yamada
Cc: devel, bcm-kernel-feedback-list, linux-kernel, linux-arm-kernel,
linux-rpi-kernel
On Sun, Jan 05, 2020 at 01:28:29AM +0900, Masahiro Yamada wrote:
> I can build drivers/staging/vc04_services without this.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> drivers/staging/vc04_services/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/Makefile b/drivers/staging/vc04_services/Makefile
> index afe43fa5a6d7..54d9e2f31916 100644
> --- a/drivers/staging/vc04_services/Makefile
> +++ b/drivers/staging/vc04_services/Makefile
> @@ -13,5 +13,5 @@ vchiq-objs := \
> obj-$(CONFIG_SND_BCM2835) += bcm2835-audio/
> obj-$(CONFIG_VIDEO_BCM2835) += bcm2835-camera/
>
> -ccflags-y += -Idrivers/staging/vc04_services -D__VCCOREVER__=0x04000000
> +ccflags-y += -D__VCCOREVER__=0x04000000
>
> --
This patch breaks the build for me:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c:6:10: fatal error: interface/vchi/vchi.h: No such file or directory
6 | #include "interface/vchi/vchi.h"
| ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
So maybe you did't select all of the modules to build?
Sorry, I can't take this as-is :(
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vc04_service: remove unused header include path
2020-01-10 12:19 ` Greg Kroah-Hartman
@ 2020-01-10 13:47 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2020-01-10 13:47 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Broadcom Kernel Feedback List, Linux Kernel Mailing List,
linux-arm-kernel, linux-rpi-kernel
On Fri, Jan 10, 2020 at 9:24 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Sun, Jan 05, 2020 at 01:28:29AM +0900, Masahiro Yamada wrote:
> > I can build drivers/staging/vc04_services without this.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> > drivers/staging/vc04_services/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vc04_services/Makefile b/drivers/staging/vc04_services/Makefile
> > index afe43fa5a6d7..54d9e2f31916 100644
> > --- a/drivers/staging/vc04_services/Makefile
> > +++ b/drivers/staging/vc04_services/Makefile
> > @@ -13,5 +13,5 @@ vchiq-objs := \
> > obj-$(CONFIG_SND_BCM2835) += bcm2835-audio/
> > obj-$(CONFIG_VIDEO_BCM2835) += bcm2835-camera/
> >
> > -ccflags-y += -Idrivers/staging/vc04_services -D__VCCOREVER__=0x04000000
> > +ccflags-y += -D__VCCOREVER__=0x04000000
> >
> > --
>
> This patch breaks the build for me:
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c:6:10: fatal error: interface/vchi/vchi.h: No such file or directory
> 6 | #include "interface/vchi/vchi.h"
> | ^~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
>
> So maybe you did't select all of the modules to build?
>
> Sorry, I can't take this as-is :(
>
> greg k-h
Sorry, I compile-tested it with O= option.
I should have tested it with/without O=
for this kind of patch.
I will fix up some relative paths.
--
Best Regards
Masahiro Yamada
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-10 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-04 16:28 [PATCH] staging: vc04_service: remove unused header include path Masahiro Yamada
2020-01-10 12:19 ` Greg Kroah-Hartman
2020-01-10 13:47 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).