From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5797C433E3 for ; Mon, 29 Mar 2021 18:02:51 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14AEC619BD for ; Mon, 29 Mar 2021 18:02:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14AEC619BD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9953060714; Mon, 29 Mar 2021 18:02:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LHJwP4_kR24X; Mon, 29 Mar 2021 18:02:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 853596072A; Mon, 29 Mar 2021 18:02:49 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 6E7661BF9C8 for ; Mon, 29 Mar 2021 18:02:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5BEF84032E for ; Mon, 29 Mar 2021 18:02:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=poorly.run Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Szu7iwBJjcOi for ; Mon, 29 Mar 2021 18:02:46 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by smtp4.osuosl.org (Postfix) with ESMTPS id E8B2340321 for ; Mon, 29 Mar 2021 18:02:45 +0000 (UTC) Received: by mail-io1-xd34.google.com with SMTP id n198so13739554iod.0 for ; Mon, 29 Mar 2021 11:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Au5y7OoRawkUEJFPbHpW7802nDwRo0nj5nxIyw0Dfa8=; b=Zyv3esmbX3USPfY9NAG7q5qJ25C5cUmKUK84xtlRwZWvmEl9I9Vqc5cxJLsk1TUGi2 MHGmzk+I9z1q7ecO1VPAa36DUoII1M34Y5/YSt73CTOgG2rthe8T+jq+pM+TT+wZ/ouH wMDgcJ7f8eOshtxjUXzmZ8WIqfIJyGirgIKQ66p9iWswBXj2B+Cdaff6XyJ3OyCeiqR/ R1CRqn/hHZAOAEOFQoDV936hEf9CcA2fqSS7viWb85sEjL1LveJTJQkbxoO10OIgo98T oJOqBG0G/D261zEsXroGXVguWv00cRCPbeGpnOpJtvg4yLd69XejIXoU5GJNJxjD64P/ VA6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Au5y7OoRawkUEJFPbHpW7802nDwRo0nj5nxIyw0Dfa8=; b=s1DtVVtWcEWqNOJLJCIt20J8MqnUqGpZ/2c/b5CIkcR4qaSZ8HOt2QJK4B59MV01L8 hcmmFficlRzWbK1Fvx+4dtf/0HCV+UgOO1YWfQg3iLG4Ttt5u3Uia2BNin4pGmY9fcHd WTSWacwU4CQ02kETfbHxLEuMqQ4FudXmwTaBANFwhw6Rzckhxm8/uLcxl8ZVAgh+s7d3 kSAnLextoqzCOaMFD/py8z0yn/fr2FG6keih823QDumfQ/Rh4Og95DVHldCl6vsiKNJP w6mUTIsLjwQ14bQQ+AVrgWBSMn/96i3jWLwzM7WttdN6DDu3g6ZhTBkethqUjcifplKz dLQg== X-Gm-Message-State: AOAM530O0+fQGeQ088k+I5Xsy8bSZvf+dKyzriX7WsbX0LDCVVWui9tL 6lV1LZxMInI5Lb7xtBT4Jb8dRDFRwgPYrWGRXPJojg== X-Google-Smtp-Source: ABdhPJxZkJRqw/QeGv+RrSKRBGLc4oFkV6J1+/TGuuqVGXQHnaoEB7kMLbeNK26s3AKHKzDMmyeObLY3VW0lugoGEc8= X-Received: by 2002:a05:6602:1c9:: with SMTP id w9mr20873871iot.201.1617040964939; Mon, 29 Mar 2021 11:02:44 -0700 (PDT) MIME-Version: 1.0 References: <189a637c87827f78c433a053e3c2129ebec73188.1616135353.git.xji@analogixsemi.com> <20210329102710.GA1930154@anxtwsw-Precision-3640-Tower> In-Reply-To: <20210329102710.GA1930154@anxtwsw-Precision-3640-Tower> From: Sean Paul Date: Mon, 29 Mar 2021 14:02:08 -0400 Message-ID: Subject: Re: [PATCH v6 4/5] drm/bridge: anx7625: add HDCP support To: Xin Ji X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Nicolas Boichat , Jernej Skrabec , Sam Ravnborg , Jonas Karlman , David Airlie , Zhen Li , dri-devel , Neil Armstrong , LKML , Foss , Vasily Khoruzhick , Andrzej Hajda , Boris Brezillon , Torsten Duwe , Sheng Pan , Hsin-Yi Wang , Marek Szyprowski , Bernie Liang , Dan Carpenter , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, Mar 29, 2021 at 6:27 AM Xin Ji wrote: > > On Thu, Mar 25, 2021 at 02:19:23PM -0400, Sean Paul wrote: > > On Fri, Mar 19, 2021 at 2:35 AM Xin Ji wrote: > > > > > > Add HDCP feature, enable HDCP function through chip internal key > > > and downstream's capability. > > > > > > Signed-off-by: Xin Ji > > > --- /snip > > > static void anx7625_dp_start(struct anx7625_data *ctx) > > > { > > > int ret; > > > @@ -643,6 +787,9 @@ static void anx7625_dp_start(struct anx7625_data *ctx) > > > return; > > > } > > > > > > + /* HDCP config */ > > > + anx7625_hdcp_setting(ctx); > > > > You should really use the "Content Protection" property to > > enable/disable HDCP instead of force-enabling it at all times. > > > > Sean > Hi Sean, it's hard to implement "Content Protection" property, we have > implemented HDCP in firmware, it is not compatible with it. We don't > have interface to get Downstream Cert. > Thanks, > Xin Hi Xin, I'm sorry, I don't understand what you mean when you say you don't have an interface to get Downstream Cert. The Content Protection property is just a means through which userspace can turn on and turn off HDCP when it needs. As far as I can tell, your patch turns on HDCP when the display is enabled and leaves it on until it is disabled. This is undesirable since it forces HDCP on the user. Is it impossible to enable/disable HDCP outside of display enable/disable on your hardware? Thanks, Sean > > > > > + > > > if (ctx->pdata.is_dpi) > > > ret = anx7625_dpi_config(ctx); > > > else /snip _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel