From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B46CEC4332E for ; Sat, 21 Mar 2020 07:28:15 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8468B2072C for ; Sat, 21 Mar 2020 07:28:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D+drk0+F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8468B2072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 57C692154E; Sat, 21 Mar 2020 07:28:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7wapg0AwBpA9; Sat, 21 Mar 2020 07:28:14 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 46CFF2152C; Sat, 21 Mar 2020 07:28:14 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 53B2D1BF2B9 for ; Sat, 21 Mar 2020 07:28:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4FB792152C for ; Sat, 21 Mar 2020 07:28:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8FXd1Njrlm9i for ; Sat, 21 Mar 2020 07:28:12 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by silver.osuosl.org (Postfix) with ESMTPS id 5A9FF2078B for ; Sat, 21 Mar 2020 07:28:12 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id a49so8325095otc.11 for ; Sat, 21 Mar 2020 00:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ehmxsElx8JC4+OTBkwJv81nkSr8Vpt5h0hNdNvgDzB8=; b=D+drk0+FSDXYLQttkSOz4WWJlscrl2SpQlDWNqJNDIGr/zWmt0G2yZzYpO9yhh+qEV qWzLHbpjKmDGy/dJQupxoLy07Wu7s3dUzfbpCpqBkiYIzCjAqZE4x126MuxP8pFzlSz+ 4Hzh3409zN//LKDifyNzSRDq4ZC7sEO7S/3sV6cH1aZGM5ih2nq52Y8PuLTsNuTHNhep pXyMiQgJ2lK+2BmX88D12q8LjuVP8YQYrJy2Ya0oLTtRfi6vooq74nO7YUrZBJcEAEFo koXQTw8nipymNqwzhPbjXvhvjFaeLf2RSoPanEWlHDrPNivNR07leGx3qFwfUcHOtzi+ u5KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ehmxsElx8JC4+OTBkwJv81nkSr8Vpt5h0hNdNvgDzB8=; b=jy/XRgDFTrIseN0i2TFuWuKKiZOEXj/MtK/cs6lM+lteEYnNEQZHGHDN83sJ/7YOq7 JTuNxhb4GHuRKboq6OhAzmhCNNEkNwc7/7qcMGpd2C4pFlY2CnE7akZjVljiCiHc4tLm HN00u+jG6paB5j9TB6cBsEY+wuW0GDifQpPf4A6Uep1xy6chkV+CFIMOK1HeXnxxb7v8 cZmWK99Uhd4SeHJaCY6Rnmzow3Pe8fTrw77yCfNesXrnigJRoaKkLCuAwmxg9fssgQSX JlbnPD6I6P5afxn9V80SBAatIUyHU62vqRq8Yobqfi7LfqwZ7JudAXHvqD+xrCa37lTy NinA== X-Gm-Message-State: ANhLgQ0aVkE93cOnI5cTbgAk/rRv2APdWM6P/SrfhwA6Vd4JEI55xPNn 6P7P6n9pHQE7RGK2DcE1QlieP20F4YQeCO7ZRzEGL/V/ X-Google-Smtp-Source: ADFU+vtyOyC/eqr/jPVd00MkaLdk/9M4jPOujjkMpnGVkn604ntMVCfBROCGXbA+MtZ+6hBazrzT95hBdZz4hJAYdTQ= X-Received: by 2002:a05:6830:3151:: with SMTP id c17mr10626266ots.310.1584775691484; Sat, 21 Mar 2020 00:28:11 -0700 (PDT) MIME-Version: 1.0 References: <20200313200913.24321-1-sergio.paracuellos@gmail.com> <20200313200913.24321-6-sergio.paracuellos@gmail.com> In-Reply-To: From: Sergio Paracuellos Date: Sat, 21 Mar 2020 08:28:00 +0100 Message-ID: Subject: Re: [PATCH v4 5/6] staging: mt7621-pci: release gpios after pci initialization To: Chuanhong Guo X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ryder.lee@mediatek.com, Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, weijie.gao@mediatek.com, Greg Ungerer , NeilBrown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi, On Sat, Mar 21, 2020 at 7:36 AM Chuanhong Guo wrote: > > Hi! > > On Sat, Mar 21, 2020 at 12:34 AM Sergio Paracuellos > wrote: > > > If I am understanding correctly for example for my gnubee this should > > > be as follows: > > > > > > diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi > > > b/drivers/staging/mt7621-dts/mt7621.dtsi > > > index 10fb497cf81a..9e5cf68731bb 100644 > > > --- a/drivers/staging/mt7621-dts/mt7621.dtsi > > > +++ b/drivers/staging/mt7621-dts/mt7621.dtsi > > > @@ -538,9 +538,7 @@ pcie: pcie@1e140000 { > > > phys = <&pcie0_phy 1>, <&pcie2_phy 0>; > > > phy-names = "pcie-phy0", "pcie-phy2"; > > > > > > - reset-gpios = <&gpio 19 GPIO_ACTIVE_LOW>, > > > - <&gpio 8 GPIO_ACTIVE_LOW>, > > > - <&gpio 7 GPIO_ACTIVE_LOW>; > > > + reset-gpios = <&gpio 19 GPIO_ACTIVE_LOW>; > > > > > > pcie@0,0 { > > > reg = <0x0000 0 0 0 0>; > > > sergio@camaron:~/staging$ git diff drivers/staging/mt7621-dts/gbpc1.dts > > > diff --git a/drivers/staging/mt7621-dts/gbpc1.dts > > > b/drivers/staging/mt7621-dts/gbpc1.dts > > > index 1fb560ff059c..a7c0d3115d72 100644 > > > --- a/drivers/staging/mt7621-dts/gbpc1.dts > > > +++ b/drivers/staging/mt7621-dts/gbpc1.dts > > > @@ -114,6 +114,10 @@ &cpuclock { > > > &pcie { > > > pinctrl-names = "default"; > > > pinctrl-0 = <&pcie_pins>; > > > + > > > + reset-gpios = <&gpio 19 GPIO_ACTIVE_LOW>, > > > + <&gpio 8 GPIO_ACTIVE_LOW>, > > > + <&gpio 7 GPIO_ACTIVE_LOW>; > > > status = "okay"; > > > }; > > > > > > Is this true? So changes will be only in the device tree but driver is > > > ok as it is. > > > > Well, I mean I should only remove the release part for gpios, right? > > Correct :) Thanks for let me know the correct way of doing this. Sent: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2020-March/142567.html > > -- > Regards, > Chuanhong Guo Best regards, Sergio Paracuellos _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel