From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EE91C4332D for ; Fri, 20 Mar 2020 15:26:33 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63EDC20732 for ; Fri, 20 Mar 2020 15:26:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JOh/KSaN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63EDC20732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3F01687F39; Fri, 20 Mar 2020 15:26:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pJGfquhSqGrS; Fri, 20 Mar 2020 15:26:32 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id F13D187683; Fri, 20 Mar 2020 15:26:31 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id C5A0D1BF32C for ; Fri, 20 Mar 2020 15:26:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B60582548F for ; Fri, 20 Mar 2020 15:26:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GjmihXC7Yq-O for ; Fri, 20 Mar 2020 15:26:27 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by silver.osuosl.org (Postfix) with ESMTPS id BBC8D2744E for ; Fri, 20 Mar 2020 15:25:55 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id j16so6348948otl.1 for ; Fri, 20 Mar 2020 08:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fcmiFpau/Mibr8UDcpl4cmStp4t65arXPe+5p+Ecxyc=; b=JOh/KSaNr3a5T/0RW/8TuY4S7qmYlzsMxBts8FfjzGGRG1JFGN3vhZEACztYhuUhOt NGS7AIyt91zSV+tKtM37UqP0HkswhDP3FPKWQXZUZtIR35DAzhNdBrpe2fFzwtPlFXMt d+4sLVztYI92Bjv3fWBcK1xURw2f2LyXzmF+INvNCVyb5hz/s/ZWglkfSKI5dMXz2KLu lR5bXFikt41RseN0JjDaKBJsy2TC/kxaXD5xt2qepfmuKr4FwbynurPS0Jw/HDCLeXIu qd6h4DYljRbuMp0jFth1vpJw1UxC9NoI6bJxYI8hUO5da/iER1rJjV2U/dZkHQkE7DNV RbBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fcmiFpau/Mibr8UDcpl4cmStp4t65arXPe+5p+Ecxyc=; b=GbphKuXIZlUVyhrhS1yl61/OfHbGPr/zOAxaaGBQxvB0jLowSC2rp37BNSRIc7uuFx nPYiVw8yBVy+clFrz+2CGubx9rWwx9p877NsvxatgbHNf+JhWXaVG1DiJTktDLtTp+aT /j4rabcDx0mWqnE6At0kvPV1lVxT7L8bf39ay1k3+R8GHSlZIUZiocBKdhsSvI7+hlQj 3FPbhF/Ct9N7Dr6TSoYT4E2E6R7mkJaRnBcWyS0aoUa86XUDhrl1jmLS9s307SS8kluz 66EMpHiN2SzuQo5ZTis71ElMkFSyTLNeRXD/Ef7cpIAHfSqCmrKA0fqAfkZwUtveFhzg rd3w== X-Gm-Message-State: ANhLgQ2VsTrggBxX7gz3xem+ty7ySwK+elxX9bWPU4Z3S6Spy0JruTF6 B4jAwHUuG+HwzlJqDlfGz4pqw49xki3zXXvlHbs= X-Google-Smtp-Source: ADFU+vtQqYVDfsKzoDx7ZFghoPq+G4P9ydKXNBpIejnZFd2gq9WUmrCd6ISyo4SPQmmKaw9UAxoCzLgYw5Whv3KMsFU= X-Received: by 2002:a05:6830:1498:: with SMTP id s24mr6943980otq.242.1584717954874; Fri, 20 Mar 2020 08:25:54 -0700 (PDT) MIME-Version: 1.0 References: <20200319161416.19033-1-sergio.paracuellos@gmail.com> <76db8f45-2a78-fb40-0c0d-4ff17a224e1b@kernel.org> <42663980-a1e1-c19b-cc2d-1be3782e5cdc@kernel.org> In-Reply-To: <42663980-a1e1-c19b-cc2d-1be3782e5cdc@kernel.org> From: Sergio Paracuellos Date: Fri, 20 Mar 2020 16:25:42 +0100 Message-ID: Subject: Re: [PATCH] staging: mt7621-pci: don't return if get gpio fails To: Greg Ungerer X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: NeilBrown , Greg KH , driverdev-devel@linuxdriverproject.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Greg, On Fri, Mar 20, 2020 at 4:08 PM Greg Ungerer wrote: > > Hi Sergio, > > On 21/3/20 12:38 am, Sergio Paracuellos wrote: > > On Fri, Mar 20, 2020 at 3:30 PM Greg Ungerer wrote: > >> On 20/3/20 2:14 am, Sergio Paracuellos wrote: > [snip] > >> rt2880-pinmux pinctrl: pcie is already enabled > >> mt7621-pci 1e140000.pcie: Error applying setting, reverse things back > >> mt7621-pci-phy 1e149000.pcie-phy: Xtal is 40MHz > >> mt7621-pci-phy 1e149000.pcie-phy: Xtal is 40MHz > >> mt7621-pci-phy 1e14a000.pcie-phy: Xtal is 40MHz > >> mt7621-pci 1e140000.pcie: pcie0 no card, disable it (RST & CLK) > >> mt7621-pci 1e140000.pcie: pcie1 no card, disable it (RST & CLK) > >> mt7621-pci 1e140000.pcie: pcie2 no card, disable it (RST & CLK) > >> mt7621-pci 1e140000.pcie: Nothing is connected in virtual bridges. Exiting.. > >> ... > >> > >> It is probably 50:50 on any boot whether it will probe pci successfully or > >> fail to probe it. > >> > >> BTW, this is with the patch here applied: > >> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2020-March/142472.html > > > > Yes this is the behaviour I was talking about in this series: > > > > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2020-March/142520.html > > > > These patches have been already added to staging-testing and should > > work and found properly ports also for you. > > > > Let me know any issue you might find. > > Ok, I am testing now a fresh up-to-date staging-testing. > I can see your most recent patches for the pci-phy at the top of the git log. > No other patches applied (just my devicetree for my hardware). > > It dumps on every boot with: > > ... > rt2880-pinmux pinctrl: pcie is already enabled > mt7621-pci 1e140000.pcie: Error applying setting, reverse things back > mt7621-pci-phy 1e149000.pcie-phy: PHY for 0xbe149000 (dual port = 1) > mt7621-pci-phy 1e14a000.pcie-phy: PHY for 0xbe14a000 (dual port = 0) > mt7621-pci-phy 1e149000.pcie-phy: Xtal is 40MHz > mt7621-pci-phy 1e14a000.pcie-phy: Xtal is 40MHz > mt7621-pci 1e140000.pcie: pcie1 no card, disable it (RST & CLK) > Unhandled kernel unaligned access[#1]: > CPU: 3 PID: 111 Comm: kworker/3:2 Not tainted 5.6.0-rc3-00347-g825c6f470c62-dirty #9 > Workqueue: events deferred_probe_work_func > $ 0 : 00000000 00000001 5f60d043 8fe1ba80 > $ 4 : 0000010d 01eb9000 00000000 00000000 > $ 8 : 294b4c00 80940000 00000008 000000ce > $12 : 2e303030 00000000 00000000 65696370 > $16 : ffffffed 0000010d 8e373cd0 8214c1e0 > $20 : 00000000 82144c80 82144680 8214c250 > $24 : 00000018 803ef8f4 > $28 : 8e372000 8e373c60 8214c080 803940e8 > Hi : 00000125 > Lo : 122f2000 > epc : 807b3328 mutex_lock+0x8/0x44 > ra : 803940e8 phy_power_off+0x28/0xb0 > Status: 1100fc03 KERNEL EXL IE > Cause : 00800010 (ExcCode 04) > BadVA : 0000010d > PrId : 0001992f (MIPS 1004Kc) > Modules linked in: > Process kworker/3:2 (pid: 111, threadinfo=(ptrval), task=(ptrval), tls=00000000) > Stack : 8e373cd0 803fe4f4 8e372000 8e373c90 8214c080 804fde1c 8e373c98 808d62f4 > 8e373c78 00000000 8214c254 804fe648 1e160000 804f27b8 00000001 808d62f4 > 00000000 00000001 8214c228 808d62f4 80930000 809a0000 8fd47e10 808d63d4 > 808d62d4 8fd47e10 808d0000 808d0000 8e373cd0 8e373cd0 809e2a74 809db510 > 809db510 00000006 00000001 00000000 00000000 00000000 01000000 1e1440ff > ... > Call Trace: > [<807b3328>] mutex_lock+0x8/0x44 > [<803940e8>] phy_power_off+0x28/0xb0 > [<804fe648>] mt7621_pci_probe+0xc20/0xd18 > [<80402ab8>] platform_drv_probe+0x40/0x94 > [<80400a74>] really_probe+0x104/0x364 > [<803feb74>] bus_for_each_drv+0x84/0xdc > [<80400924>] __device_attach+0xdc/0x120 > [<803ffb5c>] bus_probe_device+0xa0/0xbc > [<80400124>] deferred_probe_work_func+0x7c/0xbc > [<800420e8>] process_one_work+0x230/0x450 > [<80042638>] worker_thread+0x330/0x5fc > [<80048eb0>] kthread+0x12c/0x134 > [<80007438>] ret_from_kernel_thread+0x14/0x1c > Code: 24050002 27bdfff8 8f830000 14a00005 00000000 00600825 e0810000 1020fffa > Ok, this seems to be the access for slot 1 which I default set to true as enabled ports because of the phy is for dual_port, so because you are using only one of the two ports the phy_power_off(port->phy); for slot 1 should not be triggered because it is done for slot 0 if neccessary. Can you try this small fix: diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c index 739504f7e4fc..23b51789f72e 100644 --- a/drivers/staging/mt7621-pci/pci-mt7621.c +++ b/drivers/staging/mt7621-pci/pci-mt7621.c @@ -517,7 +517,8 @@ static void mt7621_pcie_init_ports(struct mt7621_pcie *pcie) if (!mt7621_pcie_port_is_linkup(port)) { dev_err(dev, "pcie%d no card, disable it (RST & CLK)\n", slot); - phy_power_off(port->phy); + if (slot != 1) + phy_power_off(port->phy); mt7621_control_assert(port); mt7621_pcie_port_clk_disable(port); port->enabled = false; > ---[ end trace 8e3fadee03559cba ]--- > > Regards > Greg Regards, Sergio Paracuellos > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel