From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48AF2C4332E for ; Fri, 20 Mar 2020 09:10:49 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2751820752 for ; Fri, 20 Mar 2020 09:10:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2751820752 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id EFC0F889C0; Fri, 20 Mar 2020 09:10:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iTWeZe-VDaby; Fri, 20 Mar 2020 09:10:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 6C53E889FE; Fri, 20 Mar 2020 09:10:48 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id B31E71BF2E5 for ; Fri, 20 Mar 2020 09:10:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id AECE524DFD for ; Fri, 20 Mar 2020 09:10:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EG5sjvL6QOUe for ; Fri, 20 Mar 2020 09:10:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by silver.osuosl.org (Postfix) with ESMTPS id E4F55227F7 for ; Fri, 20 Mar 2020 09:10:45 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id t28so5287072ott.5 for ; Fri, 20 Mar 2020 02:10:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Tg5BjS+sqoKmcQ+42q9TxLcAJmVp9TX8V+2Cw9tSbTc=; b=gJA8nCJD6g35iDe5bqnP/OhCnDEcNpZesTNBxas2PzD+Uqw8kyMgMz0xA9oGQrzmdV F/2iMXLdao6hrfIVkklVGUptz+YHNBjtT3FSQbOlQs4QvzEG7YTlj1XOz2DQx5juMAXm XZ0cL1kNHkWz5evHBlI33cXLtUEP57qxK3zHMhfRhVQPrrG9KnxMdd4bvoqWGPaTfoCO hV97rqAh6rtHFcCoufjk/NoyzGfeSwmZUjP8sidyCPlQqPF73C6z8SYnUjKURGMPivS+ CiChthAUdkWRb+EFZd0flPSzFFCe8Nvy/JV4lNfPWu3ANwgdNCSxFCPbOsegonub0Hf+ SSwQ== X-Gm-Message-State: ANhLgQ2/C+G8SJM2MvcxdosdJoFkcvRewRXxc5e9tmj2TVj+N8rz/9Ow pb8ky49D5LL9z0cSxvhCN1X//TWBOavXkdBHC2A= X-Google-Smtp-Source: ADFU+vsUtq7aKxlPk7a6wmuKLwOjxCxHK6YYdo8yUXNmA1Av41cm11S+ggWl9zkA56I5lN+TzJt+7vYyBdanbV3/AIo= X-Received: by 2002:a9d:5c0c:: with SMTP id o12mr5844474otk.145.1584695445126; Fri, 20 Mar 2020 02:10:45 -0700 (PDT) MIME-Version: 1.0 References: <252bb433f47b0ccb61bb077abdbd892091abc550.1584639664.git.alexander.riesen@cetitec.com> <20200320085748.GC4344@pflmari> In-Reply-To: <20200320085748.GC4344@pflmari> From: Geert Uytterhoeven Date: Fri, 20 Mar 2020 10:10:24 +0100 Message-ID: Subject: Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio To: Alex Riesen , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , driverdevel , Linux Media Mailing List , Linux Kernel Mailing List , Device Tree Mailing List , Linux-Renesas , linux-clk X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Alex, On Fri, Mar 20, 2020 at 9:58 AM Alex Riesen wrote: > Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100: > > > +int adv748x_dai_init(struct adv748x_dai *dai) > > > +{ > > > + int ret; > > > + struct adv748x_state *state = adv748x_dai_to_state(dai); > > > + > > > + dai->mclk = clk_register_fixed_rate(state->dev, > > > + "adv748x-hdmi-i2s-mclk", > > > > I assume there can be multiple adv748x instances in the system? > > Hence the clock name should be unique for each instance. > > I think that can happen. > > Is it alright to derive the clock name from the device name? E.g.: > adv748x.4-0070-mclk? Where "adv748x.4-0070" is a struct device->name. Yes, that's the idea. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel