From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0985AC43331 for ; Thu, 2 Apr 2020 15:26:38 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6FD020675 for ; Thu, 2 Apr 2020 15:26:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6FD020675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id A96D287DDE; Thu, 2 Apr 2020 15:26:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pgjwHpN9nzIS; Thu, 2 Apr 2020 15:26:37 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 20D8887D6C; Thu, 2 Apr 2020 15:26:37 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id A74501BF592 for ; Thu, 2 Apr 2020 15:26:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 9F37887D41 for ; Thu, 2 Apr 2020 15:26:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rrY0wZOiHHIE for ; Thu, 2 Apr 2020 15:26:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by hemlock.osuosl.org (Postfix) with ESMTPS id 9B2CE87C70 for ; Thu, 2 Apr 2020 15:26:28 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id g23so3823953otq.4 for ; Thu, 02 Apr 2020 08:26:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Cqw6dnlRH1Z235Qgu5cq2jTZRWby77FH7SYPVq5JKBY=; b=jf4AgqLFbFPwxpNcTD6q3tEKvvj6wiWVEwCMv15sN3iJVbP3LBEFra220/nUio+I3z +fGiWNyoAX6fO/hFczcpvfCw7/BPFW43hE5bYpyfv/WtvVJFROqmiase3AoUJ1tE7Jhe V/X23az3efpF4DaLg8uidPhAU0dFr/4jLthHfxaxEdaemMDaaj7GxtweP/IOOnuj9666 JxgfSitrSuZtrbkEz/n62hXmF1tfe22xrG5WKfVwcNH0EMKb5m/4q+Wtdu3QZ91SFuvo 7tte0j6oQRIiTgjUat5WuGTMk+zCv1Saw6QBf1MnODAUJBL2Y7R74/P2N0GCy+jWx1G/ nMqQ== X-Gm-Message-State: AGi0PuaaKgvjdMaTQxtxMj9K0fTiaGczaUgmoWtHmUmDc6hBRHLjvaLp IvpTfCc9qAk4X2vVKzQxLQQMuUVlKNXSintUoPA= X-Google-Smtp-Source: APiQypKpY9WpXH7nOqTR0dBL+FBpHDPCUuTtOLsWZcfUeGr3r0SvTBjAnlsfhR6ZMs2a4cWyEgqEHDrB1c5wAgPfOWA= X-Received: by 2002:a4a:e495:: with SMTP id s21mr3164931oov.79.1585841187762; Thu, 02 Apr 2020 08:26:27 -0700 (PDT) MIME-Version: 1.0 References: <20200402141654.GB4291@pflmari> In-Reply-To: <20200402141654.GB4291@pflmari> From: Geert Uytterhoeven Date: Thu, 2 Apr 2020 17:26:15 +0200 Message-ID: Subject: Re: [PATCH v4 9/9] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC To: Alex Riesen , Geert Uytterhoeven , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , driverdevel , Linux Media Mailing List , Linux Kernel Mailing List , OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Linux-Renesas X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Alex, On Thu, Apr 2, 2020 at 5:03 PM Alex Riesen wrote: > Geert Uytterhoeven, Mon, Mar 30, 2020 10:32:47 +0200: > > On Thu, Mar 26, 2020 at 11:55 AM Alex Riesen wrote: > > > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > > > @@ -510,6 +511,15 @@ adv7482_txb: endpoint { > > > remote-endpoint = <&csi20_in>; > > > }; > > > }; > > > + > > > + port@c { > > > + reg = <12>; > > > + > > > + adv7482_i2s: endpoint { > > > + remote-endpoint = <&rsnd_endpoint3>; > > > + system-clock-direction-out; > > > + }; > > > + }; > > > > As the adv748x driver just ignores "invalid" endpoints... > > > > > @@ -758,8 +769,19 @@ &rcar_sound { > > > <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, > > > <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, > > > <&audio_clk_a>, <&cs2000>, > > > - <&audio_clk_c>, > > > + <&adv7482_hdmi_in>, > > > <&cpg CPG_CORE CPG_AUDIO_CLK_I>; > > > > ... and the rsnd driver ignores nonexistent-clocks, the DT change has no > > hard dependency on the driver change, and won't introduce regressions > > when included, right? > > Well, it maybe won't, but isn't it a little ... implicit? > And I'm no haste to include the changes, if you mean I can (or should) submit > the device tree patch separately. OK, fine for me to postpone (that'll be for v5.9, I guess?). > > > @@ -777,6 +799,21 @@ rsnd_endpoint0: endpoint { > > > capture = <&ssi1 &src1 &dvc1>; > > > }; > > > }; > > > + rsnd_port3: port@3 { > > > + reg = <3>; > > > + rsnd_endpoint3: endpoint { > > > + remote-endpoint = <&adv7482_i2s>; > > > + > > > + dai-tdm-slot-num = <8>; > > > + dai-tdm-slot-width = <32>; > > > + dai-format = "left_j"; > > > + mclk-fs = <256>; > > > + bitclock-master = <&adv7482_i2s>; > > > + frame-master = <&adv7482_i2s>; > > > + > > > + capture = <&ssi4>; > > > + }; > > > + }; > > > }; > > > }; > > > > However, as salvator-common.dtsi is shared by all Salvator-X(S) variants, > > you'll have to add a dummy ssi4 node to r8a77961.dtsi first. > > I see. There are even two dummy SSI nodes already. I would prefer to submit > the change together with other Salvator device tree changes. Is that alright? Fine for me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel