From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F231AC4741F for ; Thu, 5 Nov 2020 10:57:19 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68C8A20729 for ; Thu, 5 Nov 2020 10:57:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sMrO9GRU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68C8A20729 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id C4C07870C8; Thu, 5 Nov 2020 10:57:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GLSsdkX9P7Tt; Thu, 5 Nov 2020 10:57:17 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 485C0870C1; Thu, 5 Nov 2020 10:57:17 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 510FF1BF575 for ; Thu, 5 Nov 2020 10:57:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3F4A522E20 for ; Thu, 5 Nov 2020 10:57:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IRB3RcF-2-GL for ; Thu, 5 Nov 2020 10:57:15 +0000 (UTC) X-Greylist: delayed 00:22:11 by SQLgrey-1.7.6 Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by silver.osuosl.org (Postfix) with ESMTPS id F381C22D33 for ; Thu, 5 Nov 2020 10:57:14 +0000 (UTC) Received: by mail-vs1-f66.google.com with SMTP id b3so520045vsc.5 for ; Thu, 05 Nov 2020 02:57:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NZmePoLLIiaP7pYwZl5Ym7F23h4GkDT/CkXYHiP4lxo=; b=sMrO9GRUiQTa3qJHIC5F27I3pHGV5/pX9nBuQ9TmRTxE01Ehxii8CB9TiezKwc2tYJ 3SHV/Rhxs7BmoKB4aJ9W24W7rjat8dvXU+F20+lfe5dyWM1qwmiRT2/Hz4E+yVMLYnPt b7MnO/qq1/9P+on1rkNYRYvwC+wu1WaH12rx3rIlc9KubXnGg8K8RqrwvSVobVT1eBhL S5jUjJHcPKtkeDXyshEdMUlmsFSrn0JHuPLo57AVegznV5Ma/kMzEcO9yRsB/eDD9c8G VI/lxjTY1cQzy9HDsuMni9iMjRs1YrWj3PYOnqX2Fk0T+EROO60K2racmtEoxOny53Bc Vckg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NZmePoLLIiaP7pYwZl5Ym7F23h4GkDT/CkXYHiP4lxo=; b=kqzqRRUu9OnyG/5VdEodWJXi13LXvnK6BM2iYQL0Y8GKNZLvGeCchtFzdZI/LYbiZd 4RtHVWeTJh5iTMCw6qK2jI0eEd1SetDod6y8+gNzkYwSqHk/LmOakU+7B3wQWhmhAWBl B6jSw0VdvSvtjV6I704ncOHPcwRCF+VxPp3ZcPNRgkABlnZacsLQPN4SBkRNSutJ4O9n CJ4eGcOUZ5+l9Ms0GlpYCouhNgbwyzK0RsC4IkXJf5ZxHGzuwo/e+Ia7W9zFtpY0ahLM iUKQkvISA6gt+PiHu3rPhK2jrb4RIYUwaLyPEXVjmcCcIVW9B2KSIH6QZJYBN2o4yb84 rndg== X-Gm-Message-State: AOAM530SZPMqQkqeUgB9MncLI/HXFwpvUtyHbebxI/4XMAlYeCPOY5pR /CvyyKsJV0U9Z455W66Nzx79JovTYLZZgYC8DquukA== X-Google-Smtp-Source: ABdhPJxaRHBJV2RUrIs2kqpAdWFFr8Yx3RVQqbiDwrHCSiI8zLcVccVJz2D9BrdKdQ25WwGzjdkbJ1OYioX7LFmCPEw= X-Received: by 2002:a67:310d:: with SMTP id x13mr785780vsx.19.1604573833960; Thu, 05 Nov 2020 02:57:13 -0800 (PST) MIME-Version: 1.0 References: <20201104234427.26477-1-digetx@gmail.com> <20201105100603.skrirm7uke4s2xyl@vireshk-i7> <20201105104009.oo4dc6a2gdcwduhk@vireshk-i7> In-Reply-To: <20201105104009.oo4dc6a2gdcwduhk@vireshk-i7> From: Ulf Hansson Date: Thu, 5 Nov 2020 11:56:37 +0100 Message-ID: Subject: Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs To: Viresh Kumar X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , DTML , dri-devel , Adrian Hunter , Thierry Reding , Dmitry Osipenko , Lee Jones , Marek Szyprowski , driverdevel , linux-samsung-soc , Nicolas Chauvet , Krzysztof Kozlowski , Jonathan Hunter , Alan Stern , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Linux Media Mailing List , linux-pwm@vger.kernel.org, Mark Brown , linux-tegra , Mauro Carvalho Chehab , Greg Kroah-Hartman , Linux USB List , "linux-mmc@vger.kernel.org" , Liam Girdwood , Linux Kernel Mailing List , Rob Herring , Peter Geis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, 5 Nov 2020 at 11:40, Viresh Kumar wrote: > > On 05-11-20, 11:34, Ulf Hansson wrote: > > I am not objecting about scaling the voltage through a regulator, > > that's fine to me. However, encoding a power domain as a regulator > > (even if it may seem like a regulator) isn't. Well, unless Mark Brown > > has changed his mind about this. > > > > In this case, it seems like the regulator supply belongs in the > > description of the power domain provider. > > Okay, I wasn't sure if it is a power domain or a regulator here. Btw, > how do we identify if it is a power domain or a regulator ? Good question. It's not a crystal clear line in between them, I think. A power domain to me, means that some part of a silicon (a group of controllers or just a single piece, for example) needs some kind of resource (typically a power rail) to be enabled to be functional, to start with. If there are operating points involved, that's also a clear indication to me, that it's not a regular regulator. Maybe we should try to specify this more exactly in some documentation, somewhere. > > > > In case of Qcom earlier (when we added the performance-state stuff), > > > the eventual hardware was out of kernel's control and we didn't wanted > > > (allowed) to model it as a virtual regulator just to pass the votes to > > > the RPM. And so we did what we did. > > > > > > But if the hardware (where the voltage is required to be changed) is > > > indeed a regulator and is modeled as one, then what Dmitry has done > > > looks okay. i.e. add a supply in the device's node and microvolt > > > property in the DT entries. > > > > I guess I haven't paid enough attention how power domain regulators > > are being described then. I was under the impression that the CPUfreq > > case was a bit specific - and we had legacy bindings to stick with. > > > > Can you point me to some other existing examples of where power domain > > regulators are specified as a regulator in each device's node? > > No, I thought it is a regulator here and not a power domain. Okay, thanks! Kind regards Uffe _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel