From: Dan Carpenter <dan.carpenter@oracle.com> To: Ian Abbott <abbotti@mev.co.uk>, Al Viro <viro@zeniv.linux.org.uk> Cc: devel@driverdev.osuosl.org, Xin Tan <tanxin.ctf@gmail.com>, Xiyu Yang <xiyuyang19@fudan.edu.cn>, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, B K Karthik <bkkarthik@pesu.pes.edu>, Daniel Jordan <daniel.m.jordan@oracle.com>, Michel Lespinasse <walken@google.com>, Divyansh Kamboj <kambojdivyansh2000@gmail.com> Subject: [PATCH] Staging: comedi: Return -EFAULT if copy_to_user() fails Date: Wed, 2 Dec 2020 09:43:49 +0300 Message-ID: <X8c3pfwFy2jpy4BP@mwanda> (raw) Return -EFAULT on error instead of the number of bytes remaining to be copied. Fixes: bac42fb21259 ("comedi: get rid of compat_alloc_user_space() mess in COMEDI_CMD{,TEST} compat") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Hi Al, this goes through your tree. drivers/staging/comedi/comedi_fops.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index d99231c737fb..80d74cce2a01 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -2987,7 +2987,9 @@ static int put_compat_cmd(struct comedi32_cmd_struct __user *cmd32, v32.chanlist_len = cmd->chanlist_len; v32.data = ptr_to_compat(cmd->data); v32.data_len = cmd->data_len; - return copy_to_user(cmd32, &v32, sizeof(v32)); + if (copy_to_user(cmd32, &v32, sizeof(v32))) + return -EFAULT; + return 0; } /* Handle 32-bit COMEDI_CMD ioctl. */ -- 2.29.2 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
reply index Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X8c3pfwFy2jpy4BP@mwanda \ --to=dan.carpenter@oracle.com \ --cc=abbotti@mev.co.uk \ --cc=bkkarthik@pesu.pes.edu \ --cc=daniel.m.jordan@oracle.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=kambojdivyansh2000@gmail.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=tanxin.ctf@gmail.com \ --cc=viro@zeniv.linux.org.uk \ --cc=walken@google.com \ --cc=xiyuyang19@fudan.edu.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DriverDev-Devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \ driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org public-inbox-index driverdev-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git