From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54BE7C433E0 for ; Fri, 19 Feb 2021 10:41:03 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD3FA64EB7 for ; Fri, 19 Feb 2021 10:41:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD3FA64EB7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9A1BC86A79; Fri, 19 Feb 2021 10:41:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MJINZjRRBWwI; Fri, 19 Feb 2021 10:41:01 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 605A386B9A; Fri, 19 Feb 2021 10:41:01 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 1D4691BF2CC for ; Fri, 19 Feb 2021 10:41:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 1A1CC8704C for ; Fri, 19 Feb 2021 10:41:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KOka3aVv7qdX for ; Fri, 19 Feb 2021 10:40:59 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 81B5E87038 for ; Fri, 19 Feb 2021 10:40:59 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8207464EAF; Fri, 19 Feb 2021 10:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613731259; bh=eVO2HD34oqjPxE4D8k4YzK7H3mbnN08+5UHMMbGmNkk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jeE0V6mQ4HY0+J8qY39MMjuC/hFrku7azSwseFci48NNxZWxDxXAWpLHjh7jBh73F LrBpfvsu8egXYahoLDHqEBNzdNbVf4IMfP3ENwzuWYpHXPvvIz/iDW+suJvqNz0Iuz jE/vHBvI7HktVdK3fxYW69jfiU7IPRcyHrkCoH0s= Date: Fri, 19 Feb 2021 11:40:55 +0100 From: Greg KH To: Amrit Khera Subject: Re: [PATCH] staging: android: Fix const keyword style issue in ashmem.c Message-ID: References: <20210219101338.2670-1-amritkhera98@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210219101338.2670-1-amritkhera98@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, tkjos@android.com, surenb@google.com, linux-kernel@vger.kernel.org, hridya@google.com, arve@android.com, joel@joelfernandes.org, maco@android.com, christian@brauner.io Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, Feb 19, 2021 at 03:43:39PM +0530, Amrit Khera wrote: > This change fixes a checkpatch warning for "struct file_operations should normally be const". > > Signed-off-by: Amrit Khera > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index d66a64e42273..7854fd410efa 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; > Always test-build your patches before sending them out, otherwise you are wasting reviewer's time, right? :( _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel