From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCB6C433E0 for ; Thu, 18 Feb 2021 12:21:12 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AF5464DEC for ; Thu, 18 Feb 2021 12:21:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AF5464DEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id E0EF887331; Thu, 18 Feb 2021 12:21:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cbpya5aVODDt; Thu, 18 Feb 2021 12:21:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 27E108732A; Thu, 18 Feb 2021 12:21:11 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 39D9D1BF3BA for ; Thu, 18 Feb 2021 12:21:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 6590386E15 for ; Thu, 18 Feb 2021 12:21:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pM4Aam7eLvVo for ; Thu, 18 Feb 2021 12:21:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id A4BA786DCA for ; Thu, 18 Feb 2021 12:21:08 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A269560C3D; Thu, 18 Feb 2021 12:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613650868; bh=1efNp6iCqT0cKOViZRtDzICFQx9Ge9hJLe5WpeuUQY0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QGkRbO03z31FYI3sQ+BYTy4nZswN96ywJq44CWoNIJhfrY1g4iG+tb4M3rWsAgPYL y9WbrXLW/2HPh/sPq/wiwDPeYl36fGj1CLm5WWjAd6oGtfjlNgQKWO1srjDvd7W0oz 2izAQ9XUX8BMbF+6p6Q1MTmsx8tsgIxZt9n/lIoU= Date: Thu, 18 Feb 2021 13:21:05 +0100 From: Greg KH To: Atul Gopinathan Subject: Re: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type Message-ID: References: <20210218084404.16591-1-atulgopinathan@gmail.com> <8f73b7a1-02dd-32ef-8115-ad0f38868692@mev.co.uk> <20210218104755.GA7571@atulu-nitro> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210218104755.GA7571@atulu-nitro> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Ian Abbott , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote: > On Thu, Feb 18, 2021 at 10:31:15AM +0000, Ian Abbott wrote: > > On 18/02/2021 08:44, Atul Gopinathan wrote: > > > Fix the following warning generated by sparse: > > > > > > drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in assignment (different address spaces) > > > drivers/staging//comedi/comedi_fops.c:2956:23: expected unsigned int *chanlist > > > drivers/staging//comedi/comedi_fops.c:2956:23: got void [noderef] * > > > > > > compat_ptr() has a return type of "void __user *" > > > as defined in "include/linux/compat.h" > > > > > > cmd->chanlist is of type "unsigned int *" as defined > > > in drivers/staging/comedi/comedi.h" in struct > > > comedi_cmd. > > > > > > Signed-off-by: Atul Gopinathan > > > --- > > > drivers/staging/comedi/comedi_fops.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c > > > index e85a99b68f31..fc4ec38012b4 100644 > > > --- a/drivers/staging/comedi/comedi_fops.c > > > +++ b/drivers/staging/comedi/comedi_fops.c > > > @@ -2953,7 +2953,7 @@ static int get_compat_cmd(struct comedi_cmd *cmd, > > > cmd->scan_end_arg = v32.scan_end_arg; > > > cmd->stop_src = v32.stop_src; > > > cmd->stop_arg = v32.stop_arg; > > > - cmd->chanlist = compat_ptr(v32.chanlist); > > > + cmd->chanlist = (unsigned int __force *)compat_ptr(v32.chanlist); > > > cmd->chanlist_len = v32.chanlist_len; > > > cmd->data = compat_ptr(v32.data); > > > cmd->data_len = v32.data_len; > > > > > > > This patch and the other one in your series clash with commit 9d5d041eebe3 > > ("staging: comedi: comedi_fops.c: added casts to get rid of sparse > > warnings") by B K Karthik. > > Oh I see. Not sure if this is the right place to ask, but which tree and > branch should one work with when messing with the code in staging/ > directory? (wanted to avoid such clashes in future) staging-next is the best one to use from the staging.git tree. But as the above commit was merged in 5.9-rc1, way back in July of last year, I have no idea what tree you are currently using to not hit that... You should always be able to find the subsystem git trees in the MAINTAINERS file, or if not, just work off of what is in linux-next as that should have all subsystem's trees merged into it. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel