From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64858C433DB for ; Sun, 14 Feb 2021 08:21:45 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB4A064DB1 for ; Sun, 14 Feb 2021 08:21:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB4A064DB1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2FA816F579 for ; Sun, 14 Feb 2021 08:21:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YXEUBSklhwyk for ; Sun, 14 Feb 2021 08:21:42 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id 5FFEE6F533; Sun, 14 Feb 2021 08:21:42 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 238F06F4F0; Sun, 14 Feb 2021 08:21:40 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 8AFD11BF4D6 for ; Sun, 14 Feb 2021 08:21:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 78A096F4EE for ; Sun, 14 Feb 2021 08:21:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QiNDxtvlvTuP for ; Sun, 14 Feb 2021 08:21:38 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id B313B6F4F1; Sun, 14 Feb 2021 08:21:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp3.osuosl.org (Postfix) with ESMTPS id 573AC6F4EE for ; Sun, 14 Feb 2021 08:21:37 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2237561494; Sun, 14 Feb 2021 08:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613290896; bh=CcC3t0obhI410jkBBGKMn3+V8mpeDf2g+FPZ4iPL3Qg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m6Az8v3OCYkRltLEW4GWwEseg3nPX6X8KhoydssK6vgKFMa9CQQiC9OcrvethYoCa b0uLAf2YtnWdCciGT2aFzAxCe8bspiSFbBwDeI67jYtNdUaf9qXjeoIyeWR3j8jCSB K8qkS7HRUXjmRcIXWytTce1VVf2jqXacGvyGD5Jg= Date: Sun, 14 Feb 2021 09:21:33 +0100 From: Greg Kroah-Hartman To: Thais Camacho Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword Message-ID: References: <20210214023136.8916-1-thaiscamachoo@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210214023136.8916-1-thaiscamachoo@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Todd Kjos , Suren Baghdasaryan , linux-kernel@vger.kernel.org, Joel Fernandes , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Hridya Valsaraju , Martijn Coenen , Christian Brauner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sat, Feb 13, 2021 at 11:31:36PM -0300, Thais Camacho wrote: > Warning found by checkpatch.pl script > > Signed-off-by: Thais Camacho > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index 4789d36ddfd3..2cb665e0228c 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; > > -- > 2.20.1 Any specific reason why you did not test-build your change before sending it to us? Please always do so, otherwise it causes lots of problems, and makes maintainers grumpy :) thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel