From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD2DC433DB for ; Sat, 20 Feb 2021 07:02:30 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC6B464EE0 for ; Sat, 20 Feb 2021 07:02:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC6B464EE0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id C2182874B9; Sat, 20 Feb 2021 07:02:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9XU8gZUoS68v; Sat, 20 Feb 2021 07:02:29 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 3F96B87502; Sat, 20 Feb 2021 07:02:29 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 3709F1BF83B for ; Sat, 20 Feb 2021 07:02:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3149E874B9 for ; Sat, 20 Feb 2021 07:02:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lid9dz0WSDLl for ; Sat, 20 Feb 2021 07:02:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by hemlock.osuosl.org (Postfix) with ESMTPS id BA35187351 for ; Sat, 20 Feb 2021 07:02:26 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D8C7864EB8; Sat, 20 Feb 2021 07:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613804546; bh=Pvh5cvdWKO1LNmyetgVB1YyxbpJdDKcFN/Tg6OGL7+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jmEaiT3r/F6fl71Sc7Hqap7ot1RTVLGh1ddbcZ03dVUXbg2yw6DhnQBAHtzdwzKWj pHRHxHJohqqkFnsAIOWK9oMMCXUueYM39jYhs4pl/B4sEXMJv7MSYaC8g9u+IYNBPW ep4njqFYZg12q0E39j6RthsylaOujRIHSjUewA2E= Date: Sat, 20 Feb 2021 08:02:23 +0100 From: Greg KH To: Julian Braha Subject: Re: [PATCH] Staging: rtl8192e: fix kconfig dependency on CRYPTO Message-ID: References: <8483722.hVsnvgcxvV@ubuntu-mate-laptop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8483722.hVsnvgcxvV@ubuntu-mate-laptop> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, Feb 19, 2021 at 06:14:57PM -0500, Julian Braha wrote: > commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0 > Author: Julian Braha > Date: Fri Feb 19 17:02:24 2021 -0500 > > staging: rtl8192e: fix kconfig dependency on CRYPTO > > When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled, > Kbuild gives the following warning: > > WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC > Depends on [n]: CRYPTO [=n] > Selected by [m]: > - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m] > > WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4 > Depends on [n]: CRYPTO [=n] > Selected by [m]: > - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m] > - RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m] > > This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and CRYPTO_LIB_ARC4, > without depending on or selecting CRYPTO, despite those config options > being subordinate to CRYPTO. > > Signed-off-by: Julian Braha > > diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig > index 03fcc23516fd..6e7d84ac06f5 100644 > --- a/drivers/staging/rtl8192e/Kconfig > +++ b/drivers/staging/rtl8192e/Kconfig > @@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP > config RTLLIB_CRYPTO_TKIP > tristate "Support for rtllib TKIP crypto" > depends on RTLLIB > + select CRYPTO > select CRYPTO_LIB_ARC4 > select CRYPTO_MICHAEL_MIC > default y Odd indentation :( _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel