From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CF2FC433E0 for ; Sat, 20 Feb 2021 14:16:48 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25E3164EE0 for ; Sat, 20 Feb 2021 14:16:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25E3164EE0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=karthek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id BDC6D6F484 for ; Sat, 20 Feb 2021 14:16:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t9MorsR_ya_C for ; Sat, 20 Feb 2021 14:16:46 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id 9F42F6F544; Sat, 20 Feb 2021 14:16:45 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 460866F492; Sat, 20 Feb 2021 14:16:43 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 3B7641BF82D for ; Sat, 20 Feb 2021 14:16:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 36ED18399B for ; Sat, 20 Feb 2021 14:16:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qO8QgO1WHCAY for ; Sat, 20 Feb 2021 14:16:40 +0000 (UTC) Received: by smtp1.osuosl.org (Postfix, from userid 1001) id 78B8C839BB; Sat, 20 Feb 2021 14:16:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by smtp1.osuosl.org (Postfix) with ESMTPS id CF469839B4 for ; Sat, 20 Feb 2021 14:16:38 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id j1so3926942pgh.4 for ; Sat, 20 Feb 2021 06:16:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=4OkHhkzvFQiowFhMieNatI/2LoPDzKsla6UJw7fnLaE=; b=ONQ8NdgGXzZEmanNw26MBZcdJSisenzoGx8TcbSh3EJKR/yZYBsiCy2zsTdWAjM8w4 Q6GZtzeaUAYV/8sfMOtw5NUwt1TkME60BTTlkCBc6yvbKw9lXzWNhRfoG79Ms1nYzPPU yKd3NUXQA4KcYU4Aa4vOmyZFpJYITI3R86PTa710sutLVY/OoAcnoP7RsZQh4I7TA+Zz xUGJLiulyiGwU0KbBU3HZ1At4ImPWTRgcK6yQ0WOrxIPxlHHmAnDsO+GDyrka5va2wvG GgGRsIjtZdMPvxvC5yGyM8SCMiYCQnWRRpvidLNWizyqRf1U9AqfaLiFbnbhOsKREQh1 shHw== X-Gm-Message-State: AOAM533Pg3xc1PdcWTdneBf2uVi6zjxOm5rLVj3WL+i+Gug/8ptDooqc SjkUjT29upXveI80Ymh271I= X-Google-Smtp-Source: ABdhPJxmDWIXoSSt5X6KOjyKi38zdn3BaeHf781aDGPkh5prWqaZ4E+Q+Lt6y32PoynZXEg2GazUMA== X-Received: by 2002:a05:6a00:8f:b029:1e8:6975:395e with SMTP id c15-20020a056a00008fb02901e86975395emr6552245pfj.55.1613830598292; Sat, 20 Feb 2021 06:16:38 -0800 (PST) Received: from karthik-strix-linux.karthek.com ([192.140.155.84]) by smtp.gmail.com with ESMTPSA id u9sm5220857pgc.59.2021.02.20.06.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 06:16:37 -0800 (PST) Date: Sat, 20 Feb 2021 19:46:27 +0530 From: karthik alapati To: Greg Kroah-Hartman , Mauro Carvalho Chehab , Sakari Ailus Subject: [PATCH] staging: media/atomisp: don't compile unused code Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" currently the functions defined in ibuf_ctrl_rmgr.c file are only used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected so dont't compile it when not needed, also fixes some sparse warnings Signed-off-by: karthik alapati --- is this the right patch or just compiling out those functions by conditional comiplation is sufficient? drivers/staging/media/atomisp/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/Makefile b/drivers/staging/media/atomisp/Makefile index 1dfad0dd0..51498b2e8 100644 --- a/drivers/staging/media/atomisp/Makefile +++ b/drivers/staging/media/atomisp/Makefile @@ -126,7 +126,6 @@ atomisp-objs += \ pci/runtime/inputfifo/src/inputfifo.o \ pci/runtime/isp_param/src/isp_param.o \ pci/runtime/isys/src/csi_rx_rmgr.o \ - pci/runtime/isys/src/ibuf_ctrl_rmgr.o \ pci/runtime/isys/src/isys_dma_rmgr.o \ pci/runtime/isys/src/isys_init.o \ pci/runtime/isys/src/isys_stream2mmio_rmgr.o \ @@ -323,7 +322,9 @@ DEFINES := -DHRT_HW -DHRT_ISP_CSS_CUSTOM_HOST -DHRT_USE_VIR_ADDRS -D__HOST__ #DEFINES += -DUSE_KMEM_CACHE ifeq ($(CONFIG_VIDEO_ATOMISP_ISP2401),y) -atomisp-objs += $(obj-cht) +atomisp-objs += \ + $(obj-cht) \ + pci/runtime/isys/src/ibuf_ctrl_rmgr.o DEFINES += -DISP2401 -DISP2401_NEW_INPUT_SYSTEM -DSYSTEM_hive_isp_css_2401_system else atomisp-objs += $(obj-byt) -- 2.30.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel