From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A79A1C433DB for ; Fri, 26 Feb 2021 07:57:24 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C97264EDC for ; Fri, 26 Feb 2021 07:57:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C97264EDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AEB6484117; Fri, 26 Feb 2021 07:57:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QwLRc1yMnnMS; Fri, 26 Feb 2021 07:57:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 8098B8411A; Fri, 26 Feb 2021 07:57:22 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 283981BF31D for ; Fri, 26 Feb 2021 07:57:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 225D38411A for ; Fri, 26 Feb 2021 07:57:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YlvQSNU-iwe8 for ; Fri, 26 Feb 2021 07:57:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7D83C84117 for ; Fri, 26 Feb 2021 07:57:20 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 1359464EDB; Fri, 26 Feb 2021 07:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614326239; bh=17qB4OXEg3fk/1Suqbr0+KU1+wYrtixrMN3SQL5rC6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TYiVX3WIRJwOR+6ey01evnpqoX5pi335iyoEpRZUouqvE/o423wlj43M6pq/7EFfO MjGOGWrdz1XFx6BfbcMsKaBj7x1L1Kp8Y5VCfnc2L6O/nDTPoG2Osofz55FQJL//VH Hb0JHaJb+suQNrZZPlE76NKjJ8uUc66lPVHKfAqw= Date: Fri, 26 Feb 2021 08:57:17 +0100 From: Greg KH To: Lee Gibson Subject: Re: [PATCH] staging: rtl8192u: minor coding style fix Message-ID: References: <20210225100351.12199-1-leegib@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210225100351.12199-1-leegib@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Feb 25, 2021 at 10:03:51AM +0000, Lee Gibson wrote: > Fixes this checkpatch warning > WARNING: Comparisons should place the constant on the right side of the test > > Signed-off-by: Lee Gibson > --- > drivers/staging/rtl8192u/r8192U_wx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c > index d853586705fc..175bb8b15389 100644 > --- a/drivers/staging/rtl8192u/r8192U_wx.c > +++ b/drivers/staging/rtl8192u/r8192U_wx.c > @@ -726,7 +726,7 @@ static int r8192_wx_set_enc_ext(struct net_device *dev, > idx--; > group = ext->ext_flags & IW_ENCODE_EXT_GROUP_KEY; > > - if ((!group) || (IW_MODE_ADHOC == ieee->iw_mode) || (alg == KEY_TYPE_WEP40)) { > + if ((!group) || (ieee->iw_mode == IW_MODE_ADHOC) || (alg == KEY_TYPE_WEP40)) { > if ((ext->key_len == 13) && (alg == KEY_TYPE_WEP40)) > alg = KEY_TYPE_WEP104; > ieee->pairwise_key_type = alg; > -- > 2.25.1 Someone already sent this same fix in before you did, sorry. greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel