From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9038C433DB for ; Sat, 6 Mar 2021 17:26:14 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 811EA65017 for ; Sat, 6 Mar 2021 17:26:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 811EA65017 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 28752836C3; Sat, 6 Mar 2021 17:26:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lzsAuaRPnSP2; Sat, 6 Mar 2021 17:26:13 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id D337A836C8; Sat, 6 Mar 2021 17:26:12 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 347FB1BF313 for ; Sat, 6 Mar 2021 17:26:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 23DAD6064B for ; Sat, 6 Mar 2021 17:26:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kroah.com header.b="wLL8kHKg"; dkim=pass (2048-bit key) header.d=messagingengine.com header.b="Ixai+4xN" Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q32ORN00nl23 for ; Sat, 6 Mar 2021 17:26:10 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by smtp3.osuosl.org (Postfix) with ESMTPS id E68F9605E2 for ; Sat, 6 Mar 2021 17:26:10 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 670132918; Sat, 6 Mar 2021 12:26:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 06 Mar 2021 12:26:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=PGwBIPF5IiqJcixqzcqLpEj81T8 qJhkY5ns3fEHL59M=; b=wLL8kHKgVP7cIt4/5aCfj69xz4+hdb4HErbWVrvUXaM GbQlWOKS6R64mAbLhUhDiMFvxENFVemx9BcjZy1L5NGmlbp3547IlkbXmaA4rXz5 s48VyxhYjQRk2Xaor92tjNnd998RQX6yhyJVF+s4CbtTAcdWPPAJ1uLgqHlcHf8V lN9Y6busvn85MmlcziZl3g27bKtb9hUKEahUxpZni1uTCpBzf6HFWlfhm1t4Npb+ sP0BQae7vX41Qp91r3XNpPDVjiKRlk9f2Tke1gjkFn+BUY2unkXIaaZWQO2a/HJW TmyEkjwMMr1YaGj8//TgnMl4moU8aT6iL12Jvhhpg8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=PGwBIP F5IiqJcixqzcqLpEj81T8qJhkY5ns3fEHL59M=; b=Ixai+4xN53J3ZT/C3imZCT h7WsqJXY/vIziofz7aSRGs2fK7UunC9Onr6vKKVJaa8XW6weKrY6jKGPu/X3Wg0H kcNjwf/DdLOHJwvLMTlK5TIgoMF0mv+vixegUsNNmKUQInHNldN+fw/VkvUIrF2e zZol+AIrO86Ov01hcqDn5WMIZLAPbizLoEGb4jwB2aBeehm4zmEeQDKqjwJ46Cxx zdLYx4XJOK+4C6pDQvhOqvYk16/+DKL1FlifAEqXyp+b4JAaQW3wHkxvcPZBS2D5 EQKJi0krzcg1w1OQYTnSH0m4n5kJ9YXhRH0O52EGTtx2uXOCixU9BppVFpZ1QKow == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddtkedgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepifhrvghgucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheq necuggftrfgrthhtvghrnhepjeevgeetueevjeduudehffelgfeiffehgfegudefgeffte euuefgtddvteefkeffnecuffhomhgrihhnpehlihhnuhigughrihhvvghrphhrohhjvggt thdrohhrghenucfkphepkeefrdekiedrjeegrdeigeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) by mail.messagingengine.com (Postfix) with ESMTPA id 78F4724005A; Sat, 6 Mar 2021 12:26:07 -0500 (EST) Date: Sat, 6 Mar 2021 18:26:05 +0100 From: Greg KH To: gabriele.modena@gmail.com Subject: Re: [PATCH] staging: wimax: fix style check warnings Message-ID: References: <20210305195508.3543-1-gabriele.modena@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210305195508.3543-1-gabriele.modena@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, trivial@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, Mar 05, 2021 at 08:55:09PM +0100, gabriele.modena@gmail.com wrote: > From: Gabriele Modena > > Fix style warnings reported by checkpatch.pl on op-rfkill.c > by moving */ on a separate line in a block comment, > adding a missing blank line after declarations, > and reformatting a quoted string split across lines. > > Signed-off-by: Gabriele Modena > --- > drivers/staging/wimax/op-rfkill.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/wimax/op-rfkill.c b/drivers/staging/wimax/op-rfkill.c > index 78b294481a59..52612ed09183 100644 > --- a/drivers/staging/wimax/op-rfkill.c > +++ b/drivers/staging/wimax/op-rfkill.c > @@ -294,7 +294,8 @@ int wimax_rfkill(struct wimax_dev *wimax_dev, enum wimax_rf_state state) > /* While initializing, < 1.4.3 wimax-tools versions use > * this call to check if the device is a valid WiMAX > * device; so we allow it to proceed always, > - * considering the radios are all off. */ > + * considering the radios are all off. > + */ > if (result == -ENOMEDIUM && state == WIMAX_RF_QUERY) > result = WIMAX_RF_OFF << 1 | WIMAX_RF_OFF; > goto error_not_ready; > @@ -378,6 +379,7 @@ int wimax_rfkill_add(struct wimax_dev *wimax_dev) > void wimax_rfkill_rm(struct wimax_dev *wimax_dev) > { > struct device *dev = wimax_dev_to_dev(wimax_dev); > + > d_fnstart(3, dev, "(wimax_dev %p)\n", wimax_dev); > rfkill_unregister(wimax_dev->rfkill); > rfkill_destroy(wimax_dev->rfkill); > @@ -415,8 +417,7 @@ int wimax_gnl_doit_rfkill(struct sk_buff *skb, struct genl_info *info) > dev = wimax_dev_to_dev(wimax_dev); > result = -EINVAL; > if (info->attrs[WIMAX_GNL_RFKILL_STATE] == NULL) { > - dev_err(dev, "WIMAX_GNL_RFKILL: can't find RFKILL_STATE " > - "attribute\n"); > + dev_err(dev, "WIMAX_GNL_RFKILL: can't find RFKILL_STATE attribute\n"); > goto error_no_pid; > } > new_state = nla_get_u32(info->attrs[WIMAX_GNL_RFKILL_STATE]); > -- > 2.11.0 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel