From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71EC1C433DB for ; Tue, 9 Mar 2021 13:07:52 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1382F65272 for ; Tue, 9 Mar 2021 13:07:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1382F65272 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A69A3606FD; Tue, 9 Mar 2021 13:07:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RwL0qSSwPaNQ; Tue, 9 Mar 2021 13:07:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 8BD326F521; Tue, 9 Mar 2021 13:07:50 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 578371BF2F0 for ; Tue, 9 Mar 2021 13:07:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 44946453D7 for ; Tue, 9 Mar 2021 13:07:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=linuxfoundation.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2dmp1W2wfgH8 for ; Tue, 9 Mar 2021 13:07:46 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp4.osuosl.org (Postfix) with ESMTPS id 838044528A for ; Tue, 9 Mar 2021 13:07:46 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3FC126526C; Tue, 9 Mar 2021 13:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615295265; bh=SJxEiOx3TaNKk34uWUt1NVcxB+r8JCI6QUSyzU5W+QM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NGm+kH/FxClHY9fcS3ayyQmvgxq9moor4xfQXUYJIQnkhsyBxF5TU/2yCfOEEmn80 QS2Z5zfGnXOP+mkYpcGw1artbPXbb4fEi7S3w0JAtVkejxTvRMxg7ELgG7bOL7t41+ iY5HhTuZ/Z7myr64EgeGgge3DoMYE3it7WRXv6Is= Date: Tue, 9 Mar 2021 14:07:43 +0100 From: Greg KH To: =?iso-8859-1?B?Suly9G1l?= Pouiller Subject: Re: [PATCH] staging: wfx: remove unused included header files Message-ID: References: <20210211143637.GA177425@LEGION> <1722736.fQpYkz0vEs@pc-42> <5120192.kWiexivLR2@pc-42> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5120192.kWiexivLR2@pc-42> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Muhammad Usama Anjum Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Mar 04, 2021 at 10:43:45AM +0100, J=E9r=F4me Pouiller wrote: > Hello Greg, > = > On Tuesday 2 March 2021 16:01:25 CET J=E9r=F4me Pouiller wrote: > > Hello Muhammad, > > = > > Sorry, I am a bit late for the review of this patch. Thank you for your = > > contribution. > > = > > On Thursday 11 February 2021 15:36:37 CET Muhammad Usama Anjum wrote: > > > = > > > Many header files have been included, but never used. Those header > > > files have been removed. > > > = > > > Signed-off-by: Muhammad Usama Anjum > > > --- > > > drivers/staging/wfx/bh.c | 1 - > > > drivers/staging/wfx/bh.h | 4 ---- > > > drivers/staging/wfx/bus.h | 3 --- > > > drivers/staging/wfx/bus_sdio.c | 6 ------ > > > drivers/staging/wfx/bus_spi.c | 7 ------- > > > drivers/staging/wfx/data_rx.c | 5 ----- > > > drivers/staging/wfx/data_tx.c | 5 ----- > > > drivers/staging/wfx/data_tx.h | 3 --- > > > drivers/staging/wfx/debug.c | 6 ------ > > > drivers/staging/wfx/fwio.c | 2 -- > > > drivers/staging/wfx/hif_api_cmd.h | 4 ---- > > > drivers/staging/wfx/hif_api_general.h | 9 --------- > > > drivers/staging/wfx/hif_tx.c | 4 ---- > > > drivers/staging/wfx/hif_tx_mib.c | 5 ----- > > > drivers/staging/wfx/hwio.c | 3 --- > > > drivers/staging/wfx/hwio.h | 2 -- > > > drivers/staging/wfx/key.c | 2 -- > > > drivers/staging/wfx/key.h | 2 -- > > > drivers/staging/wfx/main.c | 7 ------- > > > drivers/staging/wfx/main.h | 3 --- > > > drivers/staging/wfx/queue.c | 4 ---- > > > drivers/staging/wfx/queue.h | 3 --- > > > drivers/staging/wfx/scan.h | 2 -- > > > drivers/staging/wfx/sta.c | 6 ------ > > > drivers/staging/wfx/sta.h | 2 -- > > > drivers/staging/wfx/traces.h | 3 --- > > > drivers/staging/wfx/wfx.h | 3 --- > > > 27 files changed, 106 deletions(-) > > > = > > > diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c > > > index ed53d0b45592..cd6bcfdfbe9a 100644 > > > --- a/drivers/staging/wfx/bh.c > > > +++ b/drivers/staging/wfx/bh.c > > > @@ -5,7 +5,6 @@ > > > * Copyright (c) 2017-2020, Silicon Laboratories, Inc. > > > * Copyright (c) 2010, ST-Ericsson > > > */ > > > -#include > > > #include > > = > > Though bh.c refers to gpiod_set_value_cansleep() > > = > > = > > > #include "bh.h" > > > diff --git a/drivers/staging/wfx/bh.h b/drivers/staging/wfx/bh.h > > > index 78c49329e22a..92ef3298d4ac 100644 > > > --- a/drivers/staging/wfx/bh.h > > > +++ b/drivers/staging/wfx/bh.h > > > @@ -8,10 +8,6 @@ > > > #ifndef WFX_BH_H > > > #define WFX_BH_H > > > = > > > -#include > > > -#include > > > -#include > > > - > > > struct wfx_dev; > > > = > > > struct wfx_hif { > > = > > Ditto, bh.h refers to atomic_t, struct work_struct and struct = > > completion. If you try to compile bh.h alone (with something like > > gcc -xc .../bh.h) it won't work. > > = > > Maybe it works now because we are lucky in the order the headers are = > > included, but I think it is not sufficient. > > = > > [... same problem repeats multiple times in the following ...] > > = > = > Greg, if nobody has any opinion on that, I think that this patch should > be reverted. Nothing is breaking, why should it be reverted? You never build a .h file alone :) Anyway, sure, I'll revert it, what is the commit id? thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel