From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 618CBC433B4 for ; Fri, 2 Apr 2021 09:00:33 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91C2D61003 for ; Fri, 2 Apr 2021 09:00:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91C2D61003 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2747440001; Fri, 2 Apr 2021 09:00:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U9C16q63IYsB; Fri, 2 Apr 2021 09:00:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 14ECA401FD; Fri, 2 Apr 2021 09:00:31 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D64A61BF831 for ; Fri, 2 Apr 2021 09:00:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C427241907 for ; Fri, 2 Apr 2021 09:00:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=ideasonboard.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id isxg1ii0unbi for ; Fri, 2 Apr 2021 09:00:28 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5C14141906 for ; Fri, 2 Apr 2021 09:00:28 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E69632C1; Fri, 2 Apr 2021 11:00:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1617354024; bh=elTh91fHBqoRE3n15Vt6YQfqLzAPhdsnX4FGuvqKbJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oWFPNwZpRW0+ESGW3PxJDKemt4sdh4C2jxyzELlrhmAyenar17Mj6v3OiAJ7L8+MS Cn415IdbXHMs57Nwqp7UyBPce4jNY+QIqHyATyPyPnQSbGMiGRz8GAHgEwVkG6tX/l LlGJEOhMI+/QDocY1j9CI6RYvLmbQqR+fNXvD2gM= Date: Fri, 2 Apr 2021 11:59:39 +0300 From: Laurent Pinchart To: Xin Ji Subject: Re: [PATCH v6 4/5] drm/bridge: anx7625: add HDCP support Message-ID: References: <189a637c87827f78c433a053e3c2129ebec73188.1616135353.git.xji@analogixsemi.com> <20210329102710.GA1930154@anxtwsw-Precision-3640-Tower> <20210402022708.GA2154388@anxtwsw-Precision-3640-Tower> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210402022708.GA2154388@anxtwsw-Precision-3640-Tower> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Nicolas Boichat , Jernej Skrabec , Sam Ravnborg , Jonas Karlman , David Airlie , Bernie Liang , dri-devel , Neil Armstrong , LKML , Foss , Vasily Khoruzhick , Andrzej Hajda , Boris Brezillon , Torsten Duwe , Sheng Pan , Zhen Li , Hsin-Yi Wang , Sean Paul , Dan Carpenter , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Xin, On Fri, Apr 02, 2021 at 10:27:08AM +0800, Xin Ji wrote: > On Mon, Mar 29, 2021 at 02:02:08PM -0400, Sean Paul wrote: > > On Mon, Mar 29, 2021 at 6:27 AM Xin Ji wrote: > > > > > > On Thu, Mar 25, 2021 at 02:19:23PM -0400, Sean Paul wrote: > > > > On Fri, Mar 19, 2021 at 2:35 AM Xin Ji wrote: > > > > > > > > > > Add HDCP feature, enable HDCP function through chip internal key > > > > > and downstream's capability. > > > > > > > > > > Signed-off-by: Xin Ji > > > > > --- > > > > /snip > > > > > > > static void anx7625_dp_start(struct anx7625_data *ctx) > > > > > { > > > > > int ret; > > > > > @@ -643,6 +787,9 @@ static void anx7625_dp_start(struct anx7625_data *ctx) > > > > > return; > > > > > } > > > > > > > > > > + /* HDCP config */ > > > > > + anx7625_hdcp_setting(ctx); > > > > > > > > You should really use the "Content Protection" property to > > > > enable/disable HDCP instead of force-enabling it at all times. > > > > > > Hi Sean, it's hard to implement "Content Protection" property, we have > > > implemented HDCP in firmware, it is not compatible with it. We don't > > > have interface to get Downstream Cert. > > > Thanks, > > > Xin > > > > Hi Xin, > > I'm sorry, I don't understand what you mean when you say you don't > > have an interface to get Downstream Cert. > > > > The Content Protection property is just a means through which > > userspace can turn on and turn off HDCP when it needs. As far as I can > > tell, your patch turns on HDCP when the display is enabled and leaves > > it on until it is disabled. This is undesirable since it forces HDCP > > on the user. > > > > Is it impossible to enable/disable HDCP outside of display > > enable/disable on your hardware? > > Hi Sean, I have commit a test patch on google review site, can you > please help to review it? I'll use Connector's ".atomic_check()" > interface to detect Content Protection property change. > (https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2674580) Please note that upstream review happens on mailing lists, not in gerrit. Internal reviews for Chrome OS development are certainly fine there, but that will not mean the patch will then be accepted upstream as-is, it will still need to go through the upstream review process, without any shortcut. I strongly recommend using an upstream-first strategy, with public review. > > > > > + > > > > > if (ctx->pdata.is_dpi) > > > > > ret = anx7625_dpi_config(ctx); > > > > > else > > > > /snip -- Regards, Laurent Pinchart _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel