[PATCH] staging: rtl8188eu: remove unnecessary blank lines in core/rtw_ap.c

[PATCH] staging: rtl8188eu: remove unnecessary blank lines in core/rtw_ap.c

[Benjamin Philip]

This commit fixes some checkpatch checks for blank lines before
and after braces in drivers/staging/rtl8188eu/core/rtw_ap.c

Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
---

This patch fixes some checkpatch.pl CHECKs for blank lines.

Note: Since all I have done is remove some empty blank lines, I didn't
compile and test the driver.

This is my first patch to the kernel. If I have erred in the patch sending
workflow in any way, I will be glad to resend it in the correct manner.

Apologies for sending the mail privately to Greg and Larry the first time round.

Also, should I have made a patch for each line I removed and sent it as a patchset,
or this one single patch better?

 drivers/staging/rtl8188eu/core/rtw_ap.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index b817aa8b9de4..a2aeb78733d5 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -381,7 +381,6 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
 		/* set ra_id, init_rate */
 		psta->raid = raid;
 		psta->init_rate = init_rate;
-
 	}
 }
 
@@ -453,7 +452,6 @@ static void update_bmc_sta(struct adapter *padapter)
 		spin_lock_bh(&psta->lock);
 		psta->state = _FW_LINKED;
 		spin_unlock_bh(&psta->lock);
-
 	}
 }
 
@@ -1140,7 +1138,6 @@ static void update_bcn_wps_ie(struct adapter *padapter)
 
 static void update_bcn_vendor_spec_ie(struct adapter *padapter, u8 *oui)
 {
-
 	if (!memcmp(WPS_OUI, oui, 4))
 		update_bcn_wps_ie(padapter);
 }
-- 
2.31.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8188eu: remove unnecessary blank lines in core/rtw_ap.c

[Greg Kroah-Hartman]

On Wed, Jul 21, 2021 at 04:28:09PM +0530, Benjamin Philip wrote:
> This commit fixes some checkpatch checks for blank lines before
> and after braces in drivers/staging/rtl8188eu/core/rtw_ap.c
> 
> Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
> ---
> 
> This patch fixes some checkpatch.pl CHECKs for blank lines.
> 
> Note: Since all I have done is remove some empty blank lines, I didn't
> compile and test the driver.

Always test-build your changes, do not force me to do that for you.

Please do that and resend.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8188eu: remove unnecessary blank lines in core/rtw_ap.c

[Benjamin Philip]

This commit fixes some checkpatch checks for blank lines before
and after braces in drivers/staging/rtl8188eu/core/rtw_ap.c

Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
---

This patch fixes some checkpatch.pl CHECKs for blank lines.

I have tested my changes by compiling them. I also used 
checkpatch.pl, which did not issue any warnings for my patch.

This is my first patch to the kernel. If I have erred in the patch sending
workflow in any way, I will be glad to resend it in the correct manner.

 drivers/staging/rtl8188eu/core/rtw_ap.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index b817aa8b9de4..a2aeb78733d5 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -381,7 +381,6 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
 		/* set ra_id, init_rate */
 		psta->raid = raid;
 		psta->init_rate = init_rate;
-
 	}
 }
 
@@ -453,7 +452,6 @@ static void update_bmc_sta(struct adapter *padapter)
 		spin_lock_bh(&psta->lock);
 		psta->state = _FW_LINKED;
 		spin_unlock_bh(&psta->lock);
-
 	}
 }
 
@@ -1140,7 +1138,6 @@ static void update_bcn_wps_ie(struct adapter *padapter)
 
 static void update_bcn_vendor_spec_ie(struct adapter *padapter, u8 *oui)
 {
-
 	if (!memcmp(WPS_OUI, oui, 4))
 		update_bcn_wps_ie(padapter);
 }
-- 
2.31.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel