[PATCH v2 0/3] Remove blank lines at drivers/rtl8188eu/core/rtw_ap.c

[PATCH v2 0/3] Remove blank lines at drivers/rtl8188eu/core/rtw_ap.c

[Benjamin Philip]

The following few patches remove some blank lines that before or after a brace.

To test my changes, I have checked if it compiles (which it does). I also have
checked the patch with checkpatch.pl, which does not pass any warnings of any sort.

Changes in v2:
* Tested by building (no changes code)

This is my first patch to the linux kernel. I apologize for all the inconveniences caused
by my unfamiliarity with the kernel workflow.

I also have split each line I removed into a patch so that it is convenient for the
maintainer. I hope it is so.

Thanks,
Benjamin Philip

Benjamin Philip (3):
  staging: rtl8188eu: Remove blank line at core/rtw_ap.c:385
  staging: rtl8188eu: Remove blank line at core/rtw_ap.c:457
  staging: rtl8188eu: Remove blank line at core/rtw_ap.c:1143

 drivers/staging/rtl8188eu/core/rtw_ap.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.31.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 1/3] staging: rtl8188eu: Remove blank line at core/rtw_ap.c:385

[Benjamin Philip]

This commit fixes the following checkpatch.pl CHECK:

CHECK: Blank lines aren't necessary before a close brace '}'
385: FILE: drivers/staging/rtl8188eu/core/rtw_ap.c:385:
+
+	}

Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_ap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index b817aa8b9de4..215a0285005f 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -381,7 +381,6 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
 		/* set ra_id, init_rate */
 		psta->raid = raid;
 		psta->init_rate = init_rate;
-
 	}
 }
 
-- 
2.31.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 2/3] staging: rtl8188eu: Remove blank line at core/rtw_ap.c:457

[Benjamin Philip]

This commit fixes the following checkpatch.pl CHECK:

CHECK: Blank lines aren't necessary before a close brace '}'
457: FILE: drivers/staging/rtl8188eu/core/rtw_ap.c:457:
+
+	}

Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_ap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index 215a0285005f..ba3a6347976d 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -452,7 +452,6 @@ static void update_bmc_sta(struct adapter *padapter)
 		spin_lock_bh(&psta->lock);
 		psta->state = _FW_LINKED;
 		spin_unlock_bh(&psta->lock);
-
 	}
 }
 
-- 
2.31.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 3/3] staging: rtl8188eu: Remove blank line at core/rtw_ap.c:1143

[Benjamin Philip]

This commit fixes the following checkpatch.pl CHECK:

CHECK: Blank lines aren't necessary after an open brace '{'
1143: FILE: drivers/staging/rtl8188eu/core/rtw_ap.c:1143:
+{
+

Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_ap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index ba3a6347976d..a2aeb78733d5 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -1138,7 +1138,6 @@ static void update_bcn_wps_ie(struct adapter *padapter)
 
 static void update_bcn_vendor_spec_ie(struct adapter *padapter, u8 *oui)
 {
-
 	if (!memcmp(WPS_OUI, oui, 4))
 		update_bcn_wps_ie(padapter);
 }
-- 
2.31.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 0/3] Remove blank lines at drivers/rtl8188eu/core/rtw_ap.c

[Greg Kroah-Hartman]

On Fri, Jul 23, 2021 at 04:27:50PM +0530, Benjamin Philip wrote:
> The following few patches remove some blank lines that before or after a brace.
> 
> To test my changes, I have checked if it compiles (which it does). I also have
> checked the patch with checkpatch.pl, which does not pass any warnings of any sort.
> 
> Changes in v2:
> * Tested by building (no changes code)
> 
> This is my first patch to the linux kernel. I apologize for all the inconveniences caused
> by my unfamiliarity with the kernel workflow.
> 
> I also have split each line I removed into a patch so that it is convenient for the
> maintainer. I hope it is so.
> 
> Thanks,
> Benjamin Philip
> 
> Benjamin Philip (3):
>   staging: rtl8188eu: Remove blank line at core/rtw_ap.c:385
>   staging: rtl8188eu: Remove blank line at core/rtw_ap.c:457
>   staging: rtl8188eu: Remove blank line at core/rtw_ap.c:1143

That's just too many patches, your first one was just fine :)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel