From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C82E4C1975A for ; Wed, 25 Mar 2020 11:38:05 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5C5E20722 for ; Wed, 25 Mar 2020 11:38:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5C5E20722 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7A75D87A33; Wed, 25 Mar 2020 11:38:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t28nv5UewM3f; Wed, 25 Mar 2020 11:38:04 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 12A2088000; Wed, 25 Mar 2020 11:38:04 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 247C11BF5DC for ; Wed, 25 Mar 2020 11:38:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 206C687E72 for ; Wed, 25 Mar 2020 11:38:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rJa8oaQ1scu7 for ; Wed, 25 Mar 2020 11:38:01 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by hemlock.osuosl.org (Postfix) with ESMTPS id A3E49879DB for ; Wed, 25 Mar 2020 11:38:00 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.72,304,1580770800"; d="scan'208";a="343676712" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Mar 2020 12:37:57 +0100 Date: Wed, 25 Mar 2020 12:37:56 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Simran Singhal Subject: Re: [Outreachy kernel] [PATCH v2] staging: kpc2000: Removing a blank line In-Reply-To: <20200325095407.GA3788@simran-Inspiron-5558> Message-ID: References: <20200325095407.GA3788@simran-Inspiron-5558> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdevel , Greg KH , Linux Kernel Mailing List , outreachy-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, 25 Mar 2020, Simran Singhal wrote: > This patch fixes the checkpatch warning by removing a blank > line. > CHECK: Please don't use multiple blank lines The subject line and the log message should be written in the imperative. So that would be Remove, rather than Removing for the subject line. The log message should first say what you did to fix the problem and why. How the problem was found can come afterwards. So you should not start with "This patch fixes the checkpatch warning by". "This patch" is not useful, because it is obvious that it is a patch, based on the subject line. "fixes" does not given any information about what is done or why. "the checkpatch warning" is useful, but it's not what one wants to see first. julia > > Signed-off-by: Simran Singhal > --- > Changes in v2: > - Make the subject and commit message correct by mentioning that > this patch specifically removes a blank line. > > drivers/staging/kpc2000/kpc2000/pcie.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/kpc2000/kpc2000/pcie.h b/drivers/staging/kpc2000/kpc2000/pcie.h > index cb815c30faa4..f1fc91b4c704 100644 > --- a/drivers/staging/kpc2000/kpc2000/pcie.h > +++ b/drivers/staging/kpc2000/kpc2000/pcie.h > @@ -6,7 +6,6 @@ > #include "../kpc.h" > #include "dma_common_defs.h" > > - > /* System Register Map (BAR 1, Start Addr 0) > * > * BAR Size: > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200325095407.GA3788%40simran-Inspiron-5558. > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel