From: Jules Irenge <jbi.octave@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
Jules Irenge <jbi.octave@gmail.com>,
Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8712: Add comment to lock declaration
Date: Wed, 9 Oct 2019 12:18:55 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.1910091215360.15948@ninjahub.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1910072254290.2578@hadrien>
On Mon, 7 Oct 2019, Julia Lawall wrote:
>
>
> On Mon, 7 Oct 2019, Jules Irenge wrote:
>
>> Add comment to spinlock declaration to fix warning issued by checkpatch.pl
>> "CHECK: spinlock_t definition without comment".
>
> Since it is not apparent from the shown code, it would be helpful to
> describe what evidence you used to choose this comment.
>
> thanks,
> julia
>
Thanks for your feedback, I will leave as it is following the advice of
one of the maintainer. I thought a general term of protecting interrupt
might be appropriate.
Kind regards
Jules
>> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
>> ---
>> drivers/staging/rtl8712/drv_types.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
>> index 0c4325073c63..960d8709aada 100644
>> --- a/drivers/staging/rtl8712/drv_types.h
>> +++ b/drivers/staging/rtl8712/drv_types.h
>> @@ -160,7 +160,7 @@ struct _adapter {
>> int pid; /*process id from UI*/
>> struct work_struct wk_filter_rx_ff0;
>> u8 blnEnableRxFF0Filter;
>> - spinlock_t lock_rx_ff0_filter;
>> + spinlock_t lock_rx_ff0_filter; /*spinlock to protect interrupt request*/
>> const struct firmware *fw;
>> struct usb_interface *pusb_intf;
>> struct mutex mutex_start;
>> --
>> 2.21.0
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191007205248.24466-1-jbi.octave%40gmail.com.
>>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1910072254290.2578%40hadrien.
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-10-09 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 20:52 [PATCH] staging: rtl8712: Add comment to lock declaration Jules Irenge
2019-10-07 20:55 ` [Outreachy kernel] " Julia Lawall
2019-10-09 11:18 ` Jules Irenge [this message]
2019-10-08 6:16 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1910091215360.15948@ninjahub.org \
--to=jbi.octave@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).