From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4995CC4740A for ; Mon, 9 Sep 2019 18:22:39 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A7A7218DE for ; Mon, 9 Sep 2019 18:22:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A7A7218DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7C7FB859BA; Mon, 9 Sep 2019 18:22:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HMv5A3Cj318u; Mon, 9 Sep 2019 18:22:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id D3FA8858DA; Mon, 9 Sep 2019 18:22:36 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C89061BF39F for ; Mon, 9 Sep 2019 18:22:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C5606858DA for ; Mon, 9 Sep 2019 18:22:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3t9pzNu2HfuQ for ; Mon, 9 Sep 2019 18:22:34 +0000 (UTC) X-Greylist: delayed 00:07:38 by SQLgrey-1.7.6 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.142]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 63B1F858D4 for ; Mon, 9 Sep 2019 18:22:34 +0000 (UTC) Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id C9B312400E5 for ; Mon, 9 Sep 2019 20:14:53 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46RxCH3tqVz9rxH; Mon, 9 Sep 2019 20:14:51 +0200 (CEST) Date: Mon, 9 Sep 2019 20:14:50 +0200 (CEST) From: Marc Dietrich X-X-Sender: lucile@macbook-pro.fritz.box To: Hariprasad Kelam Subject: Re: [PATCH] staging: nvec: make use of devm_platform_ioremap_resource In-Reply-To: <1567935662-8006-1-git-send-email-hariprasad.kelam@gmail.com> Message-ID: References: <1567935662-8006-1-git-send-email-hariprasad.kelam@gmail.com> User-Agent: Alpine 2.21 (OSX 202 2017-01-01) MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, ac100@lists.launchpad.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Hariprased, On Sun, 8 Sep 2019, hariprasad@MISSING_DOMAIN wrote: ^^^^^^^^^^^^^^^^^^ something is wrong with your git mail config... > From: Hariprasad Kelam > > fix below issue reported by coccicheck > drivers/staging//nvec/nvec.c:794:1-5: WARNING: Use > devm_platform_ioremap_resource for base > > Signed-off-by: Hariprasad Kelam Acked-by: Marc Dietrich Thanks! Marc > --- > drivers/staging/nvec/nvec.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c > index 1cbd7b7..360ec04 100644 > --- a/drivers/staging/nvec/nvec.c > +++ b/drivers/staging/nvec/nvec.c > @@ -767,7 +767,6 @@ static int tegra_nvec_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct nvec_chip *nvec; > struct nvec_msg *msg; > - struct resource *res; > void __iomem *base; > char get_firmware_version[] = { NVEC_CNTL, GET_FIRMWARE_VERSION }, > unmute_speakers[] = { NVEC_OEM0, 0x10, 0x59, 0x95 }, > @@ -790,8 +789,7 @@ static int tegra_nvec_probe(struct platform_device *pdev) > return -ENODEV; > } > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - base = devm_ioremap_resource(dev, res); > + base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) > return PTR_ERR(base); > > -- > 2.7.4 > > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel