From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21345C433E0 for ; Wed, 3 Feb 2021 11:17:35 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CFD864F61 for ; Wed, 3 Feb 2021 11:17:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CFD864F61 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 41785870EA; Wed, 3 Feb 2021 11:17:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vjbjDj2-C8W6; Wed, 3 Feb 2021 11:17:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 66E758708C; Wed, 3 Feb 2021 11:17:31 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 162861BF386 for ; Wed, 3 Feb 2021 11:17:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 12A5F8708C for ; Wed, 3 Feb 2021 11:17:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id szLwcXvAmW4h for ; Wed, 3 Feb 2021 11:17:28 +0000 (UTC) X-Greylist: delayed 00:07:48 by SQLgrey-1.7.6 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.142]) by hemlock.osuosl.org (Postfix) with ESMTPS id 2E742870D4 for ; Wed, 3 Feb 2021 11:17:28 +0000 (UTC) Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id EC03B2400FB for ; Wed, 3 Feb 2021 12:09:37 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DVzTr4tnqz6tm5; Wed, 3 Feb 2021 12:09:36 +0100 (CET) Date: Wed, 3 Feb 2021 12:09:34 +0100 (CET) From: Marc Dietrich X-X-Sender: lucile@mbpdelurezlocal.fritz.box To: Kumar Kartikeya Dwivedi Subject: Re: [PATCH 05/13] staging: nvec: Switch from strlcpy to strscpy In-Reply-To: <20210131172838.146706-6-memxor@gmail.com> Message-ID: References: <20210131172838.146706-1-memxor@gmail.com> <20210131172838.146706-6-memxor@gmail.com> User-Agent: Alpine 2.23 (OSX 453 2020-06-18) MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-tegra@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Kumar, On Sun, 31 Jan 2021, Kumar Kartikeya Dwivedi wrote: > strlcpy is marked as deprecated in Documentation/process/deprecated.rst, > and there is no functional difference when the caller expects truncation > (when not checking the return value). strscpy is relatively better as it > also avoids scanning the whole source string. > > This silences the related checkpatch warnings from: > 5dbdb2d87c29 ("checkpatch: prefer strscpy to strlcpy") > > Signed-off-by: Kumar Kartikeya Dwivedi > --- > drivers/staging/nvec/nvec_ps2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c > index 45db29262..157009015 100644 > --- a/drivers/staging/nvec/nvec_ps2.c > +++ b/drivers/staging/nvec/nvec_ps2.c > @@ -112,8 +112,8 @@ static int nvec_mouse_probe(struct platform_device *pdev) > ser_dev->start = ps2_startstreaming; > ser_dev->stop = ps2_stopstreaming; > > - strlcpy(ser_dev->name, "nvec mouse", sizeof(ser_dev->name)); > - strlcpy(ser_dev->phys, "nvec", sizeof(ser_dev->phys)); > + strscpy(ser_dev->name, "nvec mouse", sizeof(ser_dev->name)); > + strscpy(ser_dev->phys, "nvec", sizeof(ser_dev->phys)); lgtm, so Acked-by: Marc Dietrich Thanks! Marc _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel