Re: [PATCH] mtd: rawnand: driver for Mediatek MT7621 SoC NAND flash controller

From: Greg Ungerer <gerg@kernel.org>
To: "René van Dorst" <opensource@vdorst.com>
Cc: devel@driverdev.osuosl.org, Weijie Gao <hackpascal@gmail.com>,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	DENG Qingfang <dengqf6@mail2.sysu.edu.cn>,
	linux-mediatek@lists.infradead.org, neil@brown.name,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: rawnand: driver for Mediatek MT7621 SoC NAND flash controller
Date: Fri, 8 Nov 2019 14:46:07 +1000	[thread overview]
Message-ID: <b7e61be8-bd72-a4ef-6fb7-1047c7874342@kernel.org> (raw)
In-Reply-To: <20191107092053.Horde.i3MVcW9RqZDOQBMADZX9fuc@www.vdorst.com>

On 7/11/19 7:20 pm, René van Dorst wrote:
> Quoting gerg@kernel.org:
> 
>> From: Greg Ungerer <gerg@kernel.org>
>>
>> Add a driver to support the NAND flash controller of the MediaTek MT7621
>> System-on-Chip device. (This one is the MIPS based parts from Mediatek).
>>
>> This code is a re-working of the earlier patches for this hardware that
>> have been floating around the internet for years:
>>
>> https://github.com/ReclaimYourPrivacy/cloak/blob/master/target/linux/ramips/patches-3.18/0045-mtd-add-mt7621-nand-support.patch
>>
>> This is a much cleaned up version, put in staging to start with.
>> It does still have some problems, mainly that it still uses a lot of the
>> mtd raw nand legacy support.
>>
>> The driver not only compiles, but it works well on the small range of
>> hardware platforms that it has been used on so far. I have been using
>> for quite a while now, cleaning up as I get time.
>>
>> So... I am looking for comments on the best approach forward with this.
>> At least in staging it can get some more eyeballs going over it.
>>
>> There is a mediatek nand driver already, mtk_nand.c, for their ARM based
>> System-on-Chip devices. That hardware module looks to have some hardware
>> similarities with this one. At this point I don't know if that can be
>> used on the 7621 based devices. (I tried a quick and dirty setup and had
>> no success using it on the 7621).
>>
>> Thoughts?
> 
> +CC DENG Qingfang, Chuanhong Guo, Weijie Gao to the list.
> 
> Hi Greg,
> 
> Thanks for posting this driver.
> 
> But I would like to mention that the openwrt community is currently working on a
> new version which is based a newer version of the MediaTek vendor driver.
> That version is currently targeted for the openwrt 4.19 kernel.
> See full pull request [1] and NAND driver patch [2]
> 
> It would be a shame if duplicate work has been done.

Thanks for pointing that out. I have no particular attachment to the
patch code I sent (I didn't write it). Really just want to see a driver
in mainline.

I am going to spin a v2 of it, lets see how to the 2 drivers stack up
against each other.

Regards
Greg

> [1]: https://github.com/openwrt/openwrt/pull/2385
> [2]: https://github.com/openwrt/openwrt/pull/2385/commits/b2569c0a5943fe8f94ba07c9540ecd14006d729a
> 
> <snip>
> 
> 
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel