From: Colin Ian King <colin.king@canonical.com>
To: Valdis Kletnieks <valdis.kletnieks@vt.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: staging: exfat: issue with FFS_MEDIAERR error return assignment
Date: Fri, 30 Aug 2019 19:38:00 +0100 [thread overview]
Message-ID: <c569b04c-2959-c8eb-0d38-628e8c5ff7ac@canonical.com> (raw)
Hi,
Static analysis on exfat with Coverity has picked up an assignment of
FFS_MEDIAERR that gets over-written:
1750 if (is_dir) {
1751 if ((fid->dir.dir == p_fs->root_dir) &&
1752 (fid->entry == -1)) {
1753 if (p_fs->dev_ejected)
CID 85797 (#1 of 1): Unused value (UNUSED_VALUE)
Assigning value 1 to ret here, but that stored value is overwritten
before it can be used.
1754 ret = FFS_MEDIAERR;
value_overwrite: Overwriting previous write to ret with value 0.
1755 ret = FFS_SUCCESS;
1756 goto out;
1757 }
1758 }
I doubt that's intentional, should it be instead the following?
if (p_fs->dev_ejected)
ret = FFS_MEDIAERR;
else
ret = FFS_SUCCESS;
goto out;
Colin
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next reply other threads:[~2019-08-30 18:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 18:38 Colin Ian King [this message]
2019-09-10 12:44 ` staging: exfat: issue with FFS_MEDIAERR error return assignment Dan Carpenter
2019-09-10 12:58 ` Colin Ian King
2019-09-10 13:09 ` Dan Carpenter
2019-09-10 13:18 ` Valdis Klētnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c569b04c-2959-c8eb-0d38-628e8c5ff7ac@canonical.com \
--to=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).