From: Joe Perches <joe@perches.com>
To: Valery Ivanov <ivalery111@gmail.com>,
rspringer@google.com, toddpoynor@google.com,
benchan@chromium.org, Simon Que <sque@chromium.org>,
John Joseph <jnjoseph@google.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature
Date: Wed, 06 Nov 2019 11:12:09 -0800 [thread overview]
Message-ID: <e3ee9e75d7c25e2d25b74fd1d4709f8dacb79efc.camel@perches.com> (raw)
In-Reply-To: <20191106180821.GA19385@hwsrv-485799.hostwindsdns.com>
On Wed, 2019-11-06 at 18:08 +0000, Valery Ivanov wrote:
> This patch fix the function signature for trace_gasket_ioctl_page_table_data
> to avoid the checkpatch.pl warning:
>
> CHECK: Lines should not end with a '('
>
> Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
All of this stuff is no-op and could just as easily be removed
completely as GASKET_KERNEL_TRACE_SUPPORT is not #defined anywhere.
Is the actual trace #include file supposed to be available somewhere?
#ifdef GASKET_KERNEL_TRACE_SUPPORT
#define CREATE_TRACE_POINTS
#include <trace/events/gasket_ioctl.h>
#else
#define trace_gasket_ioctl_entry(x, ...)
#define trace_gasket_ioctl_exit(x)
#define trace_gasket_ioctl_integer_data(x)
#define trace_gasket_ioctl_eventfd_data(x, ...)
#define trace_gasket_ioctl_page_table_data(x, ...)
#define trace_gasket_ioctl_config_coherent_allocator(x, ...)
#endif
trace file not found...
> ---
> drivers/staging/gasket/gasket_ioctl.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
> index 240f9bb..55cb6b1 100644
> --- a/drivers/staging/gasket/gasket_ioctl.c
> +++ b/drivers/staging/gasket/gasket_ioctl.c
> @@ -54,9 +54,10 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev,
> ibuf.size = gasket_page_table_num_entries(
> gasket_dev->page_table[ibuf.page_table_index]);
>
> - trace_gasket_ioctl_page_table_data(
> - ibuf.page_table_index, ibuf.size, ibuf.host_address,
> - ibuf.device_address);
> + trace_gasket_ioctl_page_table_data(ibuf.page_table_index,
> + ibuf.size,
> + ibuf.host_address,
> + ibuf.device_address);
>
> if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
> return -EFAULT;
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-11-06 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 18:08 [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature Valery Ivanov
2019-11-06 19:12 ` Joe Perches [this message]
2019-11-07 15:09 ` Greg KH
2019-11-07 15:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ee9e75d7c25e2d25b74fd1d4709f8dacb79efc.camel@perches.com \
--to=joe@perches.com \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ivalery111@gmail.com \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=sque@chromium.org \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).