From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE83C5DF63 for ; Wed, 6 Nov 2019 19:12:31 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92A632075C for ; Wed, 6 Nov 2019 19:12:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92A632075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 830248A170; Wed, 6 Nov 2019 19:12:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QWobnnwX7WKr; Wed, 6 Nov 2019 19:12:28 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id D61D18A116; Wed, 6 Nov 2019 19:12:28 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id C1CE31BF3C3 for ; Wed, 6 Nov 2019 19:12:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id BE7718A733 for ; Wed, 6 Nov 2019 19:12:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e9Kkl2gGo25a for ; Wed, 6 Nov 2019 19:12:26 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from smtprelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by hemlock.osuosl.org (Postfix) with ESMTPS id D2D468A703 for ; Wed, 6 Nov 2019 19:12:26 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 3B3AF8384366; Wed, 6 Nov 2019 19:12:24 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: club05_4efb27ab1d741 X-Filterd-Recvd-Size: 2816 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf20.hostedemail.com (Postfix) with ESMTPA; Wed, 6 Nov 2019 19:12:22 +0000 (UTC) Message-ID: Subject: Re: [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature From: Joe Perches To: Valery Ivanov , rspringer@google.com, toddpoynor@google.com, benchan@chromium.org, Simon Que , John Joseph Date: Wed, 06 Nov 2019 11:12:09 -0800 In-Reply-To: <20191106180821.GA19385@hwsrv-485799.hostwindsdns.com> References: <20191106180821.GA19385@hwsrv-485799.hostwindsdns.com> User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, 2019-11-06 at 18:08 +0000, Valery Ivanov wrote: > This patch fix the function signature for trace_gasket_ioctl_page_table_data > to avoid the checkpatch.pl warning: > > CHECK: Lines should not end with a '(' > > Signed-off-by: Valery Ivanov All of this stuff is no-op and could just as easily be removed completely as GASKET_KERNEL_TRACE_SUPPORT is not #defined anywhere. Is the actual trace #include file supposed to be available somewhere? #ifdef GASKET_KERNEL_TRACE_SUPPORT #define CREATE_TRACE_POINTS #include #else #define trace_gasket_ioctl_entry(x, ...) #define trace_gasket_ioctl_exit(x) #define trace_gasket_ioctl_integer_data(x) #define trace_gasket_ioctl_eventfd_data(x, ...) #define trace_gasket_ioctl_page_table_data(x, ...) #define trace_gasket_ioctl_config_coherent_allocator(x, ...) #endif trace file not found... > --- > drivers/staging/gasket/gasket_ioctl.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c > index 240f9bb..55cb6b1 100644 > --- a/drivers/staging/gasket/gasket_ioctl.c > +++ b/drivers/staging/gasket/gasket_ioctl.c > @@ -54,9 +54,10 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev, > ibuf.size = gasket_page_table_num_entries( > gasket_dev->page_table[ibuf.page_table_index]); > > - trace_gasket_ioctl_page_table_data( > - ibuf.page_table_index, ibuf.size, ibuf.host_address, > - ibuf.device_address); > + trace_gasket_ioctl_page_table_data(ibuf.page_table_index, > + ibuf.size, > + ibuf.host_address, > + ibuf.device_address); > > if (copy_to_user(argp, &ibuf, sizeof(ibuf))) > return -EFAULT; _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel