From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7384BC43603 for ; Wed, 4 Dec 2019 20:13:31 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EA78207DD for ; Wed, 4 Dec 2019 20:13:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EA78207DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 1C620232A7; Wed, 4 Dec 2019 20:13:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5+razD4HFYYk; Wed, 4 Dec 2019 20:13:29 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id CEA75232D2; Wed, 4 Dec 2019 20:13:28 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id E91DF1BF5AE for ; Wed, 4 Dec 2019 20:13:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id DDFFB87D33 for ; Wed, 4 Dec 2019 20:13:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uIk-aUU-ihWr for ; Wed, 4 Dec 2019 20:13:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by hemlock.osuosl.org (Postfix) with ESMTPS id EFD6C87BC8 for ; Wed, 4 Dec 2019 20:13:25 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 48F3BB1EC; Wed, 4 Dec 2019 20:13:23 +0000 (UTC) Message-ID: Subject: Re: [PATCH] staging: vchiq: call unregister_chrdev_region() when driver registration fails From: Nicolas Saenz Julienne To: Marcelo Diop-Gonzalez , gregkh@linuxfoundation.org, wahrenst@gmx.net Date: Wed, 04 Dec 2019 21:13:21 +0100 In-Reply-To: <20191203153921.70540-1-marcgonzalez@google.com> References: <20191203153921.70540-1-marcgonzalez@google.com> User-Agent: Evolution 3.34.1 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-rpi-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2078908422313341673==" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" --===============2078908422313341673== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-5919c0yuJGALPpC6G7SP" --=-5919c0yuJGALPpC6G7SP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2019-12-03 at 10:39 -0500, Marcelo Diop-Gonzalez wrote: > This undoes the previous call to alloc_chrdev_region() on failure, > and is probably what was meant originally given the label name. >=20 > Signed-off-by: Marcelo Diop-Gonzalez > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.= c > b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index 02148a24818a..4458c1e60fa3 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -3309,7 +3309,7 @@ static int __init vchiq_driver_init(void) > return 0; > =20 > region_unregister: > - platform_driver_unregister(&vchiq_driver); > + unregister_chrdev_region(vchiq_devid, 1); > =20 > class_destroy: > class_destroy(vchiq_class); Thanks! Reviewed-by: Nicolas Saenz Julienne --=-5919c0yuJGALPpC6G7SP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl3oE2EACgkQlfZmHno8 x/6+sgf9HmeLpXdYIHDUZKujikIFbM9ru2J+O3FWdI+1K+j0y98IptQKpGiIj+H2 sEywi2FeYJ1a9IeApE1yIpiLJv+tASrVe6jd+Z3E3InVg5iaadKe17Ce0ngZYeww xKDomH5Iz3KKT/wyvPhvJSFTltdXNlWFpJ6G9TzUSewg5Hu3PGVYFbaV891HC7yq 125Qs2DdDSJXK/8T/KIjEb0uVSFILXnQgc0tuJIWtWUSl/WJpxPHXSefg3Ujm2Dn CRR+MJUNM+a9zu2rasusqtUrUMrukYCs3brQSdaAXs0m4Gc0TJSjrJ0ex7uwN30T GS0hj1/CJspm74dduNb0xFN6IkPAZQ== =fFRZ -----END PGP SIGNATURE----- --=-5919c0yuJGALPpC6G7SP-- --===============2078908422313341673== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel --===============2078908422313341673==--