From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D58C4740A for ; Tue, 10 Sep 2019 08:43:09 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16DB4208E4 for ; Tue, 10 Sep 2019 08:43:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jKHppvFk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16DB4208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D077783CBF; Tue, 10 Sep 2019 08:43:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5G4r4WFFhz-h; Tue, 10 Sep 2019 08:43:07 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id AAC0882462; Tue, 10 Sep 2019 08:43:07 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id DC4161BF2B6 for ; Tue, 10 Sep 2019 08:43:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D5DC6820FC for ; Tue, 10 Sep 2019 08:43:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bdLmZloH5Ryv for ; Tue, 10 Sep 2019 08:43:06 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by whitealder.osuosl.org (Postfix) with ESMTPS id 0AE2D81FB4 for ; Tue, 10 Sep 2019 08:43:06 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id k6so6219175wrn.11 for ; Tue, 10 Sep 2019 01:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=nfdC2GGtaooPtZtmidwW3K7yrWTHhue1SpTbAz123sM=; b=jKHppvFkO5Gt5906dogykoF3lYe9HZbBaPvbhIUFyv+x7WW/g8Sdj17t4VhfEqZpEB q4k4j3WBTG90HOZP1t2HW994ApnivdCukvcifEY+8RQbGxHF4oTeiUeCH1ywXaT/bcZT GTxMMZ5NKWsd1gCNCOZ25vYup9pxunGCqnTVnrJ6EOLCk5U328VUNYDCrrYSymggX6On 18z3mD1KH5AyFou6teiXOU/rPf+/P6ZIrWLNzyBIJC6FMQKDcIrAqyOc6YAdmgDej+2F 7T49SC1PwKbY8Uyz1vvf3trKAh/IHBpzSKvh6uUF2YuTxi9OlJq4A3CrPj483kpYWcUr 4Rrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=nfdC2GGtaooPtZtmidwW3K7yrWTHhue1SpTbAz123sM=; b=q188V/oX8Bi8LALwZgaka+LYdvoTcnmKytKRipvrJTdo2qrgrJJJ12DGE2qEoyrXsR goRYrwdh4B66urCcbOD/ztgv6WP7L3CL8yXBz0SxO2lebDKJir7VbA5oAu1v66PHt23v QqId3EP93Qv71D/7ZKj2HaJRKO+Ixr6FzbWVVbb2xoTmqecVgkT5rVLmFH7vZxX1VsLb y08iRHaJBJ9lSv1UfamAf4U/gSu+Wdw09gvy2ojnfZx5+bKSBD1ZQl/OZbgQnOwk88Gm J5zb0dA8WZZ0HfHS5ajisBJEx/mUUrsbeF7Ca8ukUbfunz5a8+56qtZsUVCCcF+xqqVC 8bGA== X-Gm-Message-State: APjAAAU6921JIrX24DZS0ZJXI9JL1z7f1i4ZO067MAGDiHldt42yV2Lh xrNSOl7EyHeesxiNLXJGNQ4= X-Google-Smtp-Source: APXvYqydvCw8RjIL5trT9vYV+h75kxjAAQgjOhtgr/ThwUm0YuVUtshKI2bG//L18ev46IW1+a6HAA== X-Received: by 2002:a5d:6604:: with SMTP id n4mr24405862wru.267.1568104984503; Tue, 10 Sep 2019 01:43:04 -0700 (PDT) Received: from arch-late ([148.69.85.38]) by smtp.gmail.com with ESMTPSA id n8sm3473721wma.7.2019.09.10.01.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2019 01:43:03 -0700 (PDT) References: <20190906150823.30859-1-colin.king@canonical.com> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Rui Miguel Silva To: Colin King Subject: Re: [PATCH] media: imx7-mipi-csis: make array 'registers' static const, makes object smaller In-reply-to: <20190906150823.30859-1-colin.king@canonical.com> Date: Tue, 10 Sep 2019 09:43:01 +0100 Message-ID: MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Sascha Hauer , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Philipp Zabel , Steve Longerbeam , Mauro Carvalho Chehab , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Colin, Thanks for the patch. On Fri 06 Sep 2019 at 16:08, Colin King wrote: > From: Colin Ian King > > Don't populate the array 'registers' on the stack but instead make it > static const. Makes the object code smaller by 10 bytes. > > > Before: > text data bss dec hex filename > 20138 5196 128 25462 6376 staging/media/imx/imx7-mipi-csis.o > > After: > text data bss dec hex filename > 20032 5292 128 25452 636c staging/media/imx/imx7-mipi-csis.o > > (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King Looks very good to me. Reviewed-by: Rui Miguel Silva Cheers, Rui > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 73d8354e618c..f8a97b7e2535 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -293,7 +293,7 @@ static int mipi_csis_dump_regs(struct csi_state *state) > struct device *dev = &state->pdev->dev; > unsigned int i; > u32 cfg; > - struct { > + static const struct { > u32 offset; > const char * const name; > } registers[] = { _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel