Smatch reported memory leak bug in rtl8723b_FirmwareDownload function. The problem is pFirmware memory is not released in release_fw1. Instead of redirecting to release_fw1 we can turn it into exit and free the memory. Signed-off-by: F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk> --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index de8caa6cd418..b59c2aa3a9d8 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -436,7 +436,7 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter, bool bUsedWoWLANFw) if (pFirmware->fw_length > FW_8723B_SIZE) { rtStatus = _FAIL; DBG_871X_LEVEL(_drv_emerg_, "Firmware size:%u exceed %u\n", pFirmware->fw_length, FW_8723B_SIZE); - goto release_fw1; + goto exit; } pFirmwareBuf = pFirmware->fw_buffer_sz; @@ -512,7 +512,6 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter, bool bUsedWoWLANFw) exit: kfree(pFirmware->fw_buffer_sz); kfree(pFirmware); -release_fw1: kfree(pBTFirmware); DBG_871X(" <=== rtl8723b_FirmwareDownload()\n"); return rtStatus; -- 2.17.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next branch HEAD: 4adb389e08c95fdf91995271932c59250ff0d561 staging: vt6655: Remove filenames in files Warning reports: https://lore.kernel.org/lkml/202107310213.WGo8CZVI-lkp@intel.com Warning in current branch: drivers/staging/r8188eu/core/rtw_ieee80211.c:884: warning: expecting prototype for ieee802_11_parse_elems(). Prototype was for rtw_ieee802_11_parse_elems() instead drivers/staging/r8188eu/core/rtw_security.c:1627: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/staging/r8188eu/core/rtw_security.c:1652: warning: expecting prototype for omac1_aes_128(). Prototype was for rtw_use_tkipkey_handler() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:104: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_SetBBReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:144: warning: expecting prototype for Function(). Prototype was for phy_RFSerialRead() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:243: warning: expecting prototype for Function(). Prototype was for phy_RFSerialWrite() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:287: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_QueryRFReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:323: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_SetRFReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:389: warning: expecting prototype for Function(). Prototype was for phy_InitBBRFRegisterDefinition() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:46: warning: expecting prototype for Function(). Prototype was for phy_CalculateBitShift() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:76: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_QueryBBReg() instead drivers/staging/r8188eu/os_dep/rtw_android.c:52: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Warning ids grouped by kconfigs: gcc_recent_errors |-- arc-allyesconfig | |-- drivers-staging-r8188eu-core-rtw_ieee80211.c:warning:expecting-prototype-for-ieee802_11_parse_elems().-Prototype-was-for-rtw_ieee802_11_parse_elems()-instead | |-- drivers-staging-r8188eu-core-rtw_security.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst | |-- drivers-staging-r8188eu-core-rtw_security.c:warning:expecting-prototype-for-omac1_aes_128().-Prototype-was-for-rtw_use_tkipkey_handler()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_CalculateBitShift()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_InitBBRFRegisterDefinition()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialRead()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialWrite()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryBBReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryRFReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetBBReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetRFReg()-instead | `-- drivers-staging-r8188eu-os_dep-rtw_android.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst |-- m68k-allmodconfig | |-- drivers-staging-r8188eu-core-rtw_ieee80211.c:warning:expecting-prototype-for-ieee802_11_parse_elems().-Prototype-was-for-rtw_ieee802_11_parse_elems()-instead | |-- drivers-staging-r8188eu-core-rtw_security.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst | |-- drivers-staging-r8188eu-core-rtw_security.c:warning:expecting-prototype-for-omac1_aes_128().-Prototype-was-for-rtw_use_tkipkey_handler()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_CalculateBitShift()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_InitBBRFRegisterDefinition()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialRead()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialWrite()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryBBReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryRFReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetBBReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetRFReg()-instead | `-- drivers-staging-r8188eu-os_dep-rtw_android.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst |-- m68k-allyesconfig | |-- drivers-staging-r8188eu-core-rtw_ieee80211.c:warning:expecting-prototype-for-ieee802_11_parse_elems().-Prototype-was-for-rtw_ieee802_11_parse_elems()-instead | |-- drivers-staging-r8188eu-core-rtw_security.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst | |-- drivers-staging-r8188eu-core-rtw_security.c:warning:expecting-prototype-for-omac1_aes_128().-Prototype-was-for-rtw_use_tkipkey_handler()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_CalculateBitShift()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_InitBBRFRegisterDefinition()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialRead()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialWrite()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryBBReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryRFReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetBBReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetRFReg()-instead | `-- drivers-staging-r8188eu-os_dep-rtw_android.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst `-- sh-allmodconfig |-- drivers-staging-r8188eu-core-rtw_ieee80211.c:warning:expecting-prototype-for-ieee802_11_parse_elems().-Prototype-was-for-rtw_ieee802_11_parse_elems()-instead |-- drivers-staging-r8188eu-core-rtw_security.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst |-- drivers-staging-r8188eu-core-rtw_security.c:warning:expecting-prototype-for-omac1_aes_128().-Prototype-was-for-rtw_use_tkipkey_handler()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_CalculateBitShift()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_InitBBRFRegisterDefinition()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialRead()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialWrite()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryBBReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryRFReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetBBReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetRFReg()-instead `-- drivers-staging-r8188eu-os_dep-rtw_android.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst elapsed time: 725m configs tested: 174 configs skipped: 4 gcc tested configs: arm64 allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig arm defconfig arc hsdk_defconfig arm lpc32xx_defconfig sh sh2007_defconfig sh se7705_defconfig mips tb0287_defconfig powerpc mpc8540_ads_defconfig powerpc canyonlands_defconfig arm at91_dt_defconfig mips fuloong2e_defconfig sh ecovec24-romimage_defconfig powerpc g5_defconfig sh ecovec24_defconfig mips ip27_defconfig arc vdk_hs38_smp_defconfig arm netwinder_defconfig openrisc simple_smp_defconfig xtensa nommu_kc705_defconfig arm qcom_defconfig powerpc mgcoge_defconfig powerpc obs600_defconfig mips maltaup_defconfig m68k m5275evb_defconfig mips loongson2k_defconfig arc haps_hs_defconfig powerpc sbc8548_defconfig arm lubbock_defconfig powerpc katmai_defconfig m68k mvme147_defconfig sh kfr2r09-romimage_defconfig powerpc ebony_defconfig sh espt_defconfig arm mvebu_v7_defconfig sh sh7785lcr_defconfig sh se7722_defconfig sh se7751_defconfig ia64 generic_defconfig sh rsk7201_defconfig sh se7780_defconfig powerpc warp_defconfig arm badge4_defconfig xtensa common_defconfig parisc alldefconfig powerpc fsp2_defconfig arm cerfcube_defconfig arm bcm2835_defconfig powerpc makalu_defconfig m68k multi_defconfig sh apsh4a3a_defconfig arm keystone_defconfig sh edosk7705_defconfig m68k allmodconfig powerpc bamboo_defconfig powerpc ppc64e_defconfig arm colibri_pxa270_defconfig powerpc sam440ep_defconfig arm socfpga_defconfig parisc defconfig powerpc holly_defconfig mips rt305x_defconfig arm axm55xx_defconfig arm sama5_defconfig sparc sparc32_defconfig mips loongson3_defconfig arm davinci_all_defconfig powerpc lite5200b_defconfig arm assabet_defconfig sh sh7785lcr_32bit_defconfig powerpc ppc44x_defconfig powerpc iss476-smp_defconfig powerpc chrp32_defconfig arc haps_hs_smp_defconfig mips maltaup_xpa_defconfig powerpc kilauea_defconfig arm sunxi_defconfig microblaze defconfig x86_64 allnoconfig ia64 allmodconfig ia64 defconfig ia64 allyesconfig m68k defconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig nds32 defconfig nios2 allyesconfig csky defconfig alpha defconfig alpha allyesconfig xtensa allyesconfig h8300 allyesconfig arc defconfig sh allmodconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390 defconfig i386 allyesconfig sparc allyesconfig sparc defconfig i386 defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a001-20210828 i386 randconfig-a006-20210828 i386 randconfig-a002-20210828 i386 randconfig-a005-20210828 i386 randconfig-a003-20210828 i386 randconfig-a004-20210828 x86_64 randconfig-a014-20210827 x86_64 randconfig-a015-20210827 x86_64 randconfig-a016-20210827 x86_64 randconfig-a013-20210827 x86_64 randconfig-a012-20210827 x86_64 randconfig-a011-20210827 i386 randconfig-a011-20210827 i386 randconfig-a016-20210827 i386 randconfig-a012-20210827 i386 randconfig-a014-20210827 i386 randconfig-a013-20210827 i386 randconfig-a015-20210827 arc randconfig-r043-20210829 riscv randconfig-r042-20210829 s390 randconfig-r044-20210829 arc randconfig-r043-20210827 riscv randconfig-r042-20210827 s390 randconfig-r044-20210827 riscv nommu_k210_defconfig riscv allyesconfig riscv nommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscv allmodconfig x86_64 rhel-8.3-kselftests um x86_64_defconfig um i386_defconfig x86_64 allyesconfig x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec clang tested configs: i386 randconfig-c001-20210828 s390 randconfig-c005-20210828 arm randconfig-c002-20210828 riscv randconfig-c006-20210828 x86_64 randconfig-c007-20210828 mips randconfig-c004-20210828 s390 randconfig-c005-20210827 i386 randconfig-c001-20210827 arm randconfig-c002-20210827 riscv randconfig-c006-20210827 powerpc randconfig-c003-20210827 x86_64 randconfig-c007-20210827 mips randconfig-c004-20210827 x86_64 randconfig-a005-20210827 x86_64 randconfig-a001-20210827 x86_64 randconfig-a006-20210827 x86_64 randconfig-a003-20210827 x86_64 randconfig-a004-20210827 x86_64 randconfig-a002-20210827 i386 randconfig-a006-20210827 i386 randconfig-a001-20210827 i386 randconfig-a002-20210827 i386 randconfig-a005-20210827 i386 randconfig-a004-20210827 i386 randconfig-a003-20210827 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: f6bc526accf861728d36b12fbc25ac94cd057fc9 staging: r8188eu: rename fields of struct rtl_ps Warning reports: https://lore.kernel.org/lkml/202107310213.WGo8CZVI-lkp@intel.com Warning in current branch: drivers/staging/r8188eu/core/rtw_ieee80211.c:884: warning: expecting prototype for ieee802_11_parse_elems(). Prototype was for rtw_ieee802_11_parse_elems() instead drivers/staging/r8188eu/core/rtw_security.c:1627: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/staging/r8188eu/core/rtw_security.c:1652: warning: expecting prototype for omac1_aes_128(). Prototype was for rtw_use_tkipkey_handler() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:104: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_SetBBReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:144: warning: expecting prototype for Function(). Prototype was for phy_RFSerialRead() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:243: warning: expecting prototype for Function(). Prototype was for phy_RFSerialWrite() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:287: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_QueryRFReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:323: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_SetRFReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:389: warning: expecting prototype for Function(). Prototype was for phy_InitBBRFRegisterDefinition() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:46: warning: expecting prototype for Function(). Prototype was for phy_CalculateBitShift() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:76: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_QueryBBReg() instead drivers/staging/r8188eu/os_dep/rtw_android.c:52: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Warning ids grouped by kconfigs: gcc_recent_errors `-- sh-allmodconfig |-- drivers-staging-r8188eu-core-rtw_ieee80211.c:warning:expecting-prototype-for-ieee802_11_parse_elems().-Prototype-was-for-rtw_ieee802_11_parse_elems()-instead |-- drivers-staging-r8188eu-core-rtw_security.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst |-- drivers-staging-r8188eu-core-rtw_security.c:warning:expecting-prototype-for-omac1_aes_128().-Prototype-was-for-rtw_use_tkipkey_handler()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_CalculateBitShift()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_InitBBRFRegisterDefinition()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialRead()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialWrite()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryBBReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryRFReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetBBReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetRFReg()-instead `-- drivers-staging-r8188eu-os_dep-rtw_android.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst elapsed time: 722m configs tested: 111 configs skipped: 4 gcc tested configs: arm defconfig arm64 allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig powerpc cm5200_defconfig arm milbeaut_m10v_defconfig powerpc tqm8548_defconfig ia64 gensparse_defconfig sh sh7785lcr_defconfig arm imx_v4_v5_defconfig parisc defconfig mips xway_defconfig mips maltaup_defconfig arm palmz72_defconfig sh se7722_defconfig sh se7751_defconfig ia64 generic_defconfig sh rsk7201_defconfig sh se7780_defconfig powerpc warp_defconfig m68k mvme147_defconfig arm badge4_defconfig xtensa common_defconfig arm bcm2835_defconfig powerpc makalu_defconfig m68k multi_defconfig arm lpc18xx_defconfig arc vdk_hs38_smp_defconfig arm vexpress_defconfig powerpc ppc44x_defconfig ia64 allmodconfig ia64 defconfig ia64 allyesconfig x86_64 allnoconfig m68k allmodconfig m68k defconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig nds32 defconfig nios2 allyesconfig csky defconfig alpha defconfig alpha allyesconfig xtensa allyesconfig h8300 allyesconfig arc defconfig sh allmodconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390 defconfig i386 allyesconfig sparc allyesconfig sparc defconfig i386 defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a014-20210827 x86_64 randconfig-a015-20210827 x86_64 randconfig-a016-20210827 x86_64 randconfig-a013-20210827 x86_64 randconfig-a012-20210827 x86_64 randconfig-a011-20210827 i386 randconfig-a011-20210827 i386 randconfig-a016-20210827 i386 randconfig-a012-20210827 i386 randconfig-a014-20210827 i386 randconfig-a013-20210827 i386 randconfig-a015-20210827 arc randconfig-r043-20210827 riscv randconfig-r042-20210827 s390 randconfig-r044-20210827 riscv nommu_k210_defconfig riscv allyesconfig riscv nommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscv allmodconfig um x86_64_defconfig um i386_defconfig x86_64 allyesconfig x86_64 rhel-8.3-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec clang tested configs: s390 randconfig-c005-20210827 i386 randconfig-c001-20210827 arm randconfig-c002-20210827 riscv randconfig-c006-20210827 powerpc randconfig-c003-20210827 x86_64 randconfig-c007-20210827 mips randconfig-c004-20210827 x86_64 randconfig-a005-20210827 x86_64 randconfig-a001-20210827 x86_64 randconfig-a006-20210827 x86_64 randconfig-a003-20210827 x86_64 randconfig-a004-20210827 x86_64 randconfig-a002-20210827 i386 randconfig-a006-20210827 i386 randconfig-a001-20210827 i386 randconfig-a002-20210827 i386 randconfig-a005-20210827 i386 randconfig-a004-20210827 i386 randconfig-a003-20210827 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
checkpatch.pl warning: It's generally not useful to have the filename in the file Remove the filenames. Signed-off-by: Aldas Taraškevičius <aldas60@gmail.com> --- drivers/staging/vt6656/baseband.c | 2 -- drivers/staging/vt6656/baseband.h | 2 -- drivers/staging/vt6656/card.c | 1 - drivers/staging/vt6656/card.h | 2 -- drivers/staging/vt6656/channel.c | 2 -- drivers/staging/vt6656/channel.h | 2 -- drivers/staging/vt6656/desc.h | 2 -- drivers/staging/vt6656/device.h | 2 -- drivers/staging/vt6656/key.c | 2 -- drivers/staging/vt6656/key.h | 2 -- drivers/staging/vt6656/mac.c | 2 -- drivers/staging/vt6656/mac.h | 2 -- drivers/staging/vt6656/main_usb.c | 2 -- drivers/staging/vt6656/power.c | 2 -- drivers/staging/vt6656/power.h | 2 -- drivers/staging/vt6656/rf.c | 2 -- drivers/staging/vt6656/rf.h | 2 -- drivers/staging/vt6656/rxtx.c | 2 -- drivers/staging/vt6656/rxtx.h | 2 -- drivers/staging/vt6656/usbpipe.c | 2 -- drivers/staging/vt6656/usbpipe.h | 2 -- drivers/staging/vt6656/wcmd.c | 2 -- drivers/staging/vt6656/wcmd.h | 2 -- 23 files changed, 45 deletions(-) diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c index 41ae779ec61f..1e1c5a7d8968 100644 --- a/drivers/staging/vt6656/baseband.c +++ b/drivers/staging/vt6656/baseband.c @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: baseband.c - * * Purpose: Implement functions to access baseband * * Author: Jerry Chen diff --git a/drivers/staging/vt6656/baseband.h b/drivers/staging/vt6656/baseband.h index 12456ebc23ec..dce50a311f24 100644 --- a/drivers/staging/vt6656/baseband.h +++ b/drivers/staging/vt6656/baseband.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: baseband.h - * * Purpose: Implement functions to access baseband * * Author: Jerry Chen diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c index 396736eee690..e92ecfad26d2 100644 --- a/drivers/staging/vt6656/card.c +++ b/drivers/staging/vt6656/card.c @@ -3,7 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: card.c * Purpose: Provide functions to setup NIC operation mode * Functions: * vnt_set_rspinf - Set RSPINF diff --git a/drivers/staging/vt6656/card.h b/drivers/staging/vt6656/card.h index a524fdc60ae3..be32c25c95de 100644 --- a/drivers/staging/vt6656/card.h +++ b/drivers/staging/vt6656/card.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: card.h - * * Purpose: Provide functions to setup NIC operation mode * * Author: Tevin Chen diff --git a/drivers/staging/vt6656/channel.c b/drivers/staging/vt6656/channel.c index 7855689af7cb..eb2d52e6420b 100644 --- a/drivers/staging/vt6656/channel.c +++ b/drivers/staging/vt6656/channel.c @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: channel.c - * * Purpose: Channel number mapping * * Author: Lucas Lin diff --git a/drivers/staging/vt6656/channel.h b/drivers/staging/vt6656/channel.h index cca330f0daf4..723660e40310 100644 --- a/drivers/staging/vt6656/channel.h +++ b/drivers/staging/vt6656/channel.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: channel.h - * * Purpose: Country Regulation Rules header file * * Author: Lucas Lin diff --git a/drivers/staging/vt6656/desc.h b/drivers/staging/vt6656/desc.h index 703597a911f4..c13561e528db 100644 --- a/drivers/staging/vt6656/desc.h +++ b/drivers/staging/vt6656/desc.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: desc.h - * * Purpose:The header file of descriptor * * Revision History: diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h index 2c93a2e66c8a..8b6623a751f0 100644 --- a/drivers/staging/vt6656/device.h +++ b/drivers/staging/vt6656/device.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: device.h - * * Purpose: MAC Data structure * * Author: Tevin Chen diff --git a/drivers/staging/vt6656/key.c b/drivers/staging/vt6656/key.c index 70f75c5760ce..bdc5f30c4f9d 100644 --- a/drivers/staging/vt6656/key.c +++ b/drivers/staging/vt6656/key.c @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: key.c - * * Purpose: Implement functions for 802.11i Key management * * Author: Jerry Chen diff --git a/drivers/staging/vt6656/key.h b/drivers/staging/vt6656/key.h index 1f3449e66143..6f1d5b4f6da7 100644 --- a/drivers/staging/vt6656/key.h +++ b/drivers/staging/vt6656/key.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: key.h - * * Purpose: Implement functions for 802.11i Key management * * Author: Jerry Chen diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c index da7067c34643..4f1f9b03a678 100644 --- a/drivers/staging/vt6656/mac.c +++ b/drivers/staging/vt6656/mac.c @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: mac.c - * * Purpose: MAC routines * * Author: Tevin Chen diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h index dae70b5c7634..05af9ca7d69c 100644 --- a/drivers/staging/vt6656/mac.h +++ b/drivers/staging/vt6656/mac.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: mac.h - * * Purpose: MAC routines * * Author: Tevin Chen diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index b90d3dab28b1..ae7f5916d4d6 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: main_usb.c - * * Purpose: driver entry for initial, open, close, tx and rx. * * Author: Lyndon Chen diff --git a/drivers/staging/vt6656/power.c b/drivers/staging/vt6656/power.c index 2f49c870272a..e5411f6284c7 100644 --- a/drivers/staging/vt6656/power.c +++ b/drivers/staging/vt6656/power.c @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: power.c - * * Purpose: Handles 802.11 power management functions * * Author: Lyndon Chen diff --git a/drivers/staging/vt6656/power.h b/drivers/staging/vt6656/power.h index 160872026db3..9f9c70072933 100644 --- a/drivers/staging/vt6656/power.h +++ b/drivers/staging/vt6656/power.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: power.h - * * Purpose: Handles 802.11 power management functions * * Author: Lyndon Chen diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c index bcd4d467e03a..b9c06b312ae1 100644 --- a/drivers/staging/vt6656/rf.c +++ b/drivers/staging/vt6656/rf.c @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: rf.c - * * Purpose: rf function code * * Author: Jerry Chen diff --git a/drivers/staging/vt6656/rf.h b/drivers/staging/vt6656/rf.h index 493faaf4e2b5..b47e149875d1 100644 --- a/drivers/staging/vt6656/rf.h +++ b/drivers/staging/vt6656/rf.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: rf.h - * * Purpose: * * Author: Jerry Chen diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index 5dd6b4d2bf20..a31947f2620d 100644 --- a/drivers/staging/vt6656/rxtx.c +++ b/drivers/staging/vt6656/rxtx.c @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: rxtx.c - * * Purpose: handle WMAC/802.3/802.11 rx & tx functions * * Author: Lyndon Chen diff --git a/drivers/staging/vt6656/rxtx.h b/drivers/staging/vt6656/rxtx.h index f23440799443..b9df0854b4b0 100644 --- a/drivers/staging/vt6656/rxtx.h +++ b/drivers/staging/vt6656/rxtx.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: rxtx.h - * * Purpose: * * Author: Jerry Chen diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c index 82b774be6485..7f45734390f6 100644 --- a/drivers/staging/vt6656/usbpipe.c +++ b/drivers/staging/vt6656/usbpipe.c @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: usbpipe.c - * * Purpose: Handle USB control endpoint * * Author: Warren Hsu diff --git a/drivers/staging/vt6656/usbpipe.h b/drivers/staging/vt6656/usbpipe.h index 52c2a928c9c1..922312e299bf 100644 --- a/drivers/staging/vt6656/usbpipe.h +++ b/drivers/staging/vt6656/usbpipe.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: usbpipe.h - * * Purpose: * * Author: Warren Hsu diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c index 0ccc87da394e..e8ee2fbee76c 100644 --- a/drivers/staging/vt6656/wcmd.c +++ b/drivers/staging/vt6656/wcmd.c @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: wcmd.c - * * Purpose: Handles the management command interface functions * * Author: Lyndon Chen diff --git a/drivers/staging/vt6656/wcmd.h b/drivers/staging/vt6656/wcmd.h index a0d98cf74998..a62924671b17 100644 --- a/drivers/staging/vt6656/wcmd.h +++ b/drivers/staging/vt6656/wcmd.h @@ -3,8 +3,6 @@ * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. * - * File: wcmd.h - * * Purpose: Handles the management command interface functions * * Author: Lyndon Chen -- 2.30.2 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: ce6a7007048b0abcf263a2b43a63d18614802e53 staging: r8188eu: remove {read,write}_macreg elapsed time: 740m configs tested: 153 configs skipped: 3 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64 allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig i386 randconfig-c001-20210826 sh se7722_defconfig powerpc powernv_defconfig powerpc warp_defconfig mips loongson3_defconfig powerpc mpc834x_itx_defconfig sh microdev_defconfig arm netwinder_defconfig arm mv78xx0_defconfig ia64 gensparse_defconfig mips loongson1b_defconfig arc nsimosci_hs_smp_defconfig arm keystone_defconfig xtensa alldefconfig arm oxnas_v6_defconfig nds32 alldefconfig powerpc ge_imp3a_defconfig sh rsk7269_defconfig powerpc mpc837x_mds_defconfig arm integrator_defconfig mips loongson2k_defconfig powerpc ep88xc_defconfig mips bigsur_defconfig arm mxs_defconfig x86_64 alldefconfig m68k mac_defconfig sh rsk7201_defconfig s390 debug_defconfig powerpc mpc8272_ads_defconfig arc hsdk_defconfig arm h5000_defconfig arm mps2_defconfig powerpc mpc836x_mds_defconfig sh rts7751r2d1_defconfig powerpc mgcoge_defconfig m68k m5249evb_defconfig arm pcm027_defconfig arm milbeaut_m10v_defconfig sh lboxre2_defconfig h8300 h8s-sim_defconfig sh urquell_defconfig arm corgi_defconfig sh sdk7780_defconfig mips malta_defconfig arm ep93xx_defconfig ia64 alldefconfig powerpc icon_defconfig sh edosk7760_defconfig arm64 alldefconfig powerpc ppc64e_defconfig mips bcm47xx_defconfig powerpc ppc40x_defconfig arm multi_v5_defconfig powerpc pseries_defconfig arm omap1_defconfig powerpc storcenter_defconfig arm spear13xx_defconfig xtensa generic_kc705_defconfig powerpc mpc832x_rdb_defconfig arm h3600_defconfig mips tb0226_defconfig m68k sun3_defconfig arm ixp4xx_defconfig arm vt8500_v6_v7_defconfig arm shannon_defconfig sparc sparc64_defconfig microblaze mmu_defconfig x86_64 allnoconfig ia64 allmodconfig ia64 defconfig ia64 allyesconfig m68k allmodconfig m68k defconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig nds32 defconfig nios2 allyesconfig csky defconfig alpha defconfig alpha allyesconfig xtensa allyesconfig h8300 allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390 defconfig i386 allyesconfig sparc allyesconfig sparc defconfig i386 defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a005-20210826 x86_64 randconfig-a006-20210826 x86_64 randconfig-a001-20210826 x86_64 randconfig-a003-20210826 x86_64 randconfig-a004-20210826 x86_64 randconfig-a002-20210826 i386 randconfig-a006-20210826 i386 randconfig-a001-20210826 i386 randconfig-a002-20210826 i386 randconfig-a005-20210826 i386 randconfig-a003-20210826 i386 randconfig-a004-20210826 riscv nommu_k210_defconfig riscv allyesconfig riscv nommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscv allmodconfig x86_64 rhel-8.3-kselftests um x86_64_defconfig um i386_defconfig x86_64 allyesconfig x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec clang tested configs: i386 randconfig-c001-20210826 s390 randconfig-c005-20210826 arm randconfig-c002-20210826 riscv randconfig-c006-20210826 powerpc randconfig-c003-20210826 x86_64 randconfig-c007-20210826 mips randconfig-c004-20210826 x86_64 randconfig-a014-20210826 x86_64 randconfig-a015-20210826 x86_64 randconfig-a016-20210826 x86_64 randconfig-a013-20210826 x86_64 randconfig-a012-20210826 x86_64 randconfig-a011-20210826 i386 randconfig-a011-20210826 i386 randconfig-a016-20210826 i386 randconfig-a012-20210826 i386 randconfig-a014-20210826 i386 randconfig-a013-20210826 i386 randconfig-a015-20210826 hexagon randconfig-r041-20210826 hexagon randconfig-r045-20210826 riscv randconfig-r042-20210826 s390 randconfig-r044-20210826 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Google for how to format a v2 patch. On Mon, Aug 16, 2021 at 08:04:47PM +0200, Leon Krieg wrote: > By doing some last-second wording changes directly in the diff I've > screwed up and managed to use spaces instead of tabs for the Kconfig file. > This is embarrassing! > I love adding backstory to my commit messages and but this is a bit much. :P Just say "Use tabs instead of spaces". Add the backstory under the --- cut off line if necessary. Also it doesn't just change the Kconfig file. There are a lot of unrelated changes as well. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Greetings, I wish to solicit for a moment of your bustling schedule to discuss a 100% legitimate business preposition with you that is worth some fortune. If intrigued do reply and I will finish you with full insights regarding the business. Sincerely, Gang Wu _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Greetings, I wish to solicit for a moment of your bustling schedule to discuss a 100% legitimate business preposition with you that is worth some fortune. If intrigued do reply and I will finish you with full insights regarding the business. Sincerely, Gang Wu _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next branch HEAD: 093991aaadf0fbb34184fa37a46e7a157da3f386 staging: r8188eu: Remove empty rtw_mfree_xmit_priv_lock() Warning reports: https://lore.kernel.org/lkml/202107310213.WGo8CZVI-lkp@intel.com Warning in current branch: drivers/staging/r8188eu/core/rtw_ieee80211.c:884: warning: expecting prototype for ieee802_11_parse_elems(). Prototype was for rtw_ieee802_11_parse_elems() instead drivers/staging/r8188eu/core/rtw_security.c:1627: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/staging/r8188eu/core/rtw_security.c:1652: warning: expecting prototype for omac1_aes_128(). Prototype was for rtw_use_tkipkey_handler() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:104: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_SetBBReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:144: warning: expecting prototype for Function(). Prototype was for phy_RFSerialRead() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:243: warning: expecting prototype for Function(). Prototype was for phy_RFSerialWrite() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:287: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_QueryRFReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:323: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_SetRFReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:389: warning: expecting prototype for Function(). Prototype was for phy_InitBBRFRegisterDefinition() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:46: warning: expecting prototype for Function(). Prototype was for phy_CalculateBitShift() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:76: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_QueryBBReg() instead drivers/staging/r8188eu/os_dep/rtw_android.c:52: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Warning ids grouped by kconfigs: gcc_recent_errors |-- m68k-allmodconfig | |-- drivers-staging-r8188eu-core-rtw_ieee80211.c:warning:expecting-prototype-for-ieee802_11_parse_elems().-Prototype-was-for-rtw_ieee802_11_parse_elems()-instead | |-- drivers-staging-r8188eu-core-rtw_security.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst | |-- drivers-staging-r8188eu-core-rtw_security.c:warning:expecting-prototype-for-omac1_aes_128().-Prototype-was-for-rtw_use_tkipkey_handler()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_CalculateBitShift()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_InitBBRFRegisterDefinition()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialRead()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialWrite()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryBBReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryRFReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetBBReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetRFReg()-instead | `-- drivers-staging-r8188eu-os_dep-rtw_android.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst |-- m68k-allyesconfig | |-- drivers-staging-r8188eu-core-rtw_ieee80211.c:warning:expecting-prototype-for-ieee802_11_parse_elems().-Prototype-was-for-rtw_ieee802_11_parse_elems()-instead | |-- drivers-staging-r8188eu-core-rtw_security.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst | |-- drivers-staging-r8188eu-core-rtw_security.c:warning:expecting-prototype-for-omac1_aes_128().-Prototype-was-for-rtw_use_tkipkey_handler()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_CalculateBitShift()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_InitBBRFRegisterDefinition()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialRead()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialWrite()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryBBReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryRFReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetBBReg()-instead | |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetRFReg()-instead | `-- drivers-staging-r8188eu-os_dep-rtw_android.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst `-- nds32-allyesconfig |-- drivers-staging-r8188eu-core-rtw_ieee80211.c:warning:expecting-prototype-for-ieee802_11_parse_elems().-Prototype-was-for-rtw_ieee802_11_parse_elems()-instead |-- drivers-staging-r8188eu-core-rtw_security.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst |-- drivers-staging-r8188eu-core-rtw_security.c:warning:expecting-prototype-for-omac1_aes_128().-Prototype-was-for-rtw_use_tkipkey_handler()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_CalculateBitShift()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_InitBBRFRegisterDefinition()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialRead()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialWrite()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryBBReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryRFReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetBBReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetRFReg()-instead `-- drivers-staging-r8188eu-os_dep-rtw_android.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst elapsed time: 1194m configs tested: 108 configs skipped: 3 gcc tested configs: arm defconfig arm64 allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig i386 randconfig-c001-20210819 h8300 h8s-sim_defconfig powerpc maple_defconfig sh se7751_defconfig arm realview_defconfig mips loongson3_defconfig s390 defconfig sh rsk7269_defconfig arm64 alldefconfig sh apsh4ad0a_defconfig mips bmips_be_defconfig m68k defconfig powerpc mpc837x_rdb_defconfig m68k mac_defconfig powerpc currituck_defconfig sh sh7785lcr_32bit_defconfig arm lpd270_defconfig powerpc mpc8315_rdb_defconfig powerpc mpc8540_ads_defconfig powerpc mpc83xx_defconfig ia64 gensparse_defconfig x86_64 allnoconfig ia64 allmodconfig ia64 defconfig ia64 allyesconfig m68k allmodconfig m68k allyesconfig nds32 defconfig nios2 allyesconfig csky defconfig alpha defconfig alpha allyesconfig xtensa allyesconfig h8300 allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig i386 allyesconfig sparc allyesconfig sparc defconfig i386 defconfig nios2 defconfig arc allyesconfig nds32 allnoconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20210818 x86_64 randconfig-a006-20210818 x86_64 randconfig-a003-20210818 x86_64 randconfig-a005-20210818 x86_64 randconfig-a002-20210818 x86_64 randconfig-a001-20210818 i386 randconfig-a004-20210818 i386 randconfig-a006-20210818 i386 randconfig-a002-20210818 i386 randconfig-a001-20210818 i386 randconfig-a003-20210818 i386 randconfig-a005-20210818 i386 randconfig-a015-20210819 i386 randconfig-a011-20210819 i386 randconfig-a014-20210819 i386 randconfig-a013-20210819 i386 randconfig-a016-20210819 i386 randconfig-a012-20210819 riscv nommu_k210_defconfig riscv allyesconfig riscv nommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscv allmodconfig x86_64 rhel-8.3-kselftests um x86_64_defconfig um i386_defconfig x86_64 allyesconfig x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec clang tested configs: i386 randconfig-c001-20210818 i386 randconfig-c001-20210819 x86_64 randconfig-a004-20210819 x86_64 randconfig-a006-20210819 x86_64 randconfig-a003-20210819 x86_64 randconfig-a002-20210819 x86_64 randconfig-a005-20210819 x86_64 randconfig-a001-20210819 i386 randconfig-a004-20210819 i386 randconfig-a006-20210819 i386 randconfig-a001-20210819 i386 randconfig-a002-20210819 i386 randconfig-a003-20210819 i386 randconfig-a005-20210819 x86_64 randconfig-a013-20210818 x86_64 randconfig-a011-20210818 x86_64 randconfig-a012-20210818 x86_64 randconfig-a016-20210818 x86_64 randconfig-a014-20210818 x86_64 randconfig-a015-20210818 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing branch HEAD: bd1e336aa8535a99f339e2d66a611984262221ce driver core: platform: Remove platform_device_add_properties() elapsed time: 1397m configs tested: 166 configs skipped: 3 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64 allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig i386 randconfig-c001-20210816 i386 randconfig-c001-20210818 powerpc ep88xc_defconfig arm at91_dt_defconfig powerpc mpc832x_rdb_defconfig mips loongson1c_defconfig arm mvebu_v5_defconfig powerpc mpc834x_itx_defconfig powerpc ep8248e_defconfig arm pleb_defconfig arm xcep_defconfig powerpc skiroot_defconfig powerpc icon_defconfig mips ip27_defconfig arm bcm2835_defconfig m68k m5307c3_defconfig arm mv78xx0_defconfig sh magicpanelr2_defconfig alpha alldefconfig sh sh7710voipgw_defconfig powerpc mpc834x_itxgp_defconfig sh shx3_defconfig um defconfig powerpc mpc834x_mds_defconfig arm aspeed_g4_defconfig nios2 10m50_defconfig m68k m5249evb_defconfig m68k bvme6000_defconfig microblaze defconfig sh r7780mp_defconfig x86_64 alldefconfig mips jmr3927_defconfig powerpc acadia_defconfig mips sb1250_swarm_defconfig arm colibri_pxa300_defconfig sh sh7724_generic_defconfig sparc alldefconfig x86_64 allyesconfig mips rm200_defconfig sh sh7770_generic_defconfig arm iop32x_defconfig m68k mac_defconfig powerpc currituck_defconfig sh sh7785lcr_32bit_defconfig arm lpd270_defconfig powerpc mpc8315_rdb_defconfig arm imx_v4_v5_defconfig mips pic32mzda_defconfig sh apsh4ad0a_defconfig xtensa iss_defconfig sh se7780_defconfig powerpc mpc8540_ads_defconfig powerpc mpc83xx_defconfig ia64 gensparse_defconfig x86_64 allnoconfig ia64 allmodconfig ia64 defconfig ia64 allyesconfig m68k allmodconfig m68k defconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig nds32 defconfig nios2 allyesconfig csky defconfig alpha defconfig alpha allyesconfig xtensa allyesconfig h8300 allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390 defconfig i386 allyesconfig sparc allyesconfig sparc defconfig i386 defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20210818 x86_64 randconfig-a006-20210818 x86_64 randconfig-a003-20210818 x86_64 randconfig-a005-20210818 x86_64 randconfig-a002-20210818 x86_64 randconfig-a001-20210818 x86_64 randconfig-a006-20210816 x86_64 randconfig-a004-20210816 x86_64 randconfig-a003-20210816 x86_64 randconfig-a001-20210816 x86_64 randconfig-a005-20210816 x86_64 randconfig-a002-20210816 i386 randconfig-a004-20210818 i386 randconfig-a006-20210818 i386 randconfig-a002-20210818 i386 randconfig-a001-20210818 i386 randconfig-a003-20210818 i386 randconfig-a005-20210818 x86_64 randconfig-a013-20210819 x86_64 randconfig-a011-20210819 x86_64 randconfig-a012-20210819 x86_64 randconfig-a016-20210819 x86_64 randconfig-a014-20210819 x86_64 randconfig-a015-20210819 i386 randconfig-a015-20210819 i386 randconfig-a011-20210819 i386 randconfig-a014-20210819 i386 randconfig-a013-20210819 i386 randconfig-a016-20210819 i386 randconfig-a012-20210819 riscv nommu_k210_defconfig riscv allyesconfig riscv nommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscv allmodconfig x86_64 rhel-8.3-kselftests um x86_64_defconfig um i386_defconfig x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec clang tested configs: i386 randconfig-c001-20210818 i386 randconfig-c001-20210819 x86_64 randconfig-a004-20210819 x86_64 randconfig-a006-20210819 x86_64 randconfig-a003-20210819 x86_64 randconfig-a002-20210819 x86_64 randconfig-a005-20210819 x86_64 randconfig-a001-20210819 i386 randconfig-a004-20210817 i386 randconfig-a003-20210817 i386 randconfig-a001-20210817 i386 randconfig-a002-20210817 i386 randconfig-a006-20210817 i386 randconfig-a005-20210817 i386 randconfig-a004-20210819 i386 randconfig-a006-20210819 i386 randconfig-a001-20210819 i386 randconfig-a002-20210819 i386 randconfig-a003-20210819 i386 randconfig-a005-20210819 x86_64 randconfig-a013-20210818 x86_64 randconfig-a011-20210818 x86_64 randconfig-a012-20210818 x86_64 randconfig-a016-20210818 x86_64 randconfig-a014-20210818 x86_64 randconfig-a015-20210818 i386 randconfig-a015-20210818 i386 randconfig-a011-20210818 i386 randconfig-a013-20210818 i386 randconfig-a014-20210818 i386 randconfig-a016-20210818 i386 randconfig-a012-20210818 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Aug 19, 2021 at 6:22 PM Chen, Rong A <rong.a.chen@intel.com> wrote: > > > > On 8/15/2021 8:04 AM, Barry Song wrote: > > On Sun, Aug 15, 2021 at 5:18 AM Andy Shevchenko > > <andy.shevchenko@gmail.com> wrote: > >> > >> On Sat, Aug 14, 2021 at 4:36 PM Greg Kroah-Hartman > >> <gregkh@linuxfoundation.org> wrote: > >>> On Sat, Aug 14, 2021 at 07:03:00PM +0800, kernel test robot wrote: > >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing > >>>> head: 3b35f2a6a625126c57475aa56b5357d8e80b404c > >>>> commit: 291f93ca339f5b5e6e90ad037bb8271f0f618165 [28/31] lib: test_bitmap: add bitmap_print_bitmask/list_to_buf test cases > >>>> config: xtensa-randconfig-r004-20210814 (attached as .config) > >>>> compiler: xtensa-linux-gcc (GCC) 11.2.0 > >>>> reproduce (this is a W=1 build): > >>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > >>>> chmod +x ~/bin/make.cross > >>>> # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?id=291f93ca339f5b5e6e90ad037bb8271f0f618165 > >>>> git remote add driver-core https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > >>>> git fetch --no-tags driver-core driver-core-testing > >>>> git checkout 291f93ca339f5b5e6e90ad037bb8271f0f618165 > >>>> # save the attached .config to linux build tree > >>>> mkdir build_dir > >>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash > >>>> > >>>> If you fix the issue, kindly add following tag as appropriate > >>>> Reported-by: kernel test robot <lkp@intel.com> > >>>> > >>>> All warnings (new ones prefixed by >>, old ones prefixed by <<): > >>>> > >>>>>> WARNING: modpost: vmlinux.o(.text.unlikely+0x156c): Section mismatch in reference from the function bitmap_equal() to the variable .init.data:initcall_level_names > >>>> The function bitmap_equal() references > >>>> the variable __initdata initcall_level_names. > >>>> This is often because bitmap_equal lacks a __initdata > >>>> annotation or the annotation of initcall_level_names is wrong. > >>>> > >>>> The below error/warnings are from parent commit: > >>>> << WARNING: modpost: vmlinux.o(.data+0x1a86d8): Section mismatch in reference from the variable qed_mfw_legacy_maps to the variable .init.rodata:__setup_str_initcall_blacklist > >>>> << WARNING: modpost: vmlinux.o(.data+0x1a87c8): Section mismatch in reference from the variable qed_mfw_ext_maps to the variable .init.rodata:__setup_str_initcall_blacklist > >>>> << WARNING: modpost: vmlinux.o(.data+0x1a8948): Section mismatch in reference from the variable qede_forced_speed_maps to the variable .init.rodata:__setup_str_initcall_blacklist > >> > >>> Barry, can I get a fix for this? > >> > >> Max already pointed out, but I guess you were not in Cc list, that > >> it's a GCC bug in his opinion, but GCC people don't ack it. > >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92938 > > > > I really don't understand what is going on here. My understanding is > > this report has nothing to do with the > > new commit and it doesn't report any valid place where kernel code is wrong. > > Hi Barry, > > Sorry for the misunderstanding, the warning only changed a little by > this commit, see: > > >>>> The below error/warnings are from parent commit: > >>>> << WARNING: modpost: vmlinux.o(.data+0x1a86d8): Section mismatch > in reference from the variable qed_mfw_legacy_maps to the variable > .init.rodata:__setup_str_initcall_blacklist > >>>> << WARNING: modpost: vmlinux.o(.data+0x1a87c8): Section mismatch > in reference from the variable qed_mfw_ext_maps to the variable > .init.rodata:__setup_str_initcall_blacklist > >>>> << WARNING: modpost: vmlinux.o(.data+0x1a8948): Section mismatch > in reference from the variable qede_forced_speed_maps to the variable > .init.rodata:__setup_str_initcall_blacklist > > we'll update the message to give a heavy hint. Rong, note we have another discussion over here: https://lore.kernel.org/lkml/20210815032132.14530-1-21cnbao@gmail.com/ and a gcc bug was reported one year ago: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92938 > > Best Regards, > Rong Chen > > > > > with xtensa gcc 11.1 which is the one i can easily download from here > > after google: > > http://kernel.c3sl.ufpr.br/pub/tools/crosstool/ > > > > i could somehow reproduce this kind of very odd section mismatch > > report from bitmap: > > $ ./build-xenta.sh > > ... > > MODPOST vmlinux.symvers > > WARNING: modpost: vmlinux.o(.text.unlikely+0x4d64): Section mismatch > > in reference from the function bitmap_equal() to the variable > > .init.rodata:__setup_str_initcall_blacklist > > The function bitmap_equal() references > > the variable __initconst __setup_str_initcall_blacklist. > > This is often because bitmap_equal lacks a __initconst > > annotation or the annotation of __setup_str_initcall_blacklist is wrong. > > > > ... > > WARNING: modpost: lib/find_bit_benchmark.o(.text.unlikely+0x0): > > Section mismatch in reference from the (unknown reference) (unknown) > > to the variable .init.data:bitmap2 > > The function (unknown)() references > > the variable __initdata bitmap2. > > This is often because (unknown) lacks a __initdata > > annotation or the annotation of bitmap2 is wrong. > > ... > > > > But after reverting my commit, it is *still* there: > > > > $ git revert 2069b8b9ce8b758e015ce49225b1fedac4accd9c > > [scheduler e158c85c6ccc] Revert "lib: test_bitmap: add > > bitmap_print_bitmask/list_to_buf test cases" > > 1 file changed, 150 deletions(-) > > > > $ ./build-xenta.sh > > ... > > MODPOST vmlinux.symvers > > WARNING: modpost: vmlinux.o(.text.unlikely+0x4d64): Section mismatch > > in reference from the function bitmap_equal() to the variable > > .init.rodata:__setup_str_initcall_blacklist > > The function bitmap_equal() references > > the variable __initconst __setup_str_initcall_blacklist. > > This is often because bitmap_equal lacks a __initconst > > annotation or the annotation of __setup_str_initcall_blacklist is wrong. > > ... > > WARNING: modpost: lib/find_bit_benchmark.o(.text.unlikely+0x0): > > Section mismatch in reference from the (unknown reference) (unknown) > > to the variable .init.data:bitmap2 > > The function (unknown)() references > > the variable __initdata bitmap2. > > This is often because (unknown) lacks a __initdata > > annotation or the annotation of bitmap2 is wrong. > > > > Kernel: arch/xtensa/boot/boot-elf/../Image.elf is ready > > GEN Module.symvers > > > >> > >> -- > >> With Best Regards, > >> Andy Shevchenko > > > > Thanks > > Barry > > _______________________________________________ > > kbuild-all mailing list -- kbuild-all@lists.01.org > > To unsubscribe send an email to kbuild-all-leave@lists.01.org > > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 8/15/2021 8:04 AM, Barry Song wrote: > On Sun, Aug 15, 2021 at 5:18 AM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: >> >> On Sat, Aug 14, 2021 at 4:36 PM Greg Kroah-Hartman >> <gregkh@linuxfoundation.org> wrote: >>> On Sat, Aug 14, 2021 at 07:03:00PM +0800, kernel test robot wrote: >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing >>>> head: 3b35f2a6a625126c57475aa56b5357d8e80b404c >>>> commit: 291f93ca339f5b5e6e90ad037bb8271f0f618165 [28/31] lib: test_bitmap: add bitmap_print_bitmask/list_to_buf test cases >>>> config: xtensa-randconfig-r004-20210814 (attached as .config) >>>> compiler: xtensa-linux-gcc (GCC) 11.2.0 >>>> reproduce (this is a W=1 build): >>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>>> chmod +x ~/bin/make.cross >>>> # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?id=291f93ca339f5b5e6e90ad037bb8271f0f618165 >>>> git remote add driver-core https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git >>>> git fetch --no-tags driver-core driver-core-testing >>>> git checkout 291f93ca339f5b5e6e90ad037bb8271f0f618165 >>>> # save the attached .config to linux build tree >>>> mkdir build_dir >>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash >>>> >>>> If you fix the issue, kindly add following tag as appropriate >>>> Reported-by: kernel test robot <lkp@intel.com> >>>> >>>> All warnings (new ones prefixed by >>, old ones prefixed by <<): >>>> >>>>>> WARNING: modpost: vmlinux.o(.text.unlikely+0x156c): Section mismatch in reference from the function bitmap_equal() to the variable .init.data:initcall_level_names >>>> The function bitmap_equal() references >>>> the variable __initdata initcall_level_names. >>>> This is often because bitmap_equal lacks a __initdata >>>> annotation or the annotation of initcall_level_names is wrong. >>>> >>>> The below error/warnings are from parent commit: >>>> << WARNING: modpost: vmlinux.o(.data+0x1a86d8): Section mismatch in reference from the variable qed_mfw_legacy_maps to the variable .init.rodata:__setup_str_initcall_blacklist >>>> << WARNING: modpost: vmlinux.o(.data+0x1a87c8): Section mismatch in reference from the variable qed_mfw_ext_maps to the variable .init.rodata:__setup_str_initcall_blacklist >>>> << WARNING: modpost: vmlinux.o(.data+0x1a8948): Section mismatch in reference from the variable qede_forced_speed_maps to the variable .init.rodata:__setup_str_initcall_blacklist >> >>> Barry, can I get a fix for this? >> >> Max already pointed out, but I guess you were not in Cc list, that >> it's a GCC bug in his opinion, but GCC people don't ack it. >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92938 > > I really don't understand what is going on here. My understanding is > this report has nothing to do with the > new commit and it doesn't report any valid place where kernel code is wrong. Hi Barry, Sorry for the misunderstanding, the warning only changed a little by this commit, see: >>>> The below error/warnings are from parent commit: >>>> << WARNING: modpost: vmlinux.o(.data+0x1a86d8): Section mismatch in reference from the variable qed_mfw_legacy_maps to the variable .init.rodata:__setup_str_initcall_blacklist >>>> << WARNING: modpost: vmlinux.o(.data+0x1a87c8): Section mismatch in reference from the variable qed_mfw_ext_maps to the variable .init.rodata:__setup_str_initcall_blacklist >>>> << WARNING: modpost: vmlinux.o(.data+0x1a8948): Section mismatch in reference from the variable qede_forced_speed_maps to the variable .init.rodata:__setup_str_initcall_blacklist we'll update the message to give a heavy hint. Best Regards, Rong Chen > > with xtensa gcc 11.1 which is the one i can easily download from here > after google: > http://kernel.c3sl.ufpr.br/pub/tools/crosstool/ > > i could somehow reproduce this kind of very odd section mismatch > report from bitmap: > $ ./build-xenta.sh > ... > MODPOST vmlinux.symvers > WARNING: modpost: vmlinux.o(.text.unlikely+0x4d64): Section mismatch > in reference from the function bitmap_equal() to the variable > .init.rodata:__setup_str_initcall_blacklist > The function bitmap_equal() references > the variable __initconst __setup_str_initcall_blacklist. > This is often because bitmap_equal lacks a __initconst > annotation or the annotation of __setup_str_initcall_blacklist is wrong. > > ... > WARNING: modpost: lib/find_bit_benchmark.o(.text.unlikely+0x0): > Section mismatch in reference from the (unknown reference) (unknown) > to the variable .init.data:bitmap2 > The function (unknown)() references > the variable __initdata bitmap2. > This is often because (unknown) lacks a __initdata > annotation or the annotation of bitmap2 is wrong. > ... > > But after reverting my commit, it is *still* there: > > $ git revert 2069b8b9ce8b758e015ce49225b1fedac4accd9c > [scheduler e158c85c6ccc] Revert "lib: test_bitmap: add > bitmap_print_bitmask/list_to_buf test cases" > 1 file changed, 150 deletions(-) > > $ ./build-xenta.sh > ... > MODPOST vmlinux.symvers > WARNING: modpost: vmlinux.o(.text.unlikely+0x4d64): Section mismatch > in reference from the function bitmap_equal() to the variable > .init.rodata:__setup_str_initcall_blacklist > The function bitmap_equal() references > the variable __initconst __setup_str_initcall_blacklist. > This is often because bitmap_equal lacks a __initconst > annotation or the annotation of __setup_str_initcall_blacklist is wrong. > ... > WARNING: modpost: lib/find_bit_benchmark.o(.text.unlikely+0x0): > Section mismatch in reference from the (unknown reference) (unknown) > to the variable .init.data:bitmap2 > The function (unknown)() references > the variable __initdata bitmap2. > This is often because (unknown) lacks a __initdata > annotation or the annotation of bitmap2 is wrong. > > Kernel: arch/xtensa/boot/boot-elf/../Image.elf is ready > GEN Module.symvers > >> >> -- >> With Best Regards, >> Andy Shevchenko > > Thanks > Barry > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Enable DSI EOTP feature for fixing some panel screen constant shift issue. Removing MIPI flag MIPI_DSI_MODE_NO_EOT_PACKET to enable DSI EOTP. Reviewed-by: Robert Foss <robert.foss@linaro.org> Signed-off-by: Xin Ji <xji@analogixsemi.com> --- drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index abc8db77bfd3..1a871f6b6822 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -1335,7 +1335,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) dsi->format = MIPI_DSI_FMT_RGB888; dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | - MIPI_DSI_MODE_NO_EOT_PACKET | MIPI_DSI_MODE_VIDEO_HSE; if (mipi_dsi_attach(dsi) < 0) { -- 2.25.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Aug 17, 2021 at 09:41:05PM -0700, daniel watson wrote: > From: Daniel Watson <ozzloy@challenge-bot.com> > > Moved the opening curly brace to the end of the opening > line of the phy_stat struct for style consistency. > > Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com> > --- > drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) This change does not apply to my tree at all. Make sure that you are working off of the latest development tree, and not older kernel trees (like Linus's), otherwise you will end up duplicating work that others have already done. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Aug 16, 2021 at 8:06 PM Leon Krieg <info@madcow.dev> wrote: > > Sorry to bother you with this low-effort patch but I'd really like to get > my feet in the water and this whole process is making me nervous. I'd > really appreciate you taking the time to look over this diff and > hopefully I did not screw up to badly. > > Signed-off-by: Leon Krieg <info@madcow.dev> > --- > drivers/staging/ks7010/Kconfig | 7 ++++--- > drivers/staging/ks7010/ks_hostif.c | 2 +- > drivers/staging/ks7010/ks_wlan_net.c | 20 ++++++++++---------- > 3 files changed, 15 insertions(+), 14 deletions(-) > > diff --git a/drivers/staging/ks7010/Kconfig b/drivers/staging/ks7010/Kconfig > index 0987fdc2f70d..4bc17e50ac89 100644 > --- a/drivers/staging/ks7010/Kconfig > +++ b/drivers/staging/ks7010/Kconfig > @@ -6,6 +6,7 @@ config KS7010 > select WEXT_PRIV > select FW_LOADER > help > - This is a driver for KeyStream KS7010 based SDIO WIFI cards. It is > - found on at least later Spectec SDW-821 (FCC-ID "S2Y-WLAN-11G-K" only, > - sadly not FCC-ID "S2Y-WLAN-11B-G") and Spectec SDW-823 microSD cards. > + Selecting this option enables the driver for KeyStream KS7010 SDIO > + hardware found in at least Spectec SDW-821 and SDW-823 microSD cards > + (FCC-ID "S2Y-WLAN-11G-K" but not FCC-ID "S2Y-WLAN-11B-G" and Spectec > + SDW-823). > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index eaa70893224a..d2f9d0ed62c1 100644 > drivers/staging/ks7010/Kconfig | 7 ++++--- > drivers/staging/ks7010/ks_hostif.c | 2 +- > drivers/staging/ks7010/ks_wlan_net.c | 20 ++++++++++---------- > 3 files changed, 15 insertions(+), 14 deletions(-) > > diff --git a/drivers/staging/ks7010/Kconfig b/drivers/staging/ks7010/Kconfig > index 0987fdc2f70d..4bc17e50ac89 100644 > --- a/drivers/staging/ks7010/Kconfig > +++ b/drivers/staging/ks7010/Kconfig > @@ -6,6 +6,7 @@ config KS7010 > select WEXT_PRIV > select FW_LOADER > help > - This is a driver for KeyStream KS7010 based SDIO WIFI cards. It is > - found on at least later Spectec SDW-821 (FCC-ID "S2Y-WLAN-11G-K" only, > - sadly not FCC-ID "S2Y-WLAN-11B-G") and Spectec SDW-823 microSD cards. > + Selecting this option enables the driver for KeyStream KS7010 SDIO > + hardware found in at least Spectec SDW-821 and SDW-823 microSD cards > + (FCC-ID "S2Y-WLAN-11G-K" but not FCC-ID "S2Y-WLAN-11B-G" and Spectec > + SDW-823). > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index eaa70893224a..d2f9d0ed62c1 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -134,7 +134,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info) > size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ? > ap_info->rsn.size : RSN_IE_BODY_MAX; > if ((ap_info->rsn_mode & RSN_MODE_WPA2) && > - (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) { > + priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) { > ap->rsn_ie.id = RSN_INFO_ELEM_ID; > ap->rsn_ie.size = size; > memcpy(ap->rsn_ie.body, ap_info->rsn.body, size); > diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c > index 09e7b4cd0138..33abb6a7dbe0 100644 > --- a/drivers/staging/ks7010/ks_wlan_net.c > +++ b/drivers/staging/ks7010/ks_wlan_net.c > @@ -181,26 +181,26 @@ static int ks_wlan_set_freq(struct net_device *dev, > > /* for SLEEP MODE */ > /* If setting by frequency, convert to a channel */ > - if ((fwrq->freq.e == 1) && > - (fwrq->freq.m >= 241200000) && (fwrq->freq.m <= 248700000)) { > + if (fwrq->freq.e == 1 && > + fwrq->freq.m >= 241200000 && fwrq->freq.m <= 248700000) { > int f = fwrq->freq.m / 100000; > int c = 0; > > while ((c < 14) && (f != frequency_list[c])) > c++; > - /* Hack to fall through... */ > + fallthrough; > fwrq->freq.e = 0; > fwrq->freq.m = c + 1; > } > /* Setting by channel number */ > - if ((fwrq->freq.m > 1000) || (fwrq->freq.e > 0)) > + if (fwrq->freq.m > 1000 || fwrq->freq.e > 0) > return -EOPNOTSUPP; > > channel = fwrq->freq.m; > /* We should do a better check than that, > * based on the card capability !!! > */ > - if ((channel < 1) || (channel > 14)) { > + if (channel < 1 || channel > 14) { > netdev_dbg(dev, "%s: New channel value of %d is invalid!\n", > dev->name, fwrq->freq.m); > return -EINVAL; > @@ -664,7 +664,7 @@ static int ks_wlan_set_rts(struct net_device *dev, struct iw_request_info *info, > /* for SLEEP MODE */ > if (vwrq->rts.disabled) > rthr = 2347; > - if ((rthr < 0) || (rthr > 2347)) > + if (rthr < 0 || rthr > 2347) > return -EINVAL; > > priv->reg.rts = rthr; > @@ -702,7 +702,7 @@ static int ks_wlan_set_frag(struct net_device *dev, > /* for SLEEP MODE */ > if (vwrq->frag.disabled) > fthr = 2346; > - if ((fthr < 256) || (fthr > 2346)) > + if (fthr < 256 || fthr > 2346) > return -EINVAL; > > fthr &= ~0x1; /* Get an even value - is it really needed ??? */ > @@ -781,7 +781,7 @@ static int ks_wlan_set_encode(struct net_device *dev, > return -EINVAL; > > /* for SLEEP MODE */ > - if ((index < 0) || (index > 4)) > + if (index < 0 || index > 4) > return -EINVAL; > > index = (index == 0) ? priv->reg.wep_index : (index - 1); > @@ -882,7 +882,7 @@ static int ks_wlan_get_encode(struct net_device *dev, > } > > /* Which key do we want ? -1 -> tx index */ > - if ((index < 0) || (index >= 4)) > + if (index < 0 || index >= 4) > index = priv->reg.wep_index; > if (priv->reg.privacy_invoked) { > enc->flags &= ~IW_ENCODE_DISABLED; > @@ -1860,7 +1860,7 @@ static int ks_wlan_set_power_mgmt(struct net_device *dev, > return -EINVAL; > > if ((*uwrq == POWER_MGMT_SAVE1 || *uwrq == POWER_MGMT_SAVE2) && > - (priv->reg.operation_mode != MODE_INFRASTRUCTURE)) > + priv->reg.operation_mode != MODE_INFRASTRUCTURE) > return -EINVAL; > > priv->reg.power_mgmt = *uwrq; > -- > 2.27.0 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel> --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -134,7 +134,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info) > size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ? > ap_info->rsn.size : RSN_IE_BODY_MAX; > if ((ap_info->rsn_mode & RSN_MODE_WPA2) && > - (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) { > + priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) { > ap->rsn_ie.id = RSN_INFO_ELEM_ID; > ap->rsn_ie.size = size; > memcpy(ap->rsn_ie.body, ap_info->rsn.body, size); > diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c > index 09e7b4cd0138..33abb6a7dbe0 100644 > --- a/drivers/staging/ks7010/ks_wlan_net.c > +++ b/drivers/staging/ks7010/ks_wlan_net.c > @@ -181,26 +181,26 @@ static int ks_wlan_set_freq(struct net_device *dev, > > /* for SLEEP MODE */ > /* If setting by frequency, convert to a channel */ > - if ((fwrq->freq.e == 1) && > - (fwrq->freq.m >= 241200000) && (fwrq->freq.m <= 248700000)) { > + if (fwrq->freq.e == 1 && > + fwrq->freq.m >= 241200000 && fwrq->freq.m <= 248700000) { > int f = fwrq->freq.m / 100000; > int c = 0; > > while ((c < 14) && (f != frequency_list[c])) > c++; > - /* Hack to fall through... */ > + fallthrough; > fwrq->freq.e = 0; > fwrq->freq.m = c + 1; > } > /* Setting by channel number */ > - if ((fwrq->freq.m > 1000) || (fwrq->freq.e > 0)) > + if (fwrq->freq.m > 1000 || fwrq->freq.e > 0) > return -EOPNOTSUPP; > > channel = fwrq->freq.m; > /* We should do a better check than that, > * based on the card capability !!! > */ > - if ((channel < 1) || (channel > 14)) { > + if (channel < 1 || channel > 14) { > netdev_dbg(dev, "%s: New channel value of %d is invalid!\n", > dev->name, fwrq->freq.m); > return -EINVAL; > @@ -664,7 +664,7 @@ static int ks_wlan_set_rts(struct net_device *dev, struct iw_request_info *info, > /* for SLEEP MODE */ > if (vwrq->rts.disabled) > rthr = 2347; > - if ((rthr < 0) || (rthr > 2347)) > + if (rthr < 0 || rthr > 2347) > return -EINVAL; > > priv->reg.rts = rthr; > @@ -702,7 +702,7 @@ static int ks_wlan_set_frag(struct net_device *dev, > /* for SLEEP MODE */ > if (vwrq->frag.disabled) > fthr = 2346; > - if ((fthr < 256) || (fthr > 2346)) > + if (fthr < 256 || fthr > 2346) > return -EINVAL; > > fthr &= ~0x1; /* Get an even value - is it really needed ??? */ > @@ -781,7 +781,7 @@ static int ks_wlan_set_encode(struct net_device *dev, > return -EINVAL; > > /* for SLEEP MODE */ > - if ((index < 0) || (index > 4)) > + if (index < 0 || index > 4) > return -EINVAL; > > index = (index == 0) ? priv->reg.wep_index : (index - 1); > @@ -882,7 +882,7 @@ static int ks_wlan_get_encode(struct net_device *dev, > } > > /* Which key do we want ? -1 -> tx index */ > - if ((index < 0) || (index >= 4)) > + if (index < 0 || index >= 4) > index = priv->reg.wep_index; > if (priv->reg.privacy_invoked) { > enc->flags &= ~IW_ENCODE_DISABLED; > @@ -1860,7 +1860,7 @@ static int ks_wlan_set_power_mgmt(struct net_device *dev, > return -EINVAL; > > if ((*uwrq == POWER_MGMT_SAVE1 || *uwrq == POWER_MGMT_SAVE2) && > - (priv->reg.operation_mode != MODE_INFRASTRUCTURE)) > + priv->reg.operation_mode != MODE_INFRASTRUCTURE) > return -EINVAL; > > priv->reg.power_mgmt = *uwrq; > -- > 2.27.0 Hi, It seems you ran into some common issues and triggered some bots. Don't worry about that. Just rework the patch into multiple patches with sensible descriptions of what you did. Do follow the suggestions made by gregkh's patchbot. Frans _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: cbfa6f33e3a685c329d78e06b0cf1dcb23c9d849 clk: staging: correct reference to config IOMEM to config HAS_IOMEM Warning reports: https://lore.kernel.org/lkml/202107310213.WGo8CZVI-lkp@intel.com Warning in current branch: drivers/staging/r8188eu/core/rtw_ieee80211.c:884: warning: expecting prototype for ieee802_11_parse_elems(). Prototype was for rtw_ieee802_11_parse_elems() instead drivers/staging/r8188eu/core/rtw_security.c:1627: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/staging/r8188eu/core/rtw_security.c:1652: warning: expecting prototype for omac1_aes_128(). Prototype was for rtw_use_tkipkey_handler() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:104: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_SetBBReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:144: warning: expecting prototype for Function(). Prototype was for phy_RFSerialRead() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:243: warning: expecting prototype for Function(). Prototype was for phy_RFSerialWrite() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:287: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_QueryRFReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:323: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_SetRFReg() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:389: warning: expecting prototype for Function(). Prototype was for phy_InitBBRFRegisterDefinition() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:46: warning: expecting prototype for Function(). Prototype was for phy_CalculateBitShift() instead drivers/staging/r8188eu/hal/rtl8188e_phycfg.c:76: warning: expecting prototype for Function(). Prototype was for rtl8188e_PHY_QueryBBReg() instead drivers/staging/r8188eu/os_dep/rtw_android.c:53: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Warning ids grouped by kconfigs: gcc_recent_errors `-- parisc-allyesconfig |-- drivers-staging-r8188eu-core-rtw_ieee80211.c:warning:expecting-prototype-for-ieee802_11_parse_elems().-Prototype-was-for-rtw_ieee802_11_parse_elems()-instead |-- drivers-staging-r8188eu-core-rtw_security.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst |-- drivers-staging-r8188eu-core-rtw_security.c:warning:expecting-prototype-for-omac1_aes_128().-Prototype-was-for-rtw_use_tkipkey_handler()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_CalculateBitShift()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_InitBBRFRegisterDefinition()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialRead()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-phy_RFSerialWrite()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryBBReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_QueryRFReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetBBReg()-instead |-- drivers-staging-r8188eu-hal-rtl8188e_phycfg.c:warning:expecting-prototype-for-Function().-Prototype-was-for-rtl8188e_PHY_SetRFReg()-instead `-- drivers-staging-r8188eu-os_dep-rtw_android.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kernel-doc.rst elapsed time: 725m configs tested: 100 configs skipped: 3 gcc tested configs: arm defconfig arm64 allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig i386 randconfig-c001-20210816 riscv nommu_k210_defconfig mips malta_kvm_defconfig powerpc rainier_defconfig ia64 generic_defconfig powerpc tqm8540_defconfig mips maltasmvp_defconfig arc vdk_hs38_defconfig mips jazz_defconfig mips cu1000-neo_defconfig ia64 zx1_defconfig sh edosk7705_defconfig powerpc microwatt_defconfig arm colibri_pxa270_defconfig um alldefconfig sh se7721_defconfig sh rsk7201_defconfig powerpc katmai_defconfig x86_64 allnoconfig powerpc currituck_defconfig powerpc canyonlands_defconfig sh ecovec24_defconfig powerpc allnoconfig arm cm_x300_defconfig mips maltasmvp_eva_defconfig powerpc cm5200_defconfig arm spear13xx_defconfig ia64 allmodconfig ia64 defconfig ia64 allyesconfig m68k allmodconfig m68k defconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig nds32 defconfig nios2 allyesconfig csky defconfig alpha defconfig alpha allyesconfig xtensa allyesconfig h8300 allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390 defconfig i386 allyesconfig sparc allyesconfig sparc defconfig i386 defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig x86_64 randconfig-a006-20210816 x86_64 randconfig-a004-20210816 x86_64 randconfig-a003-20210816 x86_64 randconfig-a001-20210816 x86_64 randconfig-a005-20210816 x86_64 randconfig-a002-20210816 i386 randconfig-a004-20210816 i386 randconfig-a003-20210816 i386 randconfig-a002-20210816 i386 randconfig-a001-20210816 i386 randconfig-a006-20210816 i386 randconfig-a005-20210816 riscv allyesconfig riscv nommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscv allmodconfig um x86_64_defconfig um i386_defconfig x86_64 allyesconfig x86_64 rhel-8.3-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec clang tested configs: x86_64 randconfig-a011-20210816 x86_64 randconfig-a013-20210816 x86_64 randconfig-a016-20210816 x86_64 randconfig-a012-20210816 x86_64 randconfig-a015-20210816 x86_64 randconfig-a014-20210816 i386 randconfig-a011-20210816 i386 randconfig-a015-20210816 i386 randconfig-a013-20210816 i386 randconfig-a014-20210816 i386 randconfig-a016-20210816 i386 randconfig-a012-20210816 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Daniel Watson <ozzloy@challenge-bot.com> Moved the opening curly brace to the end of the opening line of the phy_stat struct for style consistency. Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com> --- drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h index c77d172de7d08..9664758e21bef 100644 --- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h +++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h @@ -13,8 +13,7 @@ #define MAX_RECVBUF_SZ (10240) -struct phy_stat -{ +struct phy_stat { unsigned int phydw0; unsigned int phydw1; -- 2.30.2 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[-- Attachment #1: Type: text/plain, Size: 5594 bytes --] Hi Leon, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Leon-Krieg/staging-ks7010-Fix-coding-style-problems/20210817-020753 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9caf92ab573fd83c7455b65d4eefcefc1a9d2188 config: x86_64-rhel-8.3-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-348-gf0e6938b-dirty # https://github.com/0day-ci/linux/commit/5e90bce950e7fa0f0331bb9620b538d3109f04c6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Leon-Krieg/staging-ks7010-Fix-coding-style-problems/20210817-020753 git checkout 5e90bce950e7fa0f0331bb9620b538d3109f04c6 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 distclean If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> Error: kernelrelease not valid - run 'make prepare' to update it -- >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" -- >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" make[3]: *** [scripts/kconfig/Makefile:77: syncconfig] Error 1 make[2]: *** [Makefile:625: syncconfig] Error 2 make[1]: *** [Makefile:735: include/config/auto.conf.cmd] Error 2 make[1]: Failed to remake makefile 'include/config/auto.conf.cmd'. make[1]: Failed to remake makefile 'include/config/auto.conf'. >> make[1]: *** No rule to make target 'modules_prepare'. make: *** [Makefile:220: __sub-make] Error 2 make: Target 'modules_prepare' not remade because of errors. -- >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" make[2]: *** [scripts/kconfig/Makefile:77: olddefconfig] Error 1 make[1]: *** [Makefile:625: olddefconfig] Error 2 make: *** [Makefile:220: __sub-make] Error 2 make: Target 'olddefconfig' not remade because of errors. -- >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" make[3]: *** [scripts/kconfig/Makefile:77: syncconfig] Error 1 make[2]: *** [Makefile:625: syncconfig] Error 2 make[1]: *** [Makefile:735: include/config/auto.conf.cmd] Error 2 make[1]: Failed to remake makefile 'include/config/auto.conf.cmd'. make[1]: Failed to remake makefile 'include/config/auto.conf'. make[1]: *** [arch/x86/Makefile:290: checkbin] Error 1 >> Error: kernelrelease not valid - run 'make prepare' to update it make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:220: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. -- >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" make[3]: *** [scripts/kconfig/Makefile:77: syncconfig] Error 1 make[2]: *** [Makefile:625: syncconfig] Error 2 make[1]: *** [Makefile:735: include/config/auto.conf.cmd] Error 2 make[1]: Failed to remake makefile 'include/config/auto.conf.cmd'. make[1]: Failed to remake makefile 'include/config/auto.conf'. >> Error: kernelrelease not valid - run 'make prepare' to update it make[1]: *** [arch/x86/Makefile:290: checkbin] Error 1 make[1]: Target 'vmlinux' not remade because of errors. make: *** [Makefile:220: __sub-make] Error 2 make: Target 'vmlinux' not remade because of errors. *** *** The source tree is not clean, please run 'make ARCH=x86_64 mrproper' *** in /kbuild/worktree/build-ktools-consumer *** make[2]: *** [Makefile:565: outputmakefile] Error 1 make[2]: Target 'syncconfig' not remade because of errors. make[1]: *** [Makefile:721: include/config/auto.conf.cmd] Error 2 make[1]: Failed to remake makefile 'include/config/auto.conf.cmd'. make[1]: Failed to remake makefile 'include/config/auto.conf'. *** *** The source tree is not clean, please run 'make ARCH=x86_64 mrproper' *** in /kbuild/worktree/build-ktools-consumer *** make[1]: *** [Makefile:565: outputmakefile] Error 1 >> Error: kernelrelease not valid - run 'make prepare' to update it make[1]: *** [arch/x86/Makefile:290: checkbin] Error 1 make[1]: Target 'vmlinux' not remade because of errors. make: *** [Makefile:219: __sub-make] Error 2 make: Target 'vmlinux' not remade because of errors. vim +12 drivers/staging/ks7010/Kconfig > 12 SDW-823). --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 34535 bytes --] [-- Attachment #3: Type: text/plain, Size: 169 bytes --] _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[-- Attachment #1: Type: text/plain, Size: 2690 bytes --] Hi Leon, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Leon-Krieg/staging-ks7010-Fix-coding-style-problems/20210817-020753 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9caf92ab573fd83c7455b65d4eefcefc1a9d2188 config: i386-tinyconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/5e90bce950e7fa0f0331bb9620b538d3109f04c6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Leon-Krieg/staging-ks7010-Fix-coding-style-problems/20210817-020753 git checkout 5e90bce950e7fa0f0331bb9620b538d3109f04c6 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" -- >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" make[2]: *** [scripts/kconfig/Makefile:77: olddefconfig] Error 1 make[1]: *** [Makefile:625: olddefconfig] Error 2 make: *** [Makefile:220: __sub-make] Error 2 make: Target 'olddefconfig' not remade because of errors. -- >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" make[3]: *** [scripts/kconfig/Makefile:77: syncconfig] Error 1 make[2]: *** [Makefile:625: syncconfig] Error 2 make[1]: *** [Makefile:735: include/config/auto.conf.cmd] Error 2 make[1]: Failed to remake makefile 'include/config/auto.conf.cmd'. make[1]: Failed to remake makefile 'include/config/auto.conf'. make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:220: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +12 drivers/staging/ks7010/Kconfig > 12 SDW-823). --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 7494 bytes --] [-- Attachment #3: Type: text/plain, Size: 169 bytes --] _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[-- Attachment #1: Type: text/plain, Size: 3649 bytes --] Hi Leon, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Leon-Krieg/staging-ks7010-Fix-coding-style-problems/20210817-020753 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9caf92ab573fd83c7455b65d4eefcefc1a9d2188 config: hexagon-randconfig-r041-20210816 (attached as .config) compiler: clang version 12.0.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/5e90bce950e7fa0f0331bb9620b538d3109f04c6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Leon-Krieg/staging-ks7010-Fix-coding-style-problems/20210817-020753 git checkout 5e90bce950e7fa0f0331bb9620b538d3109f04c6 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" -- >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" make[3]: *** [scripts/kconfig/Makefile:77: syncconfig] Error 1 make[2]: *** [Makefile:625: syncconfig] Error 2 make[1]: *** [Makefile:735: include/config/auto.conf.cmd] Error 2 make[1]: Failed to remake makefile 'include/config/auto.conf.cmd'. make[1]: Failed to remake makefile 'include/config/auto.conf'. make[1]: Target 'modules_prepare' not remade because of errors. make: *** [Makefile:220: __sub-make] Error 2 make: Target 'modules_prepare' not remade because of errors. -- >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" make[2]: *** [scripts/kconfig/Makefile:77: olddefconfig] Error 1 make[1]: *** [Makefile:625: olddefconfig] Error 2 make: *** [Makefile:220: __sub-make] Error 2 make: Target 'olddefconfig' not remade because of errors. -- >> drivers/staging/ks7010/Kconfig:12: syntax error drivers/staging/ks7010/Kconfig:11: invalid statement drivers/staging/ks7010/Kconfig:12:warning: ignoring unsupported character '.' drivers/staging/ks7010/Kconfig:12: unknown statement "SDW-823" make[3]: *** [scripts/kconfig/Makefile:77: syncconfig] Error 1 make[2]: *** [Makefile:625: syncconfig] Error 2 make[1]: *** [Makefile:735: include/config/auto.conf.cmd] Error 2 make[1]: Failed to remake makefile 'include/config/auto.conf.cmd'. make[1]: Failed to remake makefile 'include/config/auto.conf'. make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:220: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +12 drivers/staging/ks7010/Kconfig > 12 SDW-823). --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 32778 bytes --] [-- Attachment #3: Type: text/plain, Size: 169 bytes --] _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[-- Attachment #1: Type: text/plain, Size: 3424 bytes --] Hi Leon, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Leon-Krieg/staging-ks7010-Fix-coding-style-problems-Version-2/20210817-020702 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git ff63261978ee1f00758f447d63276a6f180a81dc config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/be523ea1038288a8b2c8e5cf10bb2e6a02830a0a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Leon-Krieg/staging-ks7010-Fix-coding-style-problems-Version-2/20210817-020702 git checkout be523ea1038288a8b2c8e5cf10bb2e6a02830a0a # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/staging/ks7010/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from include/linux/compiler_types.h:65, from <command-line>: drivers/staging/ks7010/ks_wlan_net.c: In function 'ks_wlan_set_freq': >> include/linux/compiler_attributes.h:210:41: error: invalid use of attribute 'fallthrough' 210 | # define fallthrough __attribute__((__fallthrough__)) | ^~~~~~~~~~~~~ drivers/staging/ks7010/ks_wlan_net.c:191:17: note: in expansion of macro 'fallthrough' 191 | fallthrough; | ^~~~~~~~~~~ vim +/fallthrough +210 include/linux/compiler_attributes.h 294f69e662d1570 Joe Perches 2019-10-05 197 294f69e662d1570 Joe Perches 2019-10-05 198 /* 294f69e662d1570 Joe Perches 2019-10-05 199 * Add the pseudo keyword 'fallthrough' so case statement blocks 294f69e662d1570 Joe Perches 2019-10-05 200 * must end with any of these keywords: 294f69e662d1570 Joe Perches 2019-10-05 201 * break; 294f69e662d1570 Joe Perches 2019-10-05 202 * fallthrough; ca0760e7d79e2bb Wei Ming Chen 2021-05-06 203 * continue; 294f69e662d1570 Joe Perches 2019-10-05 204 * goto <label>; 294f69e662d1570 Joe Perches 2019-10-05 205 * return [expression]; 294f69e662d1570 Joe Perches 2019-10-05 206 * 294f69e662d1570 Joe Perches 2019-10-05 207 * gcc: https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html#Statement-Attributes 294f69e662d1570 Joe Perches 2019-10-05 208 */ 294f69e662d1570 Joe Perches 2019-10-05 209 #if __has_attribute(__fallthrough__) 294f69e662d1570 Joe Perches 2019-10-05 @210 # define fallthrough __attribute__((__fallthrough__)) 294f69e662d1570 Joe Perches 2019-10-05 211 #else 294f69e662d1570 Joe Perches 2019-10-05 212 # define fallthrough do {} while (0) /* fallthrough */ a3f8a30f3f0079c Miguel Ojeda 2018-08-30 213 #endif a3f8a30f3f0079c Miguel Ojeda 2018-08-30 214 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 60706 bytes --] [-- Attachment #3: Type: text/plain, Size: 169 bytes --] _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[-- Attachment #1: Type: text/plain, Size: 3501 bytes --] Hi Leon, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Leon-Krieg/staging-ks7010-Fix-coding-style-problems-Version-2/20210817-020702 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git ff63261978ee1f00758f447d63276a6f180a81dc config: riscv-randconfig-r042-20210816 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 44d0a99a12ec7ead4d2f5ef649ba05b40f6d463d) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/be523ea1038288a8b2c8e5cf10bb2e6a02830a0a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Leon-Krieg/staging-ks7010-Fix-coding-style-problems-Version-2/20210817-020702 git checkout be523ea1038288a8b2c8e5cf10bb2e6a02830a0a # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=riscv SHELL=/bin/bash drivers/staging/ks7010/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/staging/ks7010/ks_wlan_net.c:191:3: error: fallthrough annotation is outside switch statement fallthrough; ^ include/linux/compiler_attributes.h:210:56: note: expanded from macro 'fallthrough' # define fallthrough __attribute__((__fallthrough__)) ^ 1 error generated. vim +191 drivers/staging/ks7010/ks_wlan_net.c 171 172 static int ks_wlan_set_freq(struct net_device *dev, 173 struct iw_request_info *info, 174 union iwreq_data *fwrq, char *extra) 175 { 176 struct ks_wlan_private *priv = netdev_priv(dev); 177 int channel; 178 179 if (priv->sleep_mode == SLP_SLEEP) 180 return -EPERM; 181 182 /* for SLEEP MODE */ 183 /* If setting by frequency, convert to a channel */ 184 if (fwrq->freq.e == 1 && 185 fwrq->freq.m >= 241200000 && fwrq->freq.m <= 248700000) { 186 int f = fwrq->freq.m / 100000; 187 int c = 0; 188 189 while ((c < 14) && (f != frequency_list[c])) 190 c++; > 191 fallthrough; 192 fwrq->freq.e = 0; 193 fwrq->freq.m = c + 1; 194 } 195 /* Setting by channel number */ 196 if (fwrq->freq.m > 1000 || fwrq->freq.e > 0) 197 return -EOPNOTSUPP; 198 199 channel = fwrq->freq.m; 200 /* We should do a better check than that, 201 * based on the card capability !!! 202 */ 203 if (channel < 1 || channel > 14) { 204 netdev_dbg(dev, "%s: New channel value of %d is invalid!\n", 205 dev->name, fwrq->freq.m); 206 return -EINVAL; 207 } 208 209 /* Yes ! We can set it !!! */ 210 priv->reg.channel = (u8)(channel); 211 priv->need_commit |= SME_MODE_SET; 212 213 return -EINPROGRESS; /* Call commit handler */ 214 } 215 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 34763 bytes --] [-- Attachment #3: Type: text/plain, Size: 169 bytes --] _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Aug 16, 2021 at 08:04:47PM +0200, Leon Krieg wrote: > By doing some last-second wording changes directly in the diff I've > screwed up and managed to use spaces instead of tabs for the Kconfig file. > This is embarrassing! > > Signed-off-by: Leon Krieg <info@madcow.dev> > --- > drivers/staging/ks7010/Kconfig | 7 ++++--- > drivers/staging/ks7010/ks_hostif.c | 2 +- > drivers/staging/ks7010/ks_wlan_net.c | 20 ++++++++++---------- > 3 files changed, 15 insertions(+), 14 deletions(-) > > diff --git a/drivers/staging/ks7010/Kconfig b/drivers/staging/ks7010/Kconfig > index 0987fdc2f70d..4bc17e50ac89 100644 > --- a/drivers/staging/ks7010/Kconfig > +++ b/drivers/staging/ks7010/Kconfig > @@ -6,6 +6,7 @@ config KS7010 > select WEXT_PRIV > select FW_LOADER > help > - This is a driver for KeyStream KS7010 based SDIO WIFI cards. It is > - found on at least later Spectec SDW-821 (FCC-ID "S2Y-WLAN-11G-K" only, > - sadly not FCC-ID "S2Y-WLAN-11B-G") and Spectec SDW-823 microSD cards. > + Selecting this option enables the driver for KeyStream KS7010 SDIO > + hardware found in at least Spectec SDW-821 and SDW-823 microSD cards > + (FCC-ID "S2Y-WLAN-11G-K" but not FCC-ID "S2Y-WLAN-11B-G" and Spectec > + SDW-823). > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index eaa70893224a..d2f9d0ed62c1 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -134,7 +134,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info) > size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ? > ap_info->rsn.size : RSN_IE_BODY_MAX; > if ((ap_info->rsn_mode & RSN_MODE_WPA2) && > - (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) { > + priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) { > ap->rsn_ie.id = RSN_INFO_ELEM_ID; > ap->rsn_ie.size = size; > memcpy(ap->rsn_ie.body, ap_info->rsn.body, size); > diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c > index 09e7b4cd0138..33abb6a7dbe0 100644 > --- a/drivers/staging/ks7010/ks_wlan_net.c > +++ b/drivers/staging/ks7010/ks_wlan_net.c > @@ -181,26 +181,26 @@ static int ks_wlan_set_freq(struct net_device *dev, > > /* for SLEEP MODE */ > /* If setting by frequency, convert to a channel */ > - if ((fwrq->freq.e == 1) && > - (fwrq->freq.m >= 241200000) && (fwrq->freq.m <= 248700000)) { > + if (fwrq->freq.e == 1 && > + fwrq->freq.m >= 241200000 && fwrq->freq.m <= 248700000) { > int f = fwrq->freq.m / 100000; > int c = 0; > > while ((c < 14) && (f != frequency_list[c])) > c++; > - /* Hack to fall through... */ > + fallthrough; > fwrq->freq.e = 0; > fwrq->freq.m = c + 1; > } > /* Setting by channel number */ > - if ((fwrq->freq.m > 1000) || (fwrq->freq.e > 0)) > + if (fwrq->freq.m > 1000 || fwrq->freq.e > 0) > return -EOPNOTSUPP; > > channel = fwrq->freq.m; > /* We should do a better check than that, > * based on the card capability !!! > */ > - if ((channel < 1) || (channel > 14)) { > + if (channel < 1 || channel > 14) { > netdev_dbg(dev, "%s: New channel value of %d is invalid!\n", > dev->name, fwrq->freq.m); > return -EINVAL; > @@ -664,7 +664,7 @@ static int ks_wlan_set_rts(struct net_device *dev, struct iw_request_info *info, > /* for SLEEP MODE */ > if (vwrq->rts.disabled) > rthr = 2347; > - if ((rthr < 0) || (rthr > 2347)) > + if (rthr < 0 || rthr > 2347) > return -EINVAL; > > priv->reg.rts = rthr; > @@ -702,7 +702,7 @@ static int ks_wlan_set_frag(struct net_device *dev, > /* for SLEEP MODE */ > if (vwrq->frag.disabled) > fthr = 2346; > - if ((fthr < 256) || (fthr > 2346)) > + if (fthr < 256 || fthr > 2346) > return -EINVAL; > > fthr &= ~0x1; /* Get an even value - is it really needed ??? */ > @@ -781,7 +781,7 @@ static int ks_wlan_set_encode(struct net_device *dev, > return -EINVAL; > > /* for SLEEP MODE */ > - if ((index < 0) || (index > 4)) > + if (index < 0 || index > 4) > return -EINVAL; > > index = (index == 0) ? priv->reg.wep_index : (index - 1); > @@ -882,7 +882,7 @@ static int ks_wlan_get_encode(struct net_device *dev, > } > > /* Which key do we want ? -1 -> tx index */ > - if ((index < 0) || (index >= 4)) > + if (index < 0 || index >= 4) > index = priv->reg.wep_index; > if (priv->reg.privacy_invoked) { > enc->flags &= ~IW_ENCODE_DISABLED; > @@ -1860,7 +1860,7 @@ static int ks_wlan_set_power_mgmt(struct net_device *dev, > return -EINVAL; > > if ((*uwrq == POWER_MGMT_SAVE1 || *uwrq == POWER_MGMT_SAVE2) && > - (priv->reg.operation_mode != MODE_INFRASTRUCTURE)) > + priv->reg.operation_mode != MODE_INFRASTRUCTURE) > return -EINVAL; > > priv->reg.power_mgmt = *uwrq; > -- > 2.27.0 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Aug 16, 2021 at 07:55:03PM +0200, Leon Krieg wrote: > Sorry to bother you with this low-effort patch but I'd really like to get > my feet in the water and this whole process is making me nervous. I'd > really appreciate you taking the time to look over this diff and > hopefully I did not screw up to badly. > > Signed-off-by: Leon Krieg <info@madcow.dev> > --- > drivers/staging/ks7010/Kconfig | 7 ++++--- > drivers/staging/ks7010/ks_hostif.c | 2 +- > drivers/staging/ks7010/ks_wlan_net.c | 20 ++++++++++---------- > 3 files changed, 15 insertions(+), 14 deletions(-) > > diff --git a/drivers/staging/ks7010/Kconfig b/drivers/staging/ks7010/Kconfig > index 0987fdc2f70d..4bc17e50ac89 100644 > --- a/drivers/staging/ks7010/Kconfig > +++ b/drivers/staging/ks7010/Kconfig > @@ -6,6 +6,7 @@ config KS7010 > select WEXT_PRIV > select FW_LOADER > help > - This is a driver for KeyStream KS7010 based SDIO WIFI cards. It is > - found on at least later Spectec SDW-821 (FCC-ID "S2Y-WLAN-11G-K" only, > - sadly not FCC-ID "S2Y-WLAN-11B-G") and Spectec SDW-823 microSD cards. > + Selecting this option enables the driver for KeyStream KS7010 SDIO > + hardware found in at least Spectec SDW-821 and SDW-823 microSD cards > + (FCC-ID "S2Y-WLAN-11G-K" but not FCC-ID "S2Y-WLAN-11B-G" and Spectec > + SDW-823). > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index eaa70893224a..d2f9d0ed62c1 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -134,7 +134,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info) > size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ? > ap_info->rsn.size : RSN_IE_BODY_MAX; > if ((ap_info->rsn_mode & RSN_MODE_WPA2) && > - (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) { > + priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) { > ap->rsn_ie.id = RSN_INFO_ELEM_ID; > ap->rsn_ie.size = size; > memcpy(ap->rsn_ie.body, ap_info->rsn.body, size); > diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c > index 09e7b4cd0138..33abb6a7dbe0 100644 > --- a/drivers/staging/ks7010/ks_wlan_net.c > +++ b/drivers/staging/ks7010/ks_wlan_net.c > @@ -181,26 +181,26 @@ static int ks_wlan_set_freq(struct net_device *dev, > > /* for SLEEP MODE */ > /* If setting by frequency, convert to a channel */ > - if ((fwrq->freq.e == 1) && > - (fwrq->freq.m >= 241200000) && (fwrq->freq.m <= 248700000)) { > + if (fwrq->freq.e == 1 && > + fwrq->freq.m >= 241200000 && fwrq->freq.m <= 248700000) { > int f = fwrq->freq.m / 100000; > int c = 0; > > while ((c < 14) && (f != frequency_list[c])) > c++; > - /* Hack to fall through... */ > + fallthrough; > fwrq->freq.e = 0; > fwrq->freq.m = c + 1; > } > /* Setting by channel number */ > - if ((fwrq->freq.m > 1000) || (fwrq->freq.e > 0)) > + if (fwrq->freq.m > 1000 || fwrq->freq.e > 0) > return -EOPNOTSUPP; > > channel = fwrq->freq.m; > /* We should do a better check than that, > * based on the card capability !!! > */ > - if ((channel < 1) || (channel > 14)) { > + if (channel < 1 || channel > 14) { > netdev_dbg(dev, "%s: New channel value of %d is invalid!\n", > dev->name, fwrq->freq.m); > return -EINVAL; > @@ -664,7 +664,7 @@ static int ks_wlan_set_rts(struct net_device *dev, struct iw_request_info *info, > /* for SLEEP MODE */ > if (vwrq->rts.disabled) > rthr = 2347; > - if ((rthr < 0) || (rthr > 2347)) > + if (rthr < 0 || rthr > 2347) > return -EINVAL; > > priv->reg.rts = rthr; > @@ -702,7 +702,7 @@ static int ks_wlan_set_frag(struct net_device *dev, > /* for SLEEP MODE */ > if (vwrq->frag.disabled) > fthr = 2346; > - if ((fthr < 256) || (fthr > 2346)) > + if (fthr < 256 || fthr > 2346) > return -EINVAL; > > fthr &= ~0x1; /* Get an even value - is it really needed ??? */ > @@ -781,7 +781,7 @@ static int ks_wlan_set_encode(struct net_device *dev, > return -EINVAL; > > /* for SLEEP MODE */ > - if ((index < 0) || (index > 4)) > + if (index < 0 || index > 4) > return -EINVAL; > > index = (index == 0) ? priv->reg.wep_index : (index - 1); > @@ -882,7 +882,7 @@ static int ks_wlan_get_encode(struct net_device *dev, > } > > /* Which key do we want ? -1 -> tx index */ > - if ((index < 0) || (index >= 4)) > + if (index < 0 || index >= 4) > index = priv->reg.wep_index; > if (priv->reg.privacy_invoked) { > enc->flags &= ~IW_ENCODE_DISABLED; > @@ -1860,7 +1860,7 @@ static int ks_wlan_set_power_mgmt(struct net_device *dev, > return -EINVAL; > > if ((*uwrq == POWER_MGMT_SAVE1 || *uwrq == POWER_MGMT_SAVE2) && > - (priv->reg.operation_mode != MODE_INFRASTRUCTURE)) > + priv->reg.operation_mode != MODE_INFRASTRUCTURE) > return -EINVAL; > > priv->reg.power_mgmt = *uwrq; > -- > 2.27.0 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel